Skip to content

Commit f61032a

Browse files
committed
fix(install): replace unicode ellipses with ASCII dots — bash with set -u was treating … as part of the variable name and failing with 'unbound variable' on the very line that defined it
1 parent 1cf856f commit f61032a

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

scripts/install.sh

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,16 +49,16 @@ need_node() {
4949

5050
install_node_macos() {
5151
if ! command -v brew >/dev/null 2>&1; then
52-
log "Homebrew not found — installing it (used to install Node.js)"
52+
log "Homebrew not found — installing it (used to install Node.js)..."
5353
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
5454
fi
55-
log "installing Node.js 22 via Homebrew"
55+
log "installing Node.js 22 via Homebrew..."
5656
brew install node@22 || brew install node
5757
brew link --overwrite --force node@22 2>/dev/null || true
5858
}
5959

6060
install_node_linux() {
61-
log "installing Node.js 22 via your package manager"
61+
log "installing Node.js 22 via your package manager..."
6262
if command -v apt-get >/dev/null 2>&1; then
6363
curl -fsSL https://deb.nodesource.com/setup_22.x | sudo -E bash -
6464
sudo apt-get install -y nodejs
@@ -73,7 +73,7 @@ install_node_linux() {
7373
}
7474

7575
if need_node; then
76-
log "Node.js 22+ not found — installing"
76+
log "Node.js 22+ not found — installing..."
7777
if [ "$PLATFORM" = macos ]; then install_node_macos; else install_node_linux; fi
7878
else
7979
log "Node.js $(node -v) detected — ok."
@@ -88,7 +88,7 @@ if ! command -v npm >/dev/null 2>&1; then
8888
fi
8989

9090
# ── 2. daemora — global npm install ─────────────────────────────────────
91-
log "installing Daemora (this may take a minute)"
91+
log "installing Daemora (this may take a minute)..."
9292
# Use sudo on Linux when npm's global prefix is a system path the user
9393
# can't write to. macOS Homebrew prefixes are user-writable.
9494
NPM_PREFIX="$(npm config get prefix 2>/dev/null || echo "")"
@@ -185,12 +185,12 @@ if [ "$PLATFORM" = macos ]; then
185185
# use osascript — it shows a GUI password dialog that works in
186186
# non-TTY shells (same trick Homebrew / Anthropic / Cursor use).
187187
if [ -w /Applications ]; then
188-
log "creating $GLOBAL_APP"
188+
log "creating $GLOBAL_APP..."
189189
if write_macos_app "$GLOBAL_APP"; then
190190
INSTALLED_APP="$GLOBAL_APP"
191191
fi
192192
elif command -v osascript >/dev/null 2>&1; then
193-
log "creating $GLOBAL_APP — macOS will ask for your password (needed to write to /Applications)"
193+
log "creating $GLOBAL_APP — macOS will ask for your password (needed to write to /Applications)..."
194194
PLIST_TMP="$(mktemp -t daemora-plist)"
195195
cat > "$PLIST_TMP" <<'PLIST_EOF'
196196
<?xml version="1.0" encoding="UTF-8"?>
@@ -224,7 +224,7 @@ PLIST_EOF
224224
# everywhere else does.
225225
if [ -z "$INSTALLED_APP" ]; then
226226
mkdir -p "$HOME/Applications"
227-
log "creating $USER_APP (no admin password needed)"
227+
log "creating $USER_APP (no admin password needed)..."
228228
if write_macos_app "$USER_APP"; then
229229
INSTALLED_APP="$USER_APP"
230230
else
@@ -240,7 +240,7 @@ PLIST_EOF
240240
else
241241
DESKTOP="$HOME/.local/share/applications/daemora.desktop"
242242
mkdir -p "$(dirname "$DESKTOP")"
243-
log "creating $DESKTOP"
243+
log "creating $DESKTOP..."
244244
cat > "$DESKTOP" <<EOF
245245
[Desktop Entry]
246246
Name=Daemora
@@ -258,7 +258,7 @@ EOF
258258
fi
259259

260260
# ── 5. Launch ───────────────────────────────────────────────────────────
261-
log "all set. starting Daemora"
261+
log "all set. starting Daemora..."
262262
nohup "$LAUNCHER" >/dev/null 2>&1 &
263263
sleep 1
264264
log ""

0 commit comments

Comments
 (0)