Use FromStr instead of From to convert a string to a hash

This commit also removes 0x prefix for string literals.

Author: Seulgi Kim

core/src/consensus/tendermint/message.rs

@@ -382,6 +382,7 @@ mod tests {
     use super::super::Step;
     use super::*;
     use rlp::rlp_encode_and_decode_test;
+    use std::str::FromStr;
 
     #[test]
     fn step_ordering() {
@@ -457,7 +458,9 @@ mod tests {
                     on: VoteOn {
                         step: VoteStep::new(2, 3, Step::Commit),
                         block_hash: Some(
-                            H256::from("07feab4c39250abf60b77d7589a5b61fdf409bd837e936376381d19db1e1f050").into()
+                            H256::from_str("07feab4c39250abf60b77d7589a5b61fdf409bd837e936376381d19db1e1f050")
+                                .unwrap()
+                                .into()
                         ),
                     },
                 },
@@ -467,7 +470,9 @@ mod tests {
                     on: VoteOn {
                         step: VoteStep::new(2, 3, Step::Commit),
                         block_hash: Some(
-                            H256::from("07feab4c39250abf60b77d7589a5b61fdf409bd837e936376381d19db1e1f050").into()
+                            H256::from_str("07feab4c39250abf60b77d7589a5b61fdf409bd837e936376381d19db1e1f050")
+                                .unwrap()
+                                .into()
                         ),
                     },
                 }
@@ -488,7 +493,9 @@ mod tests {
             signer_index: 0x1234,
             on: VoteOn {
                 step: VoteStep::new(2, 3, Step::Commit),
-                block_hash: Some(H256::from("07feab4c39250abf60b77d7589a5b61fdf409bd837e936376381d19db1e1f050").into()),
+                block_hash: Some(
+                    H256::from_str("07feab4c39250abf60b77d7589a5b61fdf409bd837e936376381d19db1e1f050").unwrap().into(),
+                ),
             },
         };
         rlp_encode_and_decode_test!(message);
@@ -501,7 +508,8 @@ mod tests {
         let step = Step::Commit;
         let signature = Signature::random();
         let signer_index = 0x1234;
-        let block_hash = Some(H256::from("07feab4c39250abf60b77d7589a5b61fdf409bd837e936376381d19db1e1f050").into());
+        let block_hash =
+            Some(H256::from_str("07feab4c39250abf60b77d7589a5b61fdf409bd837e936376381d19db1e1f050").unwrap().into());
         let consensus_message = ConsensusMessage {
             signature,
             signer_index,

json/src/hash.rs

@@ -99,14 +99,17 @@ impl_hash!(H520, Hash520);
 #[cfg(test)]
 mod test {
     use super::H256;
+    use std::str::FromStr;
 
     #[test]
     fn hash_deserialization() {
         let s = r#"["", "5a39ed1020c04d4d84539975b893a4e7c53eab6c2965db8bc3468093a31bc5ae"]"#;
         let deserialized: Vec<H256> = serde_json::from_str(s).unwrap();
         assert_eq!(deserialized, vec![
             H256(primitives::H256::zero()),
-            H256(primitives::H256::from("5a39ed1020c04d4d84539975b893a4e7c53eab6c2965db8bc3468093a31bc5ae")),
+            H256(
+                primitives::H256::from_str("5a39ed1020c04d4d84539975b893a4e7c53eab6c2965db8bc3468093a31bc5ae").unwrap()
+            ),
         ]);
     }
 

json/src/scheme/genesis.rs

@@ -77,15 +77,15 @@ mod tests {
                 prev_view: 0x0.into(),
                 cur_view: 0x0.into(),
                 precommits: vec![
-                    H520(Core520::from("0x0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000")),
+                    H520(Core520::from_str("0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000").unwrap()),
                 ]
             }),
             author: Some(PlatformAddress::from_str("fjjh0000AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAtc0").unwrap()),
             timestamp: Some(0x07.into()),
-            parent_hash: Some(H256(Core256::from("0x9000000000000000000000000000000000000000000000000000000000000000"))),
+            parent_hash: Some(H256(Core256::from_str("9000000000000000000000000000000000000000000000000000000000000000").unwrap())),
             transactions_root: None,
-            state_root: Some(H256(Core256::from("0xd7f8974fb5ac78d9ac099b9ad5018bedc2ce0a72dad1827a1709da30580f0544"))),
-            next_validator_set_hash: Some(H256(Core256::from("0xd7f8974fb5ac78d9ac099b9ad5018bedc2ce0a72dad1827a1709da30580f0544"))),
+            state_root: Some(H256(Core256::from_str("d7f8974fb5ac78d9ac099b9ad5018bedc2ce0a72dad1827a1709da30580f0544").unwrap())),
+            next_validator_set_hash: Some(H256(Core256::from_str("d7f8974fb5ac78d9ac099b9ad5018bedc2ce0a72dad1827a1709da30580f0544").unwrap())),
             extra_data: Some(Bytes::from_str("0x11bbe8db4e347b4e8c937c1c8370e4b5ed33adb3db69cbdb7a38e1e50b1b82fa").unwrap()),
         });
     }

json/src/scheme/seal.rs

@@ -45,6 +45,7 @@ mod tests {
     use crate::bytes::Bytes;
     use crate::hash::H520;
     use primitives::H520 as Core520;
+    use std::str::FromStr;
 
     #[test]
     fn seal_deserialization() {
@@ -69,7 +70,7 @@ mod tests {
             Seal::Tendermint(TendermintSeal {
                 prev_view: 0x3.into(),
                 cur_view: 0x4.into(),
-                precommits: vec![H520(Core520::from("0x4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004"))]
+                precommits: vec![H520(Core520::from_str("4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004").unwrap())]
             }),
         ]);
     }

state/src/impls/top_level.rs

@@ -623,6 +623,7 @@ impl TopState for TopLevelState {
 
 #[cfg(test)]
 mod tests_state {
+    use std::str::FromStr;
     use std::sync::Arc;
 
     use cdb::{new_journaldb, Algorithm};
@@ -970,7 +971,7 @@ mod tests_state {
         let mut state = get_temp_state();
         let a = Public::default();
         state.get_account_mut(&a).unwrap();
-        assert_eq!(Ok(H256::from("d53db6d6b7631919a40209daec6271dc77c6ae67155afa6ce0efabf7978de67a")), state.commit());
+        assert_eq!(Ok(H256::from_str("d53db6d6b7631919a40209daec6271dc77c6ae67155afa6ce0efabf7978de67a").unwrap()), state.commit());
     }
 
     #[test]