Ref: Don't duplicate state, use property for scoreboard

Author: klieret

codeclash/tournaments/pvp_training.py

@@ -30,7 +30,10 @@ def __init__(
         for agent_conf in self.config["players"]:
             self.agents.append(self.get_agent(agent_conf, self.config["prompts"]))
         self.logger = get_logger(self.game.name)
-        self.scoreboard: list[tuple[int, str]] = []
+
+    @property
+    def scoreboard(self) -> list[tuple[int, str]]:
+        return self._metadata.setdefault("scoreboard", [])
 
     @property
     def rounds(self) -> int:

codeclash/tournaments/single_player_training.py

@@ -16,7 +16,7 @@
 
 
 class SinglePlayerTraining(AbstractTournament):
-    def __init__(self, config: dict, cleanup: bool = False):
+    def __init__(self, config: dict, *, cleanup: bool = False):
         super().__init__(config, name="SinglePlayerTraining")
         self.cleanup_on_end = cleanup
         self.game: CodeGame = get_game(
@@ -28,7 +28,10 @@ def __init__(self, config: dict, cleanup: bool = False):
         mirror_agent_config = copy.deepcopy(self.config["player"])
         mirror_agent_config["name"] = "mirror"
         self.mirror_agent: Player = self.get_agent(mirror_agent_config, round=0)
-        self.scoreboard: list[tuple[int, str]] = []
+
+    @property
+    def scoreboard(self) -> list[tuple[int, str]]:
+        return self._metadata.setdefault("scoreboard", [])
 
     @property
     def rounds(self) -> int: