Minor bug fix (config -> self.config); change print to logger.info

Author: john-b-yang

codeclash/games/abstract.py

@@ -1,11 +1,11 @@
 import os
 import subprocess
+import time
 import traceback
 from abc import ABC, abstractmethod
 from collections import Counter
 from pathlib import Path
 from typing import Any
-from uuid import uuid4
 
 from minisweagent.environments.docker import DockerEnvironment
 
@@ -26,7 +26,7 @@ def __init__(self, config: dict):
         self.config: dict = config["game"]
         self.rounds: int = self.config.get("rounds", 1)
         self.round: int = 0
-        self.game_id: str = f"{self.name}{uuid4().hex[:6]}"
+        self.game_id: str = f"{self.name}{time.strftime('%y%m%d%H%M')}"
         self.log_path: Path = (DIR_WORK / DIR_LOGS / self.game_id).resolve()
         self.logger = get_logger(
             self.name, log_path=DIR_LOGS / self.game_id / "game.log", emoji="🏓"

codeclash/games/battlecode/main.py

@@ -12,7 +12,7 @@ def __init__(self, config):
         super().__init__(config)
         assert len(config["players"]) == 2, "BattleCode is a two-player game"
         self.run_cmd_round: str = "python run.py run"
-        for arg, val in config.get("args", {}).items():
+        for arg, val in self.config.get("args", {}).items():
             if isinstance(val, bool):
                 if val:
                     self.run_cmd_round += f" --{arg}"
@@ -36,6 +36,6 @@ def execute_round(self, agents: list[Any]):
             for idx, agent in enumerate(agents)
         ]
         cmd = f"{self.run_cmd_round} {' '.join(args)} > {self.round_log_path}"
-        print(f"Running command: {cmd}")
+        self.logger.info(f"Running command: {cmd}")
         response = self.environment.execute(cmd)
         assert response["returncode"] == 0, response

codeclash/games/battlesnake/main.py

@@ -12,7 +12,7 @@ class BattleSnakeGame(CodeGame):
     def __init__(self, config):
         super().__init__(config)
         self.run_cmd_round: str = "./battlesnake play"
-        for arg, val in config.get("args", {}).items():
+        for arg, val in self.config.get("args", {}).items():
             if isinstance(val, bool):
                 if val:
                     self.run_cmd_round += f" --{arg}"

codeclash/games/corewar/main.py

@@ -10,7 +10,7 @@ class CoreWarGame(CodeGame):
     def __init__(self, config):
         super().__init__(config)
         self.run_cmd_round: str = "./src/pmars"
-        for arg, val in config.get("args", {}).items():
+        for arg, val in self.config.get("args", {}).items():
             if isinstance(val, bool):
                 if val:
                     self.run_cmd_round += f" -{arg}"
@@ -31,6 +31,6 @@ def determine_winner(self, agents: list[Player]):
     def execute_round(self, agents: list[Player]):
         args = [f"/{agent.name}/warriors/warrior.red" for agent in agents]
         cmd = f"{self.run_cmd_round} {' '.join(args)} > {self.round_log_path}"
-        print(f"Running command: {cmd}")
+        self.logger.info(f"Running command: {cmd}")
         response = self.environment.execute(cmd)
         assert response["returncode"] == 0, response

codeclash/games/robocode/main.py

@@ -11,7 +11,7 @@ class RoboCodeGame(CodeGame):
     def __init__(self, config):
         super().__init__(config)
         self.run_cmd_round: str = "./robocode.sh"
-        for arg, val in config.get("args", {}).items():
+        for arg, val in self.config.get("args", {}).items():
             if isinstance(val, bool):
                 if val:
                     self.run_cmd_round += f" -{arg}"
@@ -84,6 +84,6 @@ def execute_round(self, agents: list[Player]):
         cmd = (
             f"{self.run_cmd_round} -battle {battle_file} -results {self.round_log_path}"
         )
-        print(f"Running command: {cmd}")
+        self.logger.info(f"Running command: {cmd}")
         response = self.environment.execute(cmd)
         assert response["returncode"] == 0, response

codeclash/games/robotrumble/main.py

@@ -23,6 +23,6 @@ def determine_winner(self, agents: list[Player]):
     def execute_round(self, agents: list[Player]):
         args = [f"/{agent.name}/robot.py" for agent in agents]
         cmd = f"{self.run_cmd_round} {' '.join(args)} > {self.round_log_path}"
-        print(f"Running command: {cmd}")
+        self.logger.info(f"Running command: {cmd}")
         response = self.environment.execute(cmd)
         assert response["returncode"] == 0, response