Fix ruff issues

Author: Muhtasham

codeclash/arenas/bridge/bridge.py

@@ -3,7 +3,6 @@
 import json
 import shlex
 import subprocess
-from collections import Counter
 from concurrent.futures import ThreadPoolExecutor, as_completed
 
 from tqdm.auto import tqdm
@@ -53,10 +52,7 @@ def validate_code(self, agent: Player) -> tuple[bool, str | None]:
         content = agent.environment.execute(f"cat {self.submission}")["output"]
 
         # Check for required function definitions
-        required_functions = [
-            "def get_bid(",
-            "def play_card("
-        ]
+        required_functions = ["def get_bid(", "def play_card("]
 
         missing = []
         for func in required_functions:
@@ -86,7 +82,7 @@ def _run_single_simulation(self, agents: list[Player], idx: int, cmd: str):
 
     def execute_round(self, agents: list[Player]):
         """Execute a round of Bridge games."""
-        sims = self.game_config.get('sims_per_round', 10)
+        sims = self.game_config.get("sims_per_round", 10)
         self.logger.info(f"Running {sims} Bridge simulations with 4 players")
 
         # Build agent paths for the command
@@ -100,12 +96,7 @@ def execute_round(self, agents: list[Player]):
         # Run simulations in parallel
         with ThreadPoolExecutor(max_workers=8) as executor:
             futures = [
-                executor.submit(
-                    self._run_single_simulation,
-                    agents,
-                    idx,
-                    f"{cmd} --seed {idx} --dealer {idx % 4}"
-                )
+                executor.submit(self._run_single_simulation, agents, idx, f"{cmd} --seed {idx} --dealer {idx % 4}")
                 for idx in range(sims)
             ]
             for future in tqdm(as_completed(futures), total=len(futures), desc="Bridge simulations"):
@@ -114,11 +105,11 @@ def execute_round(self, agents: list[Player]):
     def get_results(self, agents: list[Player], round_num: int, stats: RoundStats):
         """Parse results and determine winners."""
         # Initialize team scores
-        team_scores = {'NS': 0.0, 'EW': 0.0}
+        team_scores = {"NS": 0.0, "EW": 0.0}
         games_played = 0
 
         # Parse all simulation logs
-        for idx in range(self.game_config.get('sims_per_round', 10)):
+        for idx in range(self.game_config.get("sims_per_round", 10)):
             log_file = self.log_round(round_num) / f"sim_{idx}.json"
 
             if not log_file.exists():
@@ -130,15 +121,15 @@ def get_results(self, agents: list[Player], round_num: int, stats: RoundStats):
                     result = json.load(f)
 
                 # Check for error
-                if 'error' in result:
+                if "error" in result:
                     self.logger.warning(f"Simulation {idx} had error: {result['error']}")
                     continue
 
                 # Extract VP scores for each team
-                vp_scores = result.get('normalized_score', {})
+                vp_scores = result.get("normalized_score", {})
                 if vp_scores:
-                    team_scores['NS'] += vp_scores.get('NS', 0.0)
-                    team_scores['EW'] += vp_scores.get('EW', 0.0)
+                    team_scores["NS"] += vp_scores.get("NS", 0.0)
+                    team_scores["EW"] += vp_scores.get("EW", 0.0)
                     games_played += 1
             except (json.JSONDecodeError, KeyError) as e:
                 self.logger.warning(f"Error parsing {log_file}: {e}")
@@ -153,20 +144,20 @@ def get_results(self, agents: list[Player], round_num: int, stats: RoundStats):
             return
 
         # Average the scores
-        team_scores['NS'] /= games_played
-        team_scores['EW'] /= games_played
+        team_scores["NS"] /= games_played
+        team_scores["EW"] /= games_played
 
         # Determine winning team
-        if abs(team_scores['NS'] - team_scores['EW']) < 0.01:  # Tie threshold
+        if abs(team_scores["NS"] - team_scores["EW"]) < 0.01:  # Tie threshold
             stats.winner = RESULT_TIE
-        elif team_scores['NS'] > team_scores['EW']:
+        elif team_scores["NS"] > team_scores["EW"]:
             stats.winner = f"{agents[0].name}/{agents[2].name}"
         else:
             stats.winner = f"{agents[1].name}/{agents[3].name}"
 
         # Assign scores to individual players based on their team
         for position, agent in enumerate(agents):
-            team = 'NS' if position % 2 == 0 else 'EW'
+            team = "NS" if position % 2 == 0 else "EW"
             score = team_scores[team]
             stats.scores[agent.name] = score
             stats.player_stats[agent.name].score = score

codeclash/arenas/figgie/figgie.py

@@ -61,7 +61,9 @@ def __init__(self, config, **kwargs):
 
     def execute_round(self, agents: list[Player]) -> None:
         args = [f"/{agent.name}/{self.submission}" for agent in agents]
-        cmd = f"python engine.py {' '.join(args)} -r {self.game_config['sims_per_round']} > {self.log_env / FIGGIE_LOG};"
+        cmd = (
+            f"python engine.py {' '.join(args)} -r {self.game_config['sims_per_round']} > {self.log_env / FIGGIE_LOG};"
+        )
         self.logger.info(f"Running game: {cmd}")
         assert_zero_exit_code(self.environment.execute(cmd))
 

codeclash/arenas/gomoku/gomoku.py

@@ -28,7 +28,9 @@ def __init__(self, config, **kwargs):
 
     def execute_round(self, agents: list[Player]) -> None:
         args = [f"/{agent.name}/{self.submission}" for agent in agents]
-        cmd = f"python engine.py {' '.join(args)} -r {self.game_config['sims_per_round']} > {self.log_env / GOMOKU_LOG};"
+        cmd = (
+            f"python engine.py {' '.join(args)} -r {self.game_config['sims_per_round']} > {self.log_env / GOMOKU_LOG};"
+        )
         self.logger.info(f"Running game: {cmd}")
         assert_zero_exit_code(self.environment.execute(cmd))
 
@@ -75,7 +77,7 @@ def validate_code(self, agent: Player) -> tuple[bool, str | None]:
             return (
                 False,
                 f"{self.submission} must define a get_move(board, color) function. "
-                "See the game description for the required signature."
+                "See the game description for the required signature.",
             )
 
         return True, None

tests/arenas/test_bridge.py

@@ -105,7 +105,6 @@ def get_bid(game_state):
         assert "def play_card(" in error
 
 
-
 class TestBridgeRequirements:
     """Test Bridge-specific requirements."""
 
@@ -119,11 +118,7 @@ def test_requires_4_players(self, minimal_config, tmp_log_dir):
         ]
 
         with pytest.raises(ValueError, match="Bridge requires exactly 4 players"):
-            BridgeArena(
-                config,
-                tournament_id="test_tournament",
-                local_output_dir=tmp_log_dir
-            )
+            BridgeArena(config, tournament_id="test_tournament", local_output_dir=tmp_log_dir)
 
     def test_accepts_4_players(self):
         """Test that Bridge accepts exactly 4 players by checking class properties."""

tests/arenas/test_figgie.py

@@ -101,26 +101,16 @@ def test_rejects_invalid_player_count(self, minimal_config, tmp_log_dir):
         ]
 
         with pytest.raises(ValueError, match="Figgie requires 4 or 5 players"):
-            FiggieArena(
-                config,
-                tournament_id="test_tournament",
-                local_output_dir=tmp_log_dir
-            )
+            FiggieArena(config, tournament_id="test_tournament", local_output_dir=tmp_log_dir)
 
     def test_rejects_6_players(self, minimal_config, tmp_log_dir):
         """Test that Figgie rejects 6 players."""
         config = minimal_config.copy()
         config["game"]["name"] = "Figgie"
-        config["players"] = [
-            {"name": f"p{i}", "agent": "dummy"} for i in range(6)
-        ]
+        config["players"] = [{"name": f"p{i}", "agent": "dummy"} for i in range(6)]
 
         with pytest.raises(ValueError, match="Figgie requires 4 or 5 players"):
-            FiggieArena(
-                config,
-                tournament_id="test_tournament",
-                local_output_dir=tmp_log_dir
-            )
+            FiggieArena(config, tournament_id="test_tournament", local_output_dir=tmp_log_dir)
 
     def test_accepts_4_or_5_players(self):
         """Test that Figgie accepts 4 or 5 players by checking class properties."""