Harden battlesnake and robotrumble against timeouts

Closes #62

Author: klieret

codeclash/games/battlesnake/battlesnake.py

@@ -1,5 +1,6 @@
 import json
 import random
+import subprocess
 import time
 from concurrent.futures import ThreadPoolExecutor, as_completed
 
@@ -58,10 +59,16 @@ def _run_single_simulation(self, player2port: dict[str, int], idx: int) -> str:
 
         cmd = self.run_cmd_round + " " + " ".join(cmd_args) + f" -o {self.log_env / f'sim_{idx}.jsonl'}"
 
-        output = self.environment.execute(
-            cmd,
-            cwd=f"{self.environment.config.cwd}/game",
-        )
+        # https://github.com/emagedoc/CodeClash/issues/62 (timeouts)
+        try:
+            output = self.environment.execute(
+                cmd,
+                cwd=f"{self.environment.config.cwd}/game",
+                timeout=120,  # this should rarely ever reach this timeout
+            )
+        except subprocess.TimeoutError:
+            self.logger.warning(f"Battlesnake simulation timed out: {cmd}")
+            return ""
         if output["returncode"] != 0:
             self.logger.warning(
                 f"Battlesnake simulation failed with exit code {output['returncode']}:\n{output['output']}"

codeclash/games/robotrumble/robotrumble.py

@@ -1,4 +1,5 @@
 import shlex
+import subprocess
 from collections import Counter
 from concurrent.futures import ThreadPoolExecutor, as_completed
 
@@ -22,7 +23,12 @@ def _run_single_simulation(self, agents: list[Player], idx: int) -> str:
         args = [f"/{agent.name}/robot.py" for agent in agents]
         cmd = f"{self.run_cmd_round} {shlex.join(args)} > {self.log_env / f'sim_{idx}.txt'}"
 
-        output = self.environment.execute(cmd)
+        # https://github.com/emagedoc/CodeClash/issues/62 (timeouts)
+        try:
+            output = self.environment.execute(cmd, timeout=120)
+        except subprocess.TimeoutError:
+            self.logger.warning(f"RobotRumble simulation {idx} timed out: {cmd}")
+            return ""
         if output["returncode"] != 0:
             self.logger.warning(
                 f"RobotRumble simulation {idx} failed with exit code {output['returncode']}:\n{output['output']}"