Fix(viewer): Don't assume p1, p2, use real player names

Author: klieret

.cursor/rules/viewer.mdc

@@ -79,6 +79,116 @@ Here's how a `.traj.log` file looks:
 }
 ```
 
+Here's how the metadata.json file looks like:
+
+```
+{
+  "name": "PvpTournament",
+  "tournament_id": "PvpTournament.BattleSnake.250915203207",
+  "config": {
+    "tournament": {
+      "rounds": 10
+    },
+    "game": {
+      "name": "BattleSnake",
+      "sims_per_round": 1000,
+      "args": {
+        "width": 11,
+        "height": 11,
+        "browser": false
+      }
+    },
+    "players": [
+      {
+        "agent": "mini",
+        "name": "gpt-5-mini-more-prescriptive",
+        "config": {
+          "agent": {
+            "system_template": "",
+            "instance_template": "",
+            "step_limit": 30,
+            "cost_limit": 1.0
+          },
+          "model": {
+            "model_name": "openai/gpt-5-mini"
+          }
+        }
+      },
+      {
+        "agent": "mini",
+        "name": "gpt-5-mini-default",
+        "config": {
+          "agent": {...},
+          "model": {
+            "model_name": "openai/gpt-5-mini"
+          }
+        }
+      }
+    ],
+    "prompts": {
+      "game_description": "..."}
+  },
+  "created_timestamp": 1757982727,
+  "game": {
+    "name": "BattleSnake",
+    "config": {
+      "name": "BattleSnake",
+      "sims_per_round": 1000,
+      "args": {
+        "width": 11,
+        "height": 11,
+        "browser": false
+      }
+    },
+    "game_id": "PvpTournament.BattleSnake.250915203207",
+    "created_timestamp": 1757982727
+  },
+  "agents": [
+    {
+      "name": "gpt-5-mini-more-prescriptive",
+      "player_unique_id": "38f5a945-2a14-4cfb-9a41-e3ccceb7d3e2",
+      "created_timestamp": 1757982729,
+      "config": {
+        "agent": "mini",
+        "name": "gpt-5-mini-more-prescriptive",
+        "config": {
+          "agent": {
+            "system_template": "...,
+            "instance_template": "...",
+            "step_limit": 30,
+            "cost_limit": 1.0
+          },
+          "model": {
+            "model_name": "openai/gpt-5-mini"
+          }
+        }
+      },
+      "initial_commit_hash": "dc7bdb934a2f1bba88d19136ff5caa6ff789dda7",
+      "branch_name": "PvpTournament.BattleSnake.250915203207.gpt-5-mini-more-prescriptive",
+      "round_tags": {}
+    },
+    {
+      "name": "gpt-5-mini-default",
+      "player_unique_id": "646cdd66-7cd5-4318-988f-3858ef3bd860",
+      "created_timestamp": 1757982730,
+      "config": {
+        "agent": "mini",
+        "name": "gpt-5-mini-default",
+        "config": {
+          "agent": {...},
+          "model": {
+            "model_name": "openai/gpt-5-mini"
+          }
+        }
+      },
+      "initial_commit_hash": "dc7bdb934a2f1bba88d19136ff5caa6ff789dda7",
+      "branch_name": "PvpTournament.BattleSnake.250915203207.gpt-5-mini-default",
+      "round_tags": {}
+    }
+  ]
+}
+```
+
 ## Application Structure
 
 The application has two main pages:
@@ -187,3 +297,7 @@ Then, show all the messages. Each message should be its own block together with
 Because the content can be long, make sure to have a foldout for the content.
 
 **Message Role Badges**: Each message displays a small role badge (e.g., "User #1", "Assistant #2") in the top-right corner. These badges automatically hide on hover over the message block to improve readability and allow users to see text that might be obscured by the badge.
+
+### Important
+
+* Always use the player name from the metadata.json file, do not assume players are called p1, p2, etc.

codeclash/games/game.py

@@ -168,6 +168,7 @@ def get_environment(self, branch_name: str | None = None) -> DockerEnvironment:
                 "TQDM_DISABLE": "1",
             },
             container_timeout="3h",
+            logger=self.logger,
         )
         # Logger setting will likely not take effect for initial container creation logs
         environment.logger = get_logger("environment", emoji="🪴")

codeclash/viewer/app.py

@@ -88,26 +88,53 @@ def get_models_from_metadata(log_dir: Path) -> list[str]:
 def get_agent_info_from_metadata(metadata: dict[str, Any]) -> list[AgentInfo]:
     """Extract detailed agent information from metadata"""
     agents = []
+
+    # First, try to get agent info from the agents field (runtime metadata)
+    if "agents" in metadata:
+        for agent_data in metadata["agents"]:
+            name = agent_data.get("name", "unknown")
+            # Try to get model info from the agent's config
+            config = agent_data.get("config", {})
+            model_name = (
+                config.get("model", {}).get("model_name")
+                if isinstance(config.get("model"), dict)
+                else config.get("model")
+            )
+            agent_class = config.get("agent_class")
+            agents.append(AgentInfo(name=name, model_name=model_name, agent_class=agent_class))
+        return agents
+
+    # Fallback to config-based extraction if no agents field
     players_config = metadata.get("config", {}).get("players", {})
 
     # Handle both list and dict formats
     if isinstance(players_config, list):
-        # If players is a list, iterate through each player
-        for i, player_config in enumerate(players_config):
+        # If players is a list, use the actual name from each player config
+        for player_config in players_config:
             if isinstance(player_config, dict):
-                name = f"p{i + 1}"  # Default naming p1, p2, etc.
+                name = player_config.get("name", "unknown")  # Use actual agent name
                 config = player_config.get("config", {})
-                model_name = config.get("model", {}).get("model_name")
+                model_name = (
+                    config.get("model", {}).get("model_name")
+                    if isinstance(config.get("model"), dict)
+                    else config.get("model")
+                )
                 agent_class = config.get("agent_class")
                 agents.append(AgentInfo(name=name, model_name=model_name, agent_class=agent_class))
     elif isinstance(players_config, dict):
-        # If players is a dict, iterate through player keys (p1, p2, etc.)
+        # If players is a dict, iterate through player keys
         for player_key, player_config in sorted(players_config.items()):
             if isinstance(player_config, dict):
+                # Use the actual name from config if available, otherwise use the key
+                name = player_config.get("name", player_key)
                 config = player_config.get("config", {})
-                model_name = config.get("model", {}).get("model_name")
+                model_name = (
+                    config.get("model", {}).get("model_name")
+                    if isinstance(config.get("model"), dict)
+                    else config.get("model")
+                )
                 agent_class = config.get("agent_class")
-                agents.append(AgentInfo(name=player_key, model_name=model_name, agent_class=agent_class))
+                agents.append(AgentInfo(name=name, model_name=model_name, agent_class=agent_class))
 
     return agents