Fixes #55: Shuffle agents in case of positional advantages

Author: john-b-yang

codeclash/games/battlecode/battlecode.py

@@ -1,4 +1,3 @@
-import random
 import re
 from pathlib import Path
 
@@ -29,7 +28,6 @@ def execute_round(self, agents: list[Player]):
         for agent in agents:
             src, dest = f"/{agent.name}/src/{BC_FOLDER}/", str(DIR_WORK / "src" / agent.name)
             self.environment.execute(f"cp -r {src} {dest}")
-        random.shuffle(agents)  # Start position matters in BattleCode! Shuffle to be fair.
         args = [f"--p{idx + 1}-dir src --p{idx + 1} {agent.name}" for idx, agent in enumerate(agents)]
         cmd = f"{self.run_cmd_round} {' '.join(args)}"
         self.logger.info(f"Running game: {cmd}")

codeclash/games/game.py

@@ -1,4 +1,5 @@
 import os
+import random
 import subprocess
 import time
 from abc import ABC, abstractmethod
@@ -205,6 +206,7 @@ def run_round(self, agents: list[Player], round_num: int) -> RoundStats:
         Returns the log output, result output, and winner name. All bookkeeping should be
         handled by the tournament class.
         """
+        random.shuffle(agents)  # Shuffle to ensure fairness in case of positional advantages
         stats = RoundStats(round_num, agents)
         validated = []
         for agent in agents: