Skip to content

Commit 0fd9767

Browse files
Update mctp help to be consistent with the use of IFNAME
The help information for the mctp tool alternated between using <dev> and <IFNAME> when describing interface names. Switch to use <IFNAME> consistently, which should be more helpful than `dev <dev>`. Update README.md to reflect the changes and add `mctp monitor` to the end, which had been ommitted. Signed-off-by: James Lee <james@codeconstruct.com.au>
1 parent 65a6334 commit 0fd9767

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,17 @@ Use `mctp help` for the list of available commands:
5252

5353
mctp route
5454
mctp route show [net <network>]
55-
mctp route add <eid>[-<eid>] via <dev> [mtu <mtu>]
55+
mctp route add <eid>[-<eid>] via <IFNAME> [mtu <mtu>]
5656
mctp route add <eid>[-<eid>] gw <eid> [net <net>] [mtu <mtu>]
57-
mctp route del <eid>[-<eid>] via <dev>
57+
mctp route del <eid>[-<eid>] via <IFNAME>
5858
mctp route del <eid>[-<eid>] gw <eid> [net <net>]
5959

6060
mctp neigh
6161
mctp neigh show [dev <network>]
62-
mctp neigh add <eid> dev <device> lladdr <physaddr>
63-
mctp neigh del <eid> dev <device>
62+
mctp neigh add <eid> dev <IFNAME> lladdr <physaddr>
63+
mctp neigh del <eid> dev <IFNAME>
64+
65+
mctp monitor
6466

6567
`mctpd` Usage
6668
-------------

src/mctp.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,12 +1126,12 @@ static int cmd_route(struct ctx *ctx, int argc, const char **argv)
11261126
fprintf(stderr, "%s route show [net <network>]\n",
11271127
ctx->top_cmd);
11281128
fprintf(stderr,
1129-
"%s route add <eid>[-<eid>] via <dev> [mtu <mtu>]\n",
1129+
"%s route add <eid>[-<eid>] via <IFNAME> [mtu <mtu>]\n",
11301130
ctx->top_cmd);
11311131
fprintf(stderr,
11321132
"%s route add <eid>[-<eid>] gw <eid> [net <net>] [mtu <mtu>]\n",
11331133
ctx->top_cmd);
1134-
fprintf(stderr, "%s route del <eid>[-<eid>] via <dev>\n",
1134+
fprintf(stderr, "%s route del <eid>[-<eid>] via <IFNAME>\n",
11351135
ctx->top_cmd);
11361136
fprintf(stderr,
11371137
"%s route del <eid>[-<eid>] gw <eid> [net <net>]\n",
@@ -1336,11 +1336,11 @@ static int cmd_neigh(struct ctx *ctx, int argc, const char **argv)
13361336
fprintf(stderr, "%s neigh show [dev <network>]\n",
13371337
ctx->top_cmd);
13381338
fprintf(stderr,
1339-
"%s neigh add <eid> dev <device> lladdr <physaddr>\n",
1339+
"%s neigh add <eid> dev <IFNAME> lladdr <physaddr>\n",
13401340
ctx->top_cmd);
13411341
fprintf(stderr,
13421342
" <physaddr> syntax is for example \"1d\" or \"aa:bb:cc:11:22:33\"\n");
1343-
fprintf(stderr, "%s neigh del <eid> dev <device>\n",
1343+
fprintf(stderr, "%s neigh del <eid> dev <IFNAME>\n",
13441344
ctx->top_cmd);
13451345
return 255;
13461346
}

0 commit comments

Comments
 (0)