Commit fd9cf4d
committed
fix: remove incorrect skip logic for overconfident_comment that was causing false negatives
The skip logic at lines 825-831 was inverted - it was skipping lines that START with
// (actual comments with overconfident language) instead of only skipping lines where
the pattern appeared in non-comment contexts.
This caused the detector to miss true positives like:
// This is obviously the right approach
// The code clearly handles edge cases
missed-true-positives.ts now correctly shows 17 issues (up from 9).1 parent 55f09ef commit fd9cf4d
2 files changed
+1
-15
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
822 | 822 | | |
823 | 823 | | |
824 | 824 | | |
825 | | - | |
826 | | - | |
827 | | - | |
828 | | - | |
829 | | - | |
830 | | - | |
831 | | - | |
| 825 | + | |
832 | 826 | | |
833 | 827 | | |
834 | 828 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
691 | 691 | | |
692 | 692 | | |
693 | 693 | | |
694 | | - | |
695 | | - | |
696 | | - | |
697 | | - | |
698 | | - | |
699 | | - | |
700 | | - | |
701 | | - | |
702 | 694 | | |
703 | 695 | | |
704 | 696 | | |
| |||
0 commit comments