Disabled animation for utility area when hiding interface

- Added command "open.drawer.no.animation" to command manager. This will toggle the utility area, without an animation.
- Added option possibility of no animation to SplitViewItem.Update
- Added struct SplitViewItemCanAnimateViewTraitKey and function splitViewCanAnimate to SplitViewModifiers. These optionally allow disabling animations for SplitViews.
- Updated "Hide Interface", WorkspaceView and UtilityAreaViewModel to accommodate these changes

Author: SimonKudsk

CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift

@@ -276,7 +276,7 @@ final class CodeEditWindowController: NSWindowController, NSToolbarDelegate, Obs
             toggleLastPanel(shouldAnimate: false)
         }
         if workspace?.utilityAreaModel?.isCollapsed != utilityAreaTargetState {
-            CommandManager.shared.executeCommand("open.drawer")
+            CommandManager.shared.executeCommand("open.drawer.no.animation")
         }
         if toolbarCollapsed != toolbarTargetState {
             toggleToolbar()

CodeEdit/Features/SplitView/Model/SplitViewItem.swift

@@ -45,9 +45,15 @@ class SplitViewItem: ObservableObject {
     /// - Parameter child: the view corresponding to the SplitViewItem.
     func update(child: _VariadicView.Children.Element) {
         self.item.canCollapse = child[SplitViewItemCanCollapseViewTraitKey.self]
+        let canAnimate = child[SplitViewItemCanAnimateViewTraitKey.self]
         DispatchQueue.main.async {
             self.observers = []
-            self.item.animator().isCollapsed = child[SplitViewItemCollapsedViewTraitKey.self].wrappedValue
+            let collapsed = child[SplitViewItemCollapsedViewTraitKey.self].wrappedValue
+            if canAnimate {
+                self.item.animator().isCollapsed = collapsed
+            } else {
+                self.item.isCollapsed = collapsed
+            }
             self.item.holdingPriority = child[SplitViewHoldingPriorityTraitKey.self]
             self.observers = self.createObservers()
         }

CodeEdit/Features/SplitView/Views/SplitViewModifiers.swift

@@ -23,6 +23,10 @@ struct SplitViewHoldingPriorityTraitKey: _ViewTraitKey {
     static var defaultValue: NSLayoutConstraint.Priority = .defaultLow
 }
 
+struct SplitViewItemCanAnimateViewTraitKey: _ViewTraitKey {
+    static var defaultValue: Bool { true }
+}
+
 extension View {
     func collapsed(_ value: Binding<Bool>) -> some View {
         self
@@ -43,4 +47,8 @@ extension View {
         self
             ._trait(SplitViewHoldingPriorityTraitKey.self, priority)
     }
+
+    func splitViewCanAnimate(_ enabled: Binding<Bool>) -> some View {
+        self._trait(SplitViewItemCanAnimateViewTraitKey.self, enabled.wrappedValue)
+    }
 }

CodeEdit/Features/StatusBar/Views/StatusBarItems/StatusBarToggleUtilityAreaButton.swift

@@ -31,6 +31,12 @@ internal struct StatusBarToggleUtilityAreaButton: View {
                     id: "open.drawer",
                     command: { [weak utilityAreaViewModel] in utilityAreaViewModel?.togglePanel() }
                 )
+                CommandManager.shared.addCommand(
+                    name: "Toggle Utility Area Without Animation",
+                    title: "Toggle Utility Area Without Animation",
+                    id: "open.drawer.no.animation",
+                    command: { [weak utilityAreaViewModel] in utilityAreaViewModel?.togglePanel(animation: false) }
+                )
             }
         }
         .onAppear {
@@ -40,6 +46,12 @@ internal struct StatusBarToggleUtilityAreaButton: View {
                 id: "open.drawer",
                 command: { [weak utilityAreaViewModel] in utilityAreaViewModel?.togglePanel() }
             )
+            CommandManager.shared.addCommand(
+                name: "Toggle Utility Area Without Animation",
+                title: "Toggle Utility Area Without Animation",
+                id: "open.drawer.no.animation",
+                command: { [weak utilityAreaViewModel] in utilityAreaViewModel?.togglePanel(animation: false) }
+            )
         }
     }
 }

CodeEdit/Features/UtilityArea/ViewModels/UtilityAreaViewModel.swift

@@ -21,6 +21,9 @@ class UtilityAreaViewModel: ObservableObject {
     /// Indicates whether debugger is collapse or not
     @Published var isCollapsed: Bool = false
 
+    /// Indicates whether collapse animation should be enabled when utility area is toggled
+    @Published var animateCollapse: Bool = true
+
     /// Returns true when the drawer is visible
     @Published var isMaximized: Bool = false
 
@@ -47,7 +50,8 @@ class UtilityAreaViewModel: ObservableObject {
         workspace.addToWorkspaceState(key: .utilityAreaMaximized, value: isMaximized)
     }
 
-    func togglePanel() {
+    func togglePanel(animation: Bool = true) {
+        self.animateCollapse = animation
         self.isMaximized = false
         self.isCollapsed.toggle()
     }

CodeEdit/WorkspaceView.swift

@@ -68,6 +68,7 @@ struct WorkspaceView: View {
                         Rectangle()
                             .collapsable()
                             .collapsed($utilityAreaViewModel.isCollapsed)
+                            .splitViewCanAnimate($utilityAreaViewModel.animateCollapse)
                             .opacity(0)
                             .frame(idealHeight: 260)
                             .frame(minHeight: 100)