Updated logic to when no panels are active

- If no panels are active, and interface hasn't been hidden, all panels will show when toggle interface is clicked
- Renamed objc functions with prefix 'objc'
- Re-added resetStoredInterfaceCollapseState - turns out it was necessary

Author: SimonKudsk

CodeEdit/Features/Documents/Controllers/CodeEditWindowController+Toolbar.swift

@@ -92,7 +92,7 @@ extension CodeEditWindowController {
             toolbarItem.toolTip = "Hide or show the Navigator"
             toolbarItem.isBordered = true
             toolbarItem.target = self
-            toolbarItem.action = #selector(self.toggleFirstPanel)
+            toolbarItem.action = #selector(self.objcToggleFirstPanel)
             toolbarItem.image = NSImage(
                 systemSymbolName: "sidebar.leading",
                 accessibilityDescription: nil
@@ -106,7 +106,7 @@ extension CodeEditWindowController {
             toolbarItem.toolTip = "Hide or show the Inspectors"
             toolbarItem.isBordered = true
             toolbarItem.target = self
-            toolbarItem.action = #selector(self.toggleLastPanel)
+            toolbarItem.action = #selector(self.objcToggleLastPanel)
             toolbarItem.image = NSImage(
                 systemSymbolName: "sidebar.trailing",
                 accessibilityDescription: nil

CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift

@@ -221,13 +221,19 @@ final class CodeEditWindowController: NSWindowController, NSToolbarDelegate, Obs
               let prevInsp = prevInspectorCollapsed,
               let prevUtil = prevUtilityAreaCollapsed,
               let prevTool = prevToolbarCollapsed
-        else { return false }
+        else {
+            return navigatorCollapsed && navigatorCollapsed && toolbarCollapsed && utilityAreaCollapsed
+        }
+
+        let stillHidden = (!prevNav && navigatorCollapsed)  ||
+            (!prevInsp && inspectorCollapsed) ||
+            (!prevUtil && utilityAreaCollapsed) ||
+            (!prevTool && toolbarCollapsed)
+
+        if !stillHidden { resetStoredInterfaceCollapseState() }
 
         // True when any panel that was previously visible is collapsed
-        return (!prevNav  && navigatorCollapsed)  ||
-               (!prevInsp && inspectorCollapsed) ||
-               (!prevUtil && utilityAreaCollapsed) ||
-               (!prevTool && toolbarCollapsed)
+        return stillHidden
     }
 
     /// Function for toggling the interface elements on or off
@@ -287,7 +293,10 @@ final class CodeEditWindowController: NSWindowController, NSToolbarDelegate, Obs
         // If ShouldHide, everything should close
         if shouldHide { return true }
 
-        // If currently visible and !shouldHide, it should not collapse
+        // If currently collapsed, and there is no previous state, show it.
+        if previouslyCollapsed == nil && currentlyCollapsed { return false }
+
+        // If currently visible and !shouldHide, it should not collapse.
         if !currentlyCollapsed && !shouldHide { return false }
 
         // If we have a previous state, return that one.
@@ -304,4 +313,12 @@ final class CodeEditWindowController: NSWindowController, NSToolbarDelegate, Obs
         prevUtilityAreaCollapsed = workspace?.utilityAreaModel?.isCollapsed
         prevToolbarCollapsed = toolbarCollapsed
     }
+
+    /// Function for resetting the stored interface visibility states
+    func resetStoredInterfaceCollapseState() {
+        prevNavigatorCollapsed = nil
+        prevInspectorCollapsed = nil
+        prevUtilityAreaCollapsed = nil
+        prevToolbarCollapsed = nil
+    }
 }

CodeEdit/Features/Documents/Controllers/CodeEditWindowControllerExtensions.swift

@@ -10,7 +10,7 @@ import Combine
 
 extension CodeEditWindowController {
     @objc
-    func toggleFirstPanel() {
+    func objcToggleFirstPanel() {
         toggleFirstPanel(shouldAnimate: true)
     }
 
@@ -30,7 +30,7 @@ extension CodeEditWindowController {
     }
 
     @objc
-    func toggleLastPanel() {
+    func objcToggleLastPanel() {
         toggleLastPanel(shouldAnimate: true)
     }