interfaceHidden will now update itself on changes

- Removed need for interfaceHidden bool
- Removed need for resetting stored interface state
- Added function isInterfaceStillHidden, checking whether "at least" the previous elements are visible again, taking other elements into account
- Hidden animation for lastpanel

Author: SimonKudsk

CodeEdit/Features/Documents/Controllers/CodeEditWindowController.swift

@@ -13,7 +13,6 @@ final class CodeEditWindowController: NSWindowController, NSToolbarDelegate, Obs
     @Published var navigatorCollapsed: Bool = false
     @Published var inspectorCollapsed: Bool = false
     @Published var toolbarCollapsed: Bool = false
-    @Published var interfaceHidden: Bool = false
 
     // These variables store the state of the windows when using "Hide interface"
     @Published var prevNavigatorCollapsed: Bool?
@@ -211,13 +210,31 @@ final class CodeEditWindowController: NSWindowController, NSToolbarDelegate, Obs
         return true
     }
 
+    var utilityAreaCollapsed: Bool {
+        workspace?.utilityAreaModel?.isCollapsed ?? true
+    }
+
+    /// Returns `true` if at least one panel that was visible is still collapsed, meaning the interface is still hidden
+    func isInterfaceStillHidden() -> Bool {
+        // If the interface is already un-hidden, we can short-circuit.
+        guard let prevNav = prevNavigatorCollapsed,
+              let prevInsp = prevInspectorCollapsed,
+              let prevUtil = prevUtilityAreaCollapsed,
+              let prevTool = prevToolbarCollapsed
+        else { return false }
+
+        // True when any panel that was previously visible is collapsed
+        return (!prevNav  && navigatorCollapsed)  ||
+               (!prevInsp && inspectorCollapsed) ||
+               (!prevUtil && utilityAreaCollapsed) ||
+               (!prevTool && toolbarCollapsed)
+    }
+
     /// Function for toggling the interface elements on or off
     ///
     /// - Parameter shouldHide: Pass `true` to hide all interface panels (and remember their current states),
     /// or `false` to restore them to how they were before hiding.
     func toggleInterface(shouldHide: Bool) {
-        interfaceHidden = shouldHide
-
         // When hiding, store how the interface looks now
         if shouldHide {
             storeInterfaceCollapseState()
@@ -236,7 +253,7 @@ final class CodeEditWindowController: NSWindowController, NSToolbarDelegate, Obs
         )
         let utilityAreaTargetState = determineDesiredCollapseState(
             shouldHide: shouldHide,
-            currentlyCollapsed: workspace?.utilityAreaModel?.isCollapsed ?? true,
+            currentlyCollapsed: utilityAreaCollapsed,
             previouslyCollapsed: prevUtilityAreaCollapsed,
         )
         let toolbarTargetState = determineDesiredCollapseState(
@@ -250,19 +267,14 @@ final class CodeEditWindowController: NSWindowController, NSToolbarDelegate, Obs
             toggleFirstPanel(shouldAnimate: false)
         }
         if inspectorCollapsed != inspectorTargetState {
-            toggleLastPanel()
+            toggleLastPanel(shouldAnimate: false)
         }
         if workspace?.utilityAreaModel?.isCollapsed != utilityAreaTargetState {
             CommandManager.shared.executeCommand("open.drawer")
         }
         if toolbarCollapsed != toolbarTargetState {
             toggleToolbar()
         }
-
-        // If enabling interface, reset the visibility states
-        if !shouldHide {
-            resetStoredInterfaceCollapseState()
-        }
     }
 
     /// Calculates the collapse state an interface element should have after a hide / show toggle.
@@ -292,12 +304,4 @@ final class CodeEditWindowController: NSWindowController, NSToolbarDelegate, Obs
         prevUtilityAreaCollapsed = workspace?.utilityAreaModel?.isCollapsed
         prevToolbarCollapsed = toolbarCollapsed
     }
-
-    /// Function for resetting the stored interface visibility states
-    func resetStoredInterfaceCollapseState() {
-        prevNavigatorCollapsed = nil
-        prevInspectorCollapsed = nil
-        prevUtilityAreaCollapsed = nil
-        prevToolbarCollapsed = nil
-    }
 }

CodeEdit/Features/Documents/Controllers/CodeEditWindowControllerExtensions.swift

@@ -31,12 +31,22 @@ extension CodeEditWindowController {
 
     @objc
     func toggleLastPanel() {
+        toggleLastPanel(shouldAnimate: true)
+    }
+
+    func toggleLastPanel(shouldAnimate: Bool = true) {
         guard let lastSplitView = splitViewController?.splitViewItems.last else {
             return
         }
 
-        NSAnimationContext.runAnimationGroup { _ in
-            lastSplitView.animator().isCollapsed.toggle()
+        if shouldAnimate {
+            // Standard animated toggle
+            NSAnimationContext.runAnimationGroup { _ in
+                lastSplitView.animator().isCollapsed.toggle()
+            }
+        } else {
+            // Instant toggle (no animation)
+            lastSplitView.isCollapsed.toggle()
         }
 
         splitViewController?.saveInspectorCollapsedState(isCollapsed: lastSplitView.isCollapsed)

CodeEdit/Features/WindowCommands/ViewCommands.swift

@@ -112,8 +112,7 @@ extension ViewCommands {
         }
 
         var isInterfaceHidden: Bool {
-            return windowController?.interfaceHidden ?? false
-            //navigatorCollapsed && inspectorCollapsed && utilityAreaCollapsed && toolbarCollapsed
+            return windowController?.isInterfaceStillHidden() ?? false
         }
 
         var body: some View {