refactor(Common): Clean up and standardize DTO and provider definitions

- Removed commented-out re-exports in DTO module files to reduce clutter and improve clarity
- Simplified `EstablishHostConnection` effect to single-line implementation
- Standardized formatting in DTOs (e.g., `CompletionItemDTO`) and provider traits by placing comments above fields/parameters
- Reorganized module exports in `LanguageFeature/DTO/mod.rs` for logical grouping
- Updated parameter formatting in provider traits (`LanguageFeatureProviderRegistry`, `SourceControlManagementProvider`, `TreeViewProvider`, `WebViewProvider`) for consistency
- Removed placeholder module comments from synchronization and testing components
- Rebuilt `libCommon` artifacts to reflect source changes

These changes enhance code maintainability and consistency across the `Common` crate, which defines Land's abstract core architecture. The cleanup aligns with our focus on declarative patterns by removing unnecessary comments and standardizing DTO/provider interfaces used by `Mountain` implementations and `Cocoon`'s Effect-TS services.

Author: NikolaRHristov

Source/DTO/mod.rs

@@ -7,17 +7,3 @@
 #![allow(non_snake_case, non_camel_case_types)]
 
 pub mod WorkSpaceEditDTO;
-
-// // Re-export shared DTOs
-// pub use self::WorkSpaceEditDTO::WorkSpaceEditDTO;
-
-// // Re-export service-specific DTOs
-// pub use crate::Configuration::DTO::*;
-// pub use crate::FileSystem::DTO::*;
-// pub use crate::IPC::DTO::*;
-// pub use crate::LanguageFeature::DTO::*;
-// pub use crate::SourceControlManagement::DTO::*;
-// pub use crate::StatusBar::DTO::*;
-// pub use crate::TreeView::DTO::*;
-// pub use crate::UserInterface::DTO::*;
-// pub use crate::WebView::DTO::*;

Source/IPC/EstablishHostConnection.rs

@@ -26,9 +26,5 @@ use crate::{Effect::ActionEffect::ActionEffect, Error::CommonError::CommonError,
 /// An `ActionEffect` that resolves to `()` on success and requires the
 /// `IPCProvider` capability to be executed.
 pub fn EstablishHostConnection(SidecarIdentifier:String) -> ActionEffect<Arc<dyn IPCProvider>, CommonError, ()> {
-	SendNotificationToSidecar(
-		SidecarIdentifier,
-		"$InitialHandshake".to_string(), // Use the conventional '$' prefix
-		Value::Null,
-	)
+	SendNotificationToSidecar(SidecarIdentifier, "$InitialHandshake".to_string(), Value::Null)
 }

Source/LanguageFeature/DTO/CompletionItemDTO.rs

@@ -11,18 +11,21 @@ use serde_json::Value;
 #[serde(rename_all = "PascalCase")]
 pub struct CompletionItemDTO {
 	/// The label of this completion item.
-	pub Label:Value, // Can be string or a CompletionItemLabel object
+	// Can be string or a CompletionItemLabel object
+	pub Label: Value,
 
 	/// The kind of this completion item.
-	pub Kind:u32, // Corresponds to vscode.CompletionItemKind enum
+	// Corresponds to vscode.CompletionItemKind enum
+	pub Kind: u32,
 
 	/// A human-readable string with additional information about this item.
 	#[serde(skip_serializing_if = "Option::is_none")]
 	pub Detail:Option<String>,
 
 	/// A human-readable string that represents a doc-comment.
 	#[serde(skip_serializing_if = "Option::is_none")]
-	pub Documentation:Option<Value>, // string or IMarkdownStringDTO
+	// string or IMarkdownStringDTO
+	pub Documentation: Option<Value>,
 
 	/// A string that should be used when comparing this item with other items.
 	#[serde(skip_serializing_if = "Option::is_none")]
@@ -35,18 +38,22 @@ pub struct CompletionItemDTO {
 	/// A string or snippet that should be inserted in a document when selecting
 	/// this completion.
 	#[serde(skip_serializing_if = "Option::is_none")]
-	pub InsertText:Option<Value>, // string or SnippetString DTO
+	// string or SnippetString DTO
+	pub InsertText: Option<Value>,
 
 	/// A range of text that should be replaced by this completion item.
 	#[serde(skip_serializing_if = "Option::is_none")]
-	pub Range:Option<Value>, // RangeDTO or { inserting: RangeDTO, replacing: RangeDTO }
+	// RangeDTO or { inserting: RangeDTO, replacing: RangeDTO }
+	pub Range: Option<Value>,
 
 	/// An optional array of additional text edits that are applied when
 	/// selecting this completion.
 	#[serde(skip_serializing_if = "Option::is_none")]
-	pub AdditionalTextEdits:Option<Vec<Value>>, // Vec<TextEditDTO>
+	// Vec<TextEditDTO>
+	pub AdditionalTextEdits: Option<Vec<Value>>,
 
 	/// A command that should be executed after inserting this completion.
 	#[serde(skip_serializing_if = "Option::is_none")]
-	pub Command:Option<Value>, // CommandDTO
+	// CommandDTO
+	pub Command: Option<Value>,
 }

Source/LanguageFeature/DTO/mod.rs

@@ -5,15 +5,15 @@
 
 #![allow(non_snake_case, non_camel_case_types)]
 
+pub mod CompletionContextDTO;
+pub mod CompletionItemDTO;
+pub mod CompletionListDTO;
 pub mod HoverResultDTO;
 pub mod IMarkdownStringDTO;
+pub mod LocationDTO;
 pub mod PositionDTO;
 pub mod ProviderType;
 pub mod RangeDTO;
-pub mod CompletionContextDTO;
-pub mod CompletionItemDTO;
-pub mod CompletionListDTO;
-pub mod LocationDTO;
 pub mod TextEditDTO;
 
 // pub use self::{

Source/LanguageFeature/LanguageFeatureProviderRegistry.rs

@@ -71,8 +71,10 @@ pub trait LanguageFeatureProviderRegistry: Environment + Send + Sync {
 	async fn ProvideCodeActions(
 		&self,
 		DocumentURI:Url,
-		RangeOrSelectionDTO:Value, // Range DTO
-		ContextDTO:Value,          // CodeActionContextDTO
+		// Range DTO
+		RangeOrSelectionDTO:Value,
+		// CodeActionContextDTO
+		ContextDTO:Value,
 	) -> Result<Option<Value /* CodeActionListDTO */>, CommonError>;
 
 	async fn ProvideCodeLenses(&self, DocumentURI:Url) -> Result<Option<Value /* CodeLensListDTO */>, CommonError>;
@@ -94,7 +96,8 @@ pub trait LanguageFeatureProviderRegistry: Environment + Send + Sync {
 	async fn ProvideDocumentFormattingEdits(
 		&self,
 		DocumentURI:Url,
-		OptionsDTO:Value, // FormattingOptions DTO
+		// FormattingOptions DTO
+		OptionsDTO:Value,
 	) -> Result<Option<Vec<TextEditDTO>>, CommonError>;
 
 	async fn ProvideDocumentHighlights(
@@ -108,8 +111,10 @@ pub trait LanguageFeatureProviderRegistry: Environment + Send + Sync {
 	async fn ProvideDocumentRangeFormattingEdits(
 		&self,
 		DocumentURI:Url,
-		RangeDTO:Value,   // Range DTO
-		OptionsDTO:Value, // FormattingOptions DTO
+		// Range DTO
+		RangeDTO:Value,
+		// FormattingOptions DTO
+		OptionsDTO:Value,
 	) -> Result<Option<Vec<TextEditDTO>>, CommonError>;
 
 	async fn ProvideHover(
@@ -122,7 +127,8 @@ pub trait LanguageFeatureProviderRegistry: Environment + Send + Sync {
 		&self,
 		DocumentURI:Url,
 		PositionDTO:PositionDTO,
-		ContextDTO:Value, // ReferenceContext DTO
+		// ReferenceContext DTO
+		ContextDTO:Value,
 	) -> Result<Option<Vec<LocationDTO>>, CommonError>;
 
 	async fn PrepareRename(&self, DocumentURI:Url, PositionDTO:PositionDTO) -> Result<Option<Value>, CommonError>;

Source/LanguageFeature/ProvideCompletions.rs

@@ -24,7 +24,8 @@ pub fn ProvideCompletions(
 ) -> ActionEffect<Arc<dyn LanguageFeatureProviderRegistry>, CommonError, Option<CompletionListDTO>> {
 	ActionEffect::New(Arc::new(move |Registry:Arc<dyn LanguageFeatureProviderRegistry>| {
 		let URIClone = DocumentURI.clone();
-		let PositionClone = PositionDTO; // PositionDTO is Copy
+		// PositionDTO is Copy
+		let PositionClone = PositionDTO;
 		let ContextClone = ContextDTO.clone();
 		let TokenClone = CancellationTokenValue.clone();
 		Box::pin(async move {

Source/SourceControlManagement/DTO/mod.rs

@@ -6,12 +6,12 @@
 #![allow(non_snake_case, non_camel_case_types)]
 
 pub mod SourceControlCreateDTO;
-pub mod SourceControlUpdateDTO;
 pub mod SourceControlGroupUpdateDTO;
 pub mod SourceControlInputBoxDTO;
 pub mod SourceControlManagementGroupDTO;
 pub mod SourceControlManagementProviderDTO;
 pub mod SourceControlManagementResourceDTO;
+pub mod SourceControlUpdateDTO;
 
 // pub use self::{
 // 	SourceControlManagementGroupDTO::SourceControlManagementGroupDTO,

Source/SourceControlManagement/SourceControlManagementProvider.rs

@@ -29,7 +29,8 @@ pub trait SourceControlManagementProvider: Environment + Send + Sync {
 	/// A `Result` containing a unique handle (`u32`) for the new provider.
 	async fn CreateSourceControl(
 		&self,
-		ProviderData:Value, // DTO: SourceControlCreateDTO
+		// DTO: SourceControlCreateDTO
+		ProviderData:Value,
 	) -> Result<u32, CommonError>;
 
 	/// Disposes of an SCM provider, removing it and its groups from the UI.
@@ -49,7 +50,8 @@ pub trait SourceControlManagementProvider: Environment + Send + Sync {
 	async fn UpdateSourceControl(
 		&self,
 		ProviderHandle:u32,
-		UpdateData:Value, // DTO: SourceControlUpdateDTO
+		// DTO: SourceControlUpdateDTO
+		UpdateData:Value,
 	) -> Result<(), CommonError>;
 
 	/// Updates the properties of an SCM resource group (e.g., "Changes").
@@ -63,7 +65,8 @@ pub trait SourceControlManagementProvider: Environment + Send + Sync {
 	async fn UpdateSourceControlGroup(
 		&self,
 		ProviderHandle:u32,
-		GroupData:Value, // DTO: SourceControlGroupUpdateDTO
+		// DTO: SourceControlGroupUpdateDTO
+		GroupData:Value,
 	) -> Result<(), CommonError>;
 
 	/// Registers or updates the SCM input box for a provider.
@@ -75,6 +78,7 @@ pub trait SourceControlManagementProvider: Environment + Send + Sync {
 	async fn RegisterInputBox(
 		&self,
 		ProviderHandle:u32,
-		InputBoxData:Value, // DTO: SourceControlInputBoxDTO
+		// DTO: SourceControlInputBoxDTO
+		InputBoxData:Value,
 	) -> Result<(), CommonError>;
 }

Source/Synchronization/mod.rs

@@ -8,11 +8,3 @@
 
 // --- Trait Definition ---
 pub mod SynchronizationProvider;
-// pub use self::SynchronizationProvider::SynchronizationProvider;
-
-// --- Data Transfer Objects ---
-// pub mod DTO; // Placeholder for future DTOs
-
-// --- Effect Constructors ---
-// mod PullUserData; // Placeholder for future effects
-// mod PushUserData;

Source/Testing/mod.rs

@@ -8,11 +8,3 @@
 
 // --- Trait Definition ---
 pub mod TestController;
-// pub use self::TestController::TestController;
-
-// --- Data Transfer Objects ---
-// pub mod DTO; // Placeholder for future DTOs
-
-// --- Effect Constructors ---
-// mod RegisterTestController; // Placeholder for future effects
-// mod RunTests;