Skip to content

Commit 1fd8d43

Browse files
style(Common): Remove non_snake_case allowance across Telemetry and Transport modules
Strip the `#![allow(non_snake_case)]` attribute from all files under `Source/Telemetry/` and `Source/Transport/` to enforce strict PascalCase naming compliance across the Core library. Also remove this allowance from `Source/IPC/Channel.rs` and `Source/IPC/SkyEvent.rs` where it was previously suppressing warnings for event types. Correct an escaped character in `SourceControlCreateDTO.rs` comments. This aligns the Common crate with the project-wide naming convention where all functions, variables, and structs must use PascalCase, removing a long-standing lint suppression that was masking naming violations in critical subsystems.
1 parent 9fb83fb commit 1fd8d43

34 files changed

Lines changed: 23 additions & 35 deletions

Source/IPC/Channel.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
//! offline-gallery stubs).
3232
//! - `Normal`: everything else.
3333
34-
#![allow(non_snake_case, non_camel_case_types)]
34+
#![allow(non_camel_case_types)]
3535

3636
/// Lane selector for Echo scheduler dispatch.
3737
///

Source/IPC/SkyEvent.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
//! `FromStr` in one pass so adding an event is a single-line change that
2727
//! compilers can't forget.
2828
29-
#![allow(non_snake_case, non_camel_case_types)]
29+
#![allow(non_camel_case_types)]
3030

3131
macro_rules! DefineSkyEvents {
3232

Source/SourceControlManagement/DTO/SourceControlCreateDTO.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ pub struct SourceControlCreateDTO {
3232
/// resolve - allocating a fresh handle here keys the
3333
/// `SourceControlManagementProviders` map under a value Cocoon will
3434
/// never reference, and every later `update_scm_group` warns
35-
/// "Received group update for unknown provider handle: <H>" while the
35+
/// "Received group update for unknown provider handle: \<H\>" while the
3636
/// SCM viewlet stays empty. Optional so callers without an external
3737
/// handle (none currently) still work via Mountain-side allocation.
3838
#[serde(default, skip_serializing_if = "Option::is_none")]

Source/Telemetry/CaptureError.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![allow(non_snake_case)]
21

32
//! Emit `land:<tier>:error` with `error_tag` + `error_message`. The
43
//! Errors & Reliability dashboard rolls these up across Mountain /

Source/Telemetry/CaptureEvent.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![allow(non_snake_case)]
21

32
//! Emit a named PostHog event. Stamps the calling `Tier` plus the
43
//! standard Land identity (`$app`, `$app_version`, `$build_mode`,

Source/Telemetry/CaptureSession.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![allow(non_snake_case)]
21

32
//! Emit `land:<tier>:session:start` with pid / OS / arch. Called once
43
//! by `Initialize::Fn` so the Boot & Startup Performance dashboard

Source/Telemetry/Client.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![allow(non_snake_case)]
21

32
//! Process-wide PostHog client singleton. Populated once by
43
//! `Initialize::Fn`; every `Capture*::Fn` reads through this static.

Source/Telemetry/Configuration.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![allow(non_snake_case)]
21

32
//! Runtime read of `.env.Land.PostHog`. Sidecars don't have their own
43
//! `build.rs` env-bake (Mountain does, for compile-time tree-shake) -

Source/Telemetry/DistinctId.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![allow(non_snake_case)]
21

32
//! Stable distinct ID for the dev session. Mirrors Mountain's
43
//! `Binary/Build/PostHogPlugin/DistinctId` so a single dev run merges

Source/Telemetry/EmitOTLPSpan.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
#![allow(non_snake_case)]
21

32
//! Fire-and-forget OTLP span exporter. Lifted from Mountain's
43
//! `IPC/DevLog/EmitOTLPSpan` so Air / Echo / Rest / Grove / Mist /

0 commit comments

Comments
 (0)