refactor(Common): Streamline effect capability access and organize DTOs

- Updated all effect constructors to directly access capabilities via `RunTime.Require()` instead of through `RunTime.GetEnvironment().Require()`, simplifying the capability access pattern in alignment with the final Land architecture where the runtime itself provides required capabilities
- Added a top-level DTO module to centralize data transfer object definitions, including new `WorkSpaceEditDTO` for workspace operations
- Implemented `ProviderType` enum in LanguageFeature DTOs to strongly type language feature provider registrations
- Enhanced the `ActionEffect` type with a `map` method for output transformation

This refactoring reduces boilerplate in effect definitions and establishes a clear structure for DTOs, improving consistency across the core abstraction layer while maintaining functional parity.

Author: NikolaRHristov

Source/Command/ExecuteCommand.rs

@@ -39,13 +39,12 @@ pub fn ExecuteCommand<TRunTime>(
 ) -> ActionEffect<Arc<TRunTime>, CommonError, Value>
 where
 	TRunTime: ApplicationRunTime + Send + Sync + 'static,
-	TRunTime::EnvironmentType: Requires<Arc<dyn CommandExecutor>>, {
+	TRunTime: Requires<Arc<dyn CommandExecutor>>, {
 	ActionEffect::New(Arc::new(move |RunTime:Arc<TRunTime>| {
 		let CommandIdentifierClone = CommandIdentifier.clone();
 		let ArgumentClone = Argument.clone();
 		Box::pin(async move {
-			let Environment = RunTime.GetEnvironment();
-			let Executor:Arc<dyn CommandExecutor> = Environment.Require();
+			let Executor:Arc<dyn CommandExecutor> = RunTime.Require();
 			Executor.ExecuteCommand(CommandIdentifierClone, ArgumentClone).await
 		})
 	}))

Source/Command/GetAllCommands.rs

@@ -26,11 +26,10 @@ use crate::{
 pub fn GetAllCommands<TRunTime>() -> ActionEffect<Arc<TRunTime>, CommonError, Vec<String>>
 where
 	TRunTime: ApplicationRunTime + Send + Sync + 'static,
-	TRunTime::EnvironmentType: Requires<Arc<dyn CommandExecutor>>, {
+	TRunTime: Requires<Arc<dyn CommandExecutor>>, {
 	ActionEffect::New(Arc::new(move |RunTime:Arc<TRunTime>| {
 		Box::pin(async move {
-			let Environment = RunTime.GetEnvironment();
-			let Executor:Arc<dyn CommandExecutor> = Environment.Require();
+			let Executor:Arc<dyn CommandExecutor> = RunTime.Require();
 			Executor.GetAllCommands().await
 		})
 	}))

Source/Command/RegisterCommand.rs

@@ -36,13 +36,12 @@ pub fn RegisterCommand<TRunTime>(
 ) -> ActionEffect<Arc<TRunTime>, CommonError, ()>
 where
 	TRunTime: ApplicationRunTime + Send + Sync + 'static,
-	TRunTime::EnvironmentType: Requires<Arc<dyn CommandExecutor>>, {
+	TRunTime: Requires<Arc<dyn CommandExecutor>>, {
 	ActionEffect::New(Arc::new(move |RunTime:Arc<TRunTime>| {
 		let SidecarIdentifierClone = SidecarIdentifier.clone();
 		let CommandIdentifierClone = CommandIdentifier.clone();
 		Box::pin(async move {
-			let Environment = RunTime.GetEnvironment();
-			let Executor:Arc<dyn CommandExecutor> = Environment.Require();
+			let Executor:Arc<dyn CommandExecutor> = RunTime.Require();
 			Executor.RegisterCommand(SidecarIdentifierClone, CommandIdentifierClone).await
 		})
 	}))

Source/Command/UnregisterCommand.rs

@@ -33,13 +33,12 @@ pub fn UnregisterCommand<TRunTime>(
 ) -> ActionEffect<Arc<TRunTime>, CommonError, ()>
 where
 	TRunTime: ApplicationRunTime + Send + Sync + 'static,
-	TRunTime::EnvironmentType: Requires<Arc<dyn CommandExecutor>>, {
+	TRunTime: Requires<Arc<dyn CommandExecutor>>, {
 	ActionEffect::New(Arc::new(move |RunTime:Arc<TRunTime>| {
 		let SidecarIdentifierClone = SidecarIdentifier.clone();
 		let CommandIdentifierClone = CommandIdentifier.clone();
 		Box::pin(async move {
-			let Environment = RunTime.GetEnvironment();
-			let Executor:Arc<dyn CommandExecutor> = Environment.Require();
+			let Executor:Arc<dyn CommandExecutor> = RunTime.Require();
 			Executor.UnregisterCommand(SidecarIdentifierClone, CommandIdentifierClone).await
 		})
 	}))

Source/Configuration/GetConfiguration.rs

@@ -38,13 +38,12 @@ pub fn GetConfiguration<TRunTime>(
 ) -> ActionEffect<Arc<TRunTime>, CommonError, Value>
 where
 	TRunTime: ApplicationRunTime + Send + Sync + 'static,
-	TRunTime::EnvironmentType: Requires<Arc<dyn ConfigurationProvider>>, {
+	TRunTime: Requires<Arc<dyn ConfigurationProvider>>, {
 	ActionEffect::New(Arc::new(move |RunTime:Arc<TRunTime>| {
 		let SectionClone = Section.clone();
 		let OverridesValueClone = OverridesValue.clone();
 		Box::pin(async move {
-			let Environment = RunTime.GetEnvironment();
-			let Provider:Arc<dyn ConfigurationProvider> = Environment.Require();
+			let Provider:Arc<dyn ConfigurationProvider> = RunTime.Require();
 
 			let OverridesParsed:ConfigurationOverridesDTO =
 				serde_json::from_value(OverridesValueClone).map_err(|e| {

Source/Configuration/InspectConfiguration.rs

@@ -42,13 +42,12 @@ pub fn InspectConfiguration<TRunTime>(
 ) -> ActionEffect<Arc<TRunTime>, CommonError, Option<InspectResultDataDTO>>
 where
 	TRunTime: ApplicationRunTime + Send + Sync + 'static,
-	TRunTime::EnvironmentType: Requires<Arc<dyn ConfigurationInspector>>, {
+	TRunTime: Requires<Arc<dyn ConfigurationInspector>>, {
 	ActionEffect::New(Arc::new(move |RunTime:Arc<TRunTime>| {
 		let KeyClone = Key.clone();
 		let OverridesValueClone = OverridesValue.clone();
 		Box::pin(async move {
-			let Environment = RunTime.GetEnvironment();
-			let Inspector:Arc<dyn ConfigurationInspector> = Environment.Require();
+			let Inspector:Arc<dyn ConfigurationInspector> = RunTime.Require();
 
 			let OverridesParsed:ConfigurationOverridesDTO =
 				serde_json::from_value(OverridesValueClone).map_err(|e| {

Source/Configuration/UpdateConfiguration.rs

@@ -46,15 +46,14 @@ pub fn UpdateConfiguration<TRunTime>(
 ) -> ActionEffect<Arc<TRunTime>, CommonError, ()>
 where
 	TRunTime: ApplicationRunTime + Send + Sync + 'static,
-	TRunTime::EnvironmentType: Requires<Arc<dyn ConfigurationProvider>>, {
+	TRunTime: Requires<Arc<dyn ConfigurationProvider>>, {
 	ActionEffect::New(Arc::new(move |RunTime:Arc<TRunTime>| {
 		let KeyClone = Key.clone();
 		let ValueToSetClone = ValueToSet.clone();
 		let OverridesValueClone = OverridesValue.clone();
 		let ScopeToLanguageClone = ScopeToLanguage;
 		Box::pin(async move {
-			let Environment = RunTime.GetEnvironment();
-			let Provider:Arc<dyn ConfigurationProvider> = Environment.Require();
+			let Provider:Arc<dyn ConfigurationProvider> = RunTime.Require();
 
 			// Deserialize the integer target into the enum.
 			let TargetParsed:ConfigurationTarget = serde_json::from_value(Value::from(TargetAsU32)).map_err(|e| {

Source/DTO/WorkSpaceEditDTO.rs

@@ -0,0 +1,20 @@
+//! # WorkSpaceEditDTO
+//!
+//! Defines the Data Transfer Object for a workspace edit, which is a collection
+//! of changes to be applied across multiple files in the workspace.
+
+use serde::{Deserialize, Serialize};
+use serde_json::Value;
+
+/// A serializable struct representing a workspace edit, which is a batch of
+/// changes that can include text edits and file operations (create, delete,
+/// rename). This is analogous to `vscode.WorkspaceEdit`.
+#[derive(Serialize, Deserialize, Debug, Clone, Default)]
+#[serde(rename_all = "PascalCase")]
+pub struct WorkSpaceEditDTO {
+	/// A list of text edits to apply, grouped by resource URI.
+	/// The structure is `[ [uri_dto, [text_edit_dto, ...]], ... ]`
+	pub Edits:Vec<(Value, Vec<Value>)>,
+	// Future fields for file operations would go here:
+	// pub file_operations: Vec<FileOperationDTO>,
+}

Source/DTO/mod.rs

@@ -0,0 +1,23 @@
+//! # Global DTO Module
+//!
+//! A top-level module that re-exports all Data Transfer Objects (DTOs) from the
+//! various service modules for convenient access across the application.
+//! It also contains DTOs that are shared across multiple services.
+
+#![allow(non_snake_case, non_camel_case_types)]
+
+pub mod WorkSpaceEditDTO;
+
+// // Re-export shared DTOs
+// pub use self::WorkSpaceEditDTO::WorkSpaceEditDTO;
+
+// // Re-export service-specific DTOs
+// pub use crate::Configuration::DTO::*;
+// pub use crate::FileSystem::DTO::*;
+// pub use crate::IPC::DTO::*;
+// pub use crate::LanguageFeature::DTO::*;
+// pub use crate::SourceControlManagement::DTO::*;
+// pub use crate::StatusBar::DTO::*;
+// pub use crate::TreeView::DTO::*;
+// pub use crate::UserInterface::DTO::*;
+// pub use crate::WebView::DTO::*;

Source/Diagnostic/ClearDiagnostics.rs

@@ -28,12 +28,11 @@ use crate::{
 pub fn ClearDiagnostics<TRunTime>(Owner:String) -> ActionEffect<Arc<TRunTime>, CommonError, ()>
 where
 	TRunTime: ApplicationRunTime + Send + Sync + 'static,
-	TRunTime::EnvironmentType: Requires<Arc<dyn DiagnosticManager>>, {
+	TRunTime: Requires<Arc<dyn DiagnosticManager>>, {
 	ActionEffect::New(Arc::new(move |RunTime:Arc<TRunTime>| {
 		let OwnerClone = Owner.clone();
 		Box::pin(async move {
-			let Environment = RunTime.GetEnvironment();
-			let Manager:Arc<dyn DiagnosticManager> = Environment.Require();
+			let Manager:Arc<dyn DiagnosticManager> = RunTime.Require();
 			Manager.ClearDiagnostics(OwnerClone).await
 		})
 	}))