Skip to content

Commit 660a067

Browse files
fix(Mountain): Enhance logging for SCM provider registration emit failures
Signed-off-by: Nikola Hristov <Nikola@PlayForm.Cloud>
1 parent 9c10fbe commit 660a067

1 file changed

Lines changed: 15 additions & 3 deletions

File tree

Source/Vine/Server/Notification/RegisterScmProvider.rs

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,13 @@ pub async fn RegisterScmProvider(Service:&MountainVinegRPCService, Parameter:&Va
193193
// Legacy listener channel kept active alongside the typed event so
194194
// renderer code that hasn't migrated to the markers-backed view
195195
// (gitlens-side custom panels, hand-rolled tests) still sees the
196-
// register signal.
197-
let _ = Service.ApplicationHandle().emit(
196+
// register signal. Routed through `LogSkyEmit` so `sky-emit` /
197+
// `grpc` dev-log tags surface delivery success/failure - the
198+
// fire-and-forget path was previously invisible, making it
199+
// impossible to tell whether Sky's `Register("sky://scm/register")`
200+
// listener was hit when the SCM panel stayed empty.
201+
if let Err(Error) = crate::IPC::SkyEmit::LogSkyEmit(
202+
Service.ApplicationHandle(),
198203
"sky://scm/register",
199204
json!({
200205
"scmId": &ScmId,
@@ -203,7 +208,14 @@ pub async fn RegisterScmProvider(Service:&MountainVinegRPCService, Parameter:&Va
203208
"extensionId": &ExtensionId,
204209
"handle": Handle,
205210
}),
206-
);
211+
) {
212+
dev_log!(
213+
"grpc",
214+
"warn: [Scm] sky://scm/register emit failed for {}: {}",
215+
ScmId,
216+
Error
217+
);
218+
}
207219

208220
dev_log!(
209221
"grpc",

0 commit comments

Comments
 (0)