style(Mountain): fix doc comments, reformat code, and reorganize imports

NikolaRHristov · NikolaRHristov · commit 7af8314773a2 · 2026-04-05T15:20:35.000+03:00
This commit applies multiple improvements across Mountain's codebase:

1. **Doc Comment Fixes:** Replace bracket-style references with backtick code spans for proper rustdoc rendering across Command, Environment, IPC, and Workspace modules. Fix Windows URL angle brackets in Scheme documentation.

2. **Code Formatting:** Apply rustfmt to multiple files for consistent style - DnsCommands, Scheme, ServiceRegistry, Entry, LanguageFeatureProvider, Library, and CocoonService.

3. **Import Reorganization (CocoonService):** Restructure protobuf imports in `Source/RPC/CocoonService.rs` to group by category (Service traits, Language, Window, FS, Output, Task, Auth, Debug, Extension types) with clear section comments, improving readability and maintainability.

4. **Cargo Feature:** Enable `trace` feature on opentelemetry dependency for enhanced observability.

5. **Submodule Update:** Update Documentation/Rust to d6fefa9.

No functional changes - purely cosmetic and documentation improvements.
diff --git a/Cargo.toml b/Cargo.toml
@@ -83,7 +83,7 @@ ring = { workspace = true }
 bincode = { workspace = true }
 brotli = { workspace = true }
 hex = { workspace = true }
-opentelemetry = { workspace = true }
+opentelemetry = { workspace = true, features = ["trace"] }
 
 [features]
 default = ["ExtensionHostCocoon", "MistNative", "AirIntegration"]
diff --git a/Documentation/Rust b/Documentation/Rust
@@ -1 +1 @@
-Subproject commit a6123afb0cf38b7b6e0cde5ebc5d1a93aec170c9
+Subproject commit d6fefa90d42bcebabfa904c227be8c3fcc2f8d44
diff --git a/Source/Air/mod.rs b/Source/Air/mod.rs
@@ -14,9 +14,8 @@
 //! - Integration point with the Air background service (daemon)
 //! - Used by multiple Mountain components:
 //! - `UpdateService` for self-updates
-//!   - [`SearchProvider`] for file search
-//!   - [`SecretProvider`] for secret
-//!     storage
+//!   - `SearchProvider` for file search
+//!   - `SecretProvider` for secret storage
 //! - Connection is optional; Mountain can function without Air (graceful
 //!   degradation)
 //! - Service discovery and health checking via gRPC
diff --git a/Source/Binary/Build/DnsCommands.rs b/Source/Binary/Build/DnsCommands.rs
@@ -782,9 +782,7 @@ mod tests {
 
 	#[test]
 	fn test_forward_allowlist_serialization() {
-		let allowlist = ForwardAllowList {
-			domains:vec!["update.editor.land.".to_string()],
-		};
+		let allowlist = ForwardAllowList { domains:vec!["update.editor.land.".to_string()] };
 
 		let json = serde_json::to_string(&allowlist).unwrap();
 		let deserialized:ForwardAllowList = serde_json::from_str(&json).unwrap();
diff --git a/Source/Binary/Build/Scheme.rs b/Source/Binary/Build/Scheme.rs
@@ -67,8 +67,8 @@ pub fn init_service_registry(registry:ServiceRegistry) {
 /// 3. After initialization, we only read from it
 /// 4. The RwLock guarantees thread-safe access
 fn get_service_registry() -> Option<ServiceRegistry> {
-let guard = SERVICE_REGISTRY.read().ok()?;
-guard.clone()
+	let guard = SERVICE_REGISTRY.read().ok()?;
+	guard.clone()
 }
 
 /// DNS port managed state structure
@@ -649,7 +649,7 @@ pub fn land_scheme_handler_async<R:tauri::Runtime>(
 ///
 /// Tauri uses different origins for custom URI schemes on different platforms:
 /// - macOS, Linux: land://localhost/
-/// - Windows: http://land.localhost/
+/// - Windows: <http://land.localhost/>
 ///
 /// Returns a comma-separated list of origins to support all platforms.
 fn get_cors_origins() -> &'static str {
diff --git a/Source/Binary/Build/ServiceRegistry.rs b/Source/Binary/Build/ServiceRegistry.rs
@@ -82,7 +82,7 @@ impl LocalService {
 /// provisioning.
 #[derive(Clone)]
 pub struct ServiceRegistry {
-	/// Inner storage using Arc<RwLock> for thread-safe concurrent access
+	/// Inner storage using `Arc<RwLock>` for thread-safe concurrent access
 	services:Arc<RwLock<HashMap<String, LocalService>>>,
 	/// Optional certificate manager for HTTPS support
 	cert_manager:Option<std::sync::Arc<std::sync::Mutex<super::CertificateManager::CertificateManager>>>,
diff --git a/Source/Binary/Main/Entry.rs b/Source/Binary/Main/Entry.rs
@@ -237,12 +237,12 @@ pub fn Fn() {
 					// that land:// protocol_resolution is available
 					info!("[Lifecycle] [Setup] Starting DNS server on preferred port 5380...");
 					let dns_port = mist::start(5380).unwrap_or_else(|e| {
-					    warn!("[Lifecycle] [Setup] Failed to start DNS server on port 5380: {}", e);
-					    // Fallback to random port if preferred port fails
-					    mist::start(0).unwrap_or_else(|e| {
-					        error!("[Lifecycle] [Setup] Completely failed to start DNS server: {}", e);
-					        0 // Return 0 as error indicator
-					    })
+						warn!("[Lifecycle] [Setup] Failed to start DNS server on port 5380: {}", e);
+						// Fallback to random port if preferred port fails
+						mist::start(0).unwrap_or_else(|e| {
+							error!("[Lifecycle] [Setup] Completely failed to start DNS server: {}", e);
+							0 // Return 0 as error indicator
+						})
 					});
 
 					if dns_port == 0 {
@@ -278,9 +278,9 @@ pub fn Fn() {
 				}
 			})
 			.register_asynchronous_uri_scheme_protocol("land", |_ctx, request, responder| {
-			    // Implemented: delegate to synchronous scheme handler
-			    let response = crate::Binary::Build::Scheme::land_scheme_handler(&request);
-			    responder.respond(response);
+				// Implemented: delegate to synchronous scheme handler
+				let response = crate::Binary::Build::Scheme::land_scheme_handler(&request);
+				responder.respond(response);
 			})
 			.plugin(tauri_plugin_dialog::init())
 			.plugin(tauri_plugin_fs::init())
diff --git a/Source/Command/LanguageFeature.rs b/Source/Command/LanguageFeature.rs
@@ -15,7 +15,7 @@
 //! ARCHITECTURAL ROLE:
 //! - Command layer that exposes language features via Tauri IPC (`#[command]`)
 //! - Delegates to Environment's
-//! [`LanguageFeatureProvider`]
+//! `LanguageFeatureProvider`
 //! via DI with `Require()` trait
 //! - Translates between frontend JSON parameters and Rust DTO types
 //! - Error strings returned directly to frontend for display
diff --git a/Source/Command/SourceControlManagement.rs b/Source/Command/SourceControlManagement.rs
@@ -15,8 +15,7 @@
 //! `SourceControlManagementProvider` implementations in the Environment
 //!   layer
 //! - Uses Tauri's `#[command]` attribute for IPC exposure
-//! - Reads from [`ApplicationState.SourceControlManagement*
-//!   `] fields to gather state
+//! - Reads from `ApplicationState.SourceControlManagement*` fields to gather state
 //! - TODO: Should forward commands to provider methods via DI (Require trait)
 //!
 //! COMMAND REFERENCE (Tauri IPC):
diff --git a/Source/Command/TreeView.rs b/Source/Command/TreeView.rs
@@ -11,7 +11,7 @@
 //! - Command module exposing TreeView functionality via Tauri IPC
 //!   (`#[command]`)
 //! - Delegates to Environment's
-//!   [`TreeViewProvider`] via DI with
+//!   `TreeViewProvider` via DI with
 //!   `Require()` trait from `MountainEnvironment`
 //! - Translates frontend requests to provider method calls with proper error
 //!   mapping
diff --git a/Source/Environment/CustomEditorProvider.rs b/Source/Environment/CustomEditorProvider.rs
@@ -13,9 +13,7 @@
 //! - Environment provider that enables extension-contributed custom editors
 //! - Uses [`IPCProvider`](CommonLibrary::IPC::IPCProvider) for RPC
 //!   communication with Cocoon
-//! - Integrates with
-//!   [`ApplicationState`] for
-//!   provider registration persistence
+//! - Integrates with `ApplicationState` for provider registration persistence
 //!
 //! ERROR HANDLING:
 //! - Uses [`CommonError`](CommonLibrary::Error::CommonError) for all operations
diff --git a/Source/Environment/IPCProvider.rs b/Source/Environment/IPCProvider.rs
@@ -9,7 +9,7 @@
 //! - Provides both request/response and notification patterns
 //!
 //! ARCHITECTURAL ROLE:
-//! - Thin wrapper layer over [`Vine::Client`]
+//! - Thin wrapper layer over `Vine::Client`
 //! - All IPC operations are async and use JSON-RPC 2.0 protocol
 //! - Sidecar routing via `SideCarIdentifier` to target specific extension hosts
 //! - Error translation from Vine errors to
@@ -53,8 +53,7 @@
 //! - [`IPCProvider`](CommonLibrary::IPC::IPCProvider) implementation:
 //! - `SendNotificationToSideCar` - fire-and-forget
 //! - `SendRequestToSideCar` - synchronous RPC
-//! - Delegate: [`Vine::Client`] handles all transport
-//!   concerns
+//! - Delegate: `Vine::Client` handles all transport concerns
 
 use CommonLibrary::{Error::CommonError::CommonError, IPC::IPCProvider::IPCProvider};
 use async_trait::async_trait;
diff --git a/Source/Environment/LanguageFeatureProvider/mod.rs b/Source/Environment/LanguageFeatureProvider/mod.rs
@@ -151,7 +151,9 @@ impl LanguageFeatureProviderRegistry for MountainEnvironment {
 	async fn ProvideRenameEdits(&self, _:Url, _:PositionDTO, _:String) -> Result<Option<Value>, CommonError> { todo!() }
 	async fn ProvideDocumentSymbols(&self, _:Url) -> Result<Option<Value>, CommonError> { todo!() }
 	async fn ProvideWorkspaceSymbols(&self, _:String) -> Result<Option<Value>, CommonError> { todo!() }
-	async fn ProvideSignatureHelp(&self, _:Url, _:PositionDTO, _:Value) -> Result<Option<Value>, CommonError> { todo!() }
+	async fn ProvideSignatureHelp(&self, _:Url, _:PositionDTO, _:Value) -> Result<Option<Value>, CommonError> {
+		todo!()
+	}
 	async fn ProvideFoldingRanges(&self, _:Url) -> Result<Option<Value>, CommonError> { todo!() }
 	async fn ProvideSelectionRanges(&self, _:Url, _:Vec<PositionDTO>) -> Result<Option<Value>, CommonError> { todo!() }
 	async fn ProvideSemanticTokensFull(&self, _:Url) -> Result<Option<Value>, CommonError> { todo!() }
@@ -161,5 +163,13 @@ impl LanguageFeatureProviderRegistry for MountainEnvironment {
 	async fn ProvideCallHierarchyIncomingCalls(&self, _:Value) -> Result<Option<Value>, CommonError> { todo!() }
 	async fn ProvideCallHierarchyOutgoingCalls(&self, _:Value) -> Result<Option<Value>, CommonError> { todo!() }
 	async fn ProvideLinkedEditingRanges(&self, _:Url, _:PositionDTO) -> Result<Option<Value>, CommonError> { todo!() }
-	async fn ProvideOnTypeFormattingEdits(&self, _:Url, _:PositionDTO, _:String, _:Value) -> Result<Option<Vec<TextEditDTO>>, CommonError> { todo!() }
+	async fn ProvideOnTypeFormattingEdits(
+		&self,
+		_:Url,
+		_:PositionDTO,
+		_:String,
+		_:Value,
+	) -> Result<Option<Vec<TextEditDTO>>, CommonError> {
+		todo!()
+	}
 }
diff --git a/Source/Environment/OutputProvider/mod.rs b/Source/Environment/OutputProvider/mod.rs
@@ -3,7 +3,7 @@
 //! Implements the
 //! [`OutputChannelManager`](CommonLibrary::Output::OutputChannelManager) trait
 //! for
-//! [`MountainEnvironment`].
+//! `MountainEnvironment`.
 //!
 //! This provider manages multiple output channels (e.g., 'Extension Host',
 //! 'JavaScript', 'Git'), handling channel lifecycle, content management, and UI
diff --git a/Source/Environment/SynchronizationProvider.rs b/Source/Environment/SynchronizationProvider.rs
@@ -16,8 +16,7 @@
 //! - Uses authentication from `AuthenticationProvider` (to be implemented)
 //! - Syncs multiple data types: settings, keybindings, workspaces, extensions,
 //!   snippets
-//! - Store sync metadata in
-//!   [`ApplicationState`]
+//! - Store sync metadata in `ApplicationState`
 //!
 //! SYNC ARCHITECTURE:
 //! **PushUserData**:
diff --git a/Source/Environment/TestProvider.rs b/Source/Environment/TestProvider.rs
@@ -16,8 +16,7 @@
 //!   extensions
 //! - Integrates with [`IPCProvider`](CommonLibrary::IPC::IPCProvider) for RPC
 //!   to test runners
-//! - Stores controller state in
-//!   [`ApplicationState`]
+//! - Stores controller state in `ApplicationState`
 //!
 //! TEST EXECUTION FLOW:
 //! 1. Extension registers test controller via `RegisterTestController`
diff --git a/Source/Environment/TreeViewProvider/mod.rs b/Source/Environment/TreeViewProvider/mod.rs
@@ -2,7 +2,7 @@
 //!
 //! Implements the
 //! [`TreeViewProvider`](CommonLibrary::TreeView::TreeViewProvider) trait for
-//! [`MountainEnvironment`].
+//! `MountainEnvironment`.
 //!
 //! This provider manages the lifecycle of custom tree views and orchestrates
 //! data flow between the extension host (Cocoon) and the UI (Sky). It handles
diff --git a/Source/Environment/Utility/mod.rs b/Source/Environment/Utility/mod.rs
@@ -2,7 +2,7 @@
 //!
 //! Shared utility functions used across all Environment provider
 //! implementations in
-//! [`MountainEnvironment`].
+//! `MountainEnvironment`.
 //! These handle cross-cutting concerns: error mapping, security validation,
 //! language detection, and URI conversions.
 //!
diff --git a/Source/Environment/WorkspaceProvider.rs b/Source/Environment/WorkspaceProvider.rs
@@ -11,13 +11,10 @@
 //!
 //! ARCHITECTURAL ROLE:
 //! - Core provider in the Environment system, exposing workspace-level
-//!   functionality to frontend via gRPC through the
-//!   [`AirService`]
+//!   functionality to frontend via gRPC through the `AirService`
 //! - Workspace provider is one of the foundational services alongside Document,
 //!   Configuration, and Diagnostic providers
-//! - Integrates with
-//!   [`ApplicationState`] for
-//!   persistent workspace folder storage
+//! - Integrates with `ApplicationState` for persistent workspace folder storage
 //!
 //! ERROR HANDLING:
 //! - Uses [`CommonError`](CommonLibrary::Error::CommonError) for all operations
diff --git a/Source/IPC/WindAdvancedSync.rs b/Source/IPC/WindAdvancedSync.rs
@@ -28,7 +28,7 @@
 //! **Three Sync Layers:**
 //!
 //! **1. Document Synchronization (Every 5 seconds):**
-//! ```
+//! ```text
 //! Wind Editor (User Edits)
 //!     |
 //!     | Detect changes
@@ -45,7 +45,7 @@
 //! ```
 //!
 //! **2. UI State Synchronization (Every 1 second):**
-//! ```
+//! ```text
 //! Wind UI Window
 //!     |
 //!     | Capture state (cursor, selection, zoom)
@@ -58,7 +58,7 @@
 //! ```
 //!
 //! **3. Real-time Updates (Every 100ms):**
-//! ```
+//! ```text
 //! Subscribed Listeners
 //!     ^
 //!     | Broadcast updates
diff --git a/Source/IPC/WindServiceAdapters.rs b/Source/IPC/WindServiceAdapters.rs
@@ -23,7 +23,7 @@
 //! This module implements the Adapter design pattern to bridge the interface
 //! gap:
 //!
-//! ```
+//! ```text
 //! Wind's IFileService (TypeScript interface)
 //!        |
 //!        |  Expected interface
diff --git a/Source/IPC/WindServiceHandlers.rs b/Source/IPC/WindServiceHandlers.rs
@@ -65,7 +65,7 @@
 //!
 //! **Communication Pattern:**
 //!
-//! ```
+//! ```text
 //! Wind (TypeScript)
 //!   |
 //!   | app.handle.invoke('command', args)
diff --git a/Source/Library.rs b/Source/Library.rs
@@ -43,7 +43,8 @@
 //! - [`RPC`]: Remote procedure call service implementations
 //!
 //! ### Services
-//! - [`ProcessManagement`]: Sidecar process lifecycle (launch, monitor, restart)
+//! - [`ProcessManagement`]: Sidecar process lifecycle (launch, monitor,
+//!   restart)
 //! - [`FileSystem`]: Native TreeView provider for the File Explorer
 //! - [`ExtensionManagement`]: Extension discovery, scanning, and activation
 //!
@@ -107,7 +108,4 @@ pub mod Binary;
 
 /// Main entry point for desktop/mobile builds
 #[cfg_attr(mobile, tauri::mobile_entry_point)]
-pub fn main() {
-	Binary::Main::Main();
-}
-
+pub fn main() { Binary::Main::Main(); }
diff --git a/Source/RPC/CocoonService.rs b/Source/RPC/CocoonService.rs
diff --git a/Source/RPC/mod.rs b/Source/RPC/mod.rs
diff --git a/Source/Workspace/WorkspaceFileService.rs b/Source/Workspace/WorkspaceFileService.rs
