Commit c661d66
committed
fix(Mountain): Remove duplicate DevTools window in debug builds
WindowBuild.rs was calling `MainWindow.open_devtools()` independently
from AppLifecycle.rs, causing two DevTools windows to open on every
debug launch. Remove the redundant call and document that DevTools
auto-open lives in AppLifecycle (line 174), gated on debug_assertions
with a matching log line.
docs(Mountain): Clarify diagnostic coordinates are 1-based
Update DiagnosticProvider.rs docstring to specify that
StartLineNumber/StartColumn and EndLineNumber/EndColumn use 1-based
indexing, matching workbench IMarkerData. Add note explaining that
Cocoon's LanguagesNamespace.ts NormaliseDiagnostic adds the +1 offset
from vscode.Position 0-based convention before sending to Mountain.1 parent c2d0bec commit c661d66
2 files changed
Lines changed: 11 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
78 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
79 | 82 | | |
80 | 83 | | |
81 | 84 | | |
| |||
0 commit comments