Commit d276d12
committed
refactor(Mountain): Enhance debug logging and refine effect system
- **Debug Logging**: Added colored trace-level logging for debug builds in `Binary.rs` to improve development visibility, formatting Mountain logs with application context and level-specific colors
- **Tauri Configuration**: Enabled `any_thread()` mode for Windows/Linux in Tauri builder to resolve potential runtime constraints
- **Terminal Provider**: Removed unnecessary `mut` qualifiers from PTY variables in `TerminalProvider.rs` as they aren't mutated after creation
- **Effect System**: Updated `box_effect` in `EffectCreation.rs` to:
- Require `MountainEnvironment` instead of `MountainRunTime` for context resolution
- Add `From<CommonError>` bound to error types for improved interoperability
- Remove obsolete comment about effect mappings
These changes strengthen Mountain's core infrastructure:
1. Debug logging aids development while maintaining release-mode minimalism
2. Thread configuration prevents potential Tauri runtime issues
3. Terminal implementation adheres to Rust's ownership best practices
4. Effect system now properly leverages the `Environment` trait from `Common` crate, ensuring correct dependency resolution through `Requires` trait
5. Error handling alignment supports the standardized gRPC error system refined in recent commits1 parent 3b69c26 commit d276d12
3 files changed
Lines changed: 41 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
34 | 59 | | |
35 | 60 | | |
36 | 61 | | |
| |||
51 | 76 | | |
52 | 77 | | |
53 | 78 | | |
| 79 | + | |
54 | 80 | | |
55 | 81 | | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
56 | 87 | | |
57 | 88 | | |
58 | 89 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
19 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
20 | 24 | | |
21 | 25 | | |
22 | 26 | | |
| |||
43 | 47 | | |
44 | 48 | | |
45 | 49 | | |
46 | | - | |
47 | | - | |
| 50 | + | |
| 51 | + | |
48 | 52 | | |
49 | 53 | | |
50 | 54 | | |
| |||
126 | 130 | | |
127 | 131 | | |
128 | 132 | | |
129 | | - | |
130 | 133 | | |
131 | 134 | | |
132 | 135 | | |
| |||
0 commit comments