fix: Add sourceCheckId field to prevent issues looking up DMN for Custom Checks. (#364)

Author: Justin-MacIntosh

builder-api/src/main/java/org/acme/controller/CustomBenefitResource.java

@@ -303,6 +303,7 @@ public Response addCheckToBenefit(
             String newCheckConfigId = UUID.randomUUID().toString();
             CheckConfig checkConfig = new CheckConfig(
                 newCheckConfigId,
+                check.getId(),
                 check.getName(),
                 check.getVersion(),
                 check.getModule(),

builder-api/src/main/java/org/acme/controller/DecisionResource.java

@@ -135,7 +135,6 @@ private Map<String, Object> evaluateBenefit(Benefit benefit, Map<String, Object>
 
             int checkNum = 0;
             for (CheckConfig checkConfig : benefit.getChecks()) {
-                String dmnFilepath = storageService.getCheckDmnModelPath(checkConfig.getCheckId());
                 EvaluationResult evaluationResult;
                 if (isLibraryCheck(checkConfig)){
                     evaluationResult = libraryApi.evaluateCheck(checkConfig, formData);
@@ -144,6 +143,8 @@ private Map<String, Object> evaluateBenefit(Benefit benefit, Map<String, Object>
                     if (customFormValues == null) {
                         customFormValues = new HashMap<String, Object>();
                     }
+                    String sourceCheckId = checkConfig.getSourceCheckId() != null ? checkConfig.getSourceCheckId() : checkConfig.getCheckId();
+                    String dmnFilepath = storageService.getCheckDmnModelPath(sourceCheckId);
                     evaluationResult = dmnService.evaluateDmn(
                         dmnFilepath, checkConfig.getCheckName(), customFormValues, checkConfig.getParameters()
                     );

builder-api/src/main/java/org/acme/model/domain/CheckConfig.java

@@ -9,6 +9,8 @@
 @JsonIgnoreProperties(ignoreUnknown = true)
 public class CheckConfig {
     private String checkId;
+    // original checkId of the check this was cloned from
+    private String sourceCheckId;
     private String checkName;
     private String checkVersion;
     private String checkModule;
@@ -23,6 +25,7 @@ public CheckConfig() {
 
     public CheckConfig(
         String checkId,
+        String sourceCheckId,
         String checkName,
         String checkVersion,
         String checkModule,
@@ -32,6 +35,7 @@ public CheckConfig(
         Map<String, Object> parameters
     ) {
         this.checkId = checkId;
+        this.sourceCheckId = sourceCheckId;
         this.checkName = checkName;
         this.checkVersion = checkVersion;
         this.checkModule = checkModule;
@@ -104,4 +108,12 @@ public String getCheckModule() {
     public void setCheckModule(String checkModule) {
         this.checkModule = checkModule;
     }
+
+    public String getSourceCheckId() {
+        return sourceCheckId;
+    }
+
+    public void setSourceCheckId(String sourceCheckId) {
+        this.sourceCheckId = sourceCheckId;
+    }
 }