Updated addCustomBenefit endpoint to function properly for a Screener with no Benefits

Justin-MacIntosh · Justin-MacIntosh · commit 1f9b73644a9e · 2025-10-17T13:37:46.000-04:00
diff --git a/builder-api/src/main/java/org/acme/controller/ScreenerResource.java b/builder-api/src/main/java/org/acme/controller/ScreenerResource.java
@@ -451,6 +451,9 @@ public Response addCustomBenefit(@Context SecurityIdentity identity,
             }
 
             List<BenefitDetail> benefits = screenerOpt.get().getBenefits();
+            if (benefits == null) {
+                benefits = Collections.emptyList();
+            }
             Boolean benefitIdExists = !benefits.stream().filter(benefit -> benefit.getId().equals(benefitDetail.getId())).toList().isEmpty();
 
             if (benefitIdExists){

Original file line number	Diff line number	Diff line change
`@@ -451,6 +451,9 @@ public Response addCustomBenefit(@Context SecurityIdentity identity,`
`451`	`451`	`}`
`452`	`452`
`453`	`453`	`List<BenefitDetail> benefits = screenerOpt.get().getBenefits();`
	`454`	`+ if (benefits == null) {`
	`455`	`+ benefits = Collections.emptyList();`
	`456`	`+ }`
`454`	`457`	`Boolean benefitIdExists = !benefits.stream().filter(benefit -> benefit.getId().equals(benefitDetail.getId())).toList().isEmpty();`
`455`	`458`
`456`	`459`	`if (benefitIdExists){`