Changes from Claude review

Author: joshwanf

builder-api/src/main/java/org/acme/api/error/JsonServerExceptionMappers.java

@@ -29,17 +29,15 @@ public Response map(JsonParseException e) {
     Log.warn(e);
     // malformed JSON like { "schema": }
     return Response.status(Response.Status.BAD_REQUEST)
-        .type(MediaType.APPLICATION_JSON)
-        .entity(ApiError.of("JsonParseException: Malformed JSON.")).build();
+        .type(MediaType.APPLICATION_JSON).entity(ApiError.of("Malformed JSON."))
+        .build();
   }
 
   @ServerExceptionMapper
   public Response map(WebApplicationException e) {
-    Log.info("Some malformed JSON");
     Log.warn(e);
     return Response.status(Response.Status.BAD_REQUEST)
-        .type(MediaType.APPLICATION_JSON)
-        .entity(ApiError.of("WebApplicationException: Malformed JSON."))
+        .type(MediaType.APPLICATION_JSON).entity(ApiError.of("Malformed JSON."))
         .build();
   }
 

builder-api/src/main/java/org/acme/controller/AccountResource.java

@@ -2,7 +2,6 @@
 
 import io.quarkus.security.identity.SecurityIdentity;
 import jakarta.inject.Inject;
-import jakarta.validation.Validator;
 import jakarta.ws.rs.*;
 import jakarta.ws.rs.core.*;
 
@@ -21,14 +20,12 @@
 @Path("/api")
 public class AccountResource {
 
-    @Inject
-    Validator validator;
-
     @Inject
     AccountHooks accountHooks;
 
     @POST
     @Consumes(MediaType.APPLICATION_JSON)
+    @Produces(MediaType.APPLICATION_JSON)
     @Path("/account-hooks")
     public Response accountHooks(@Context SecurityIdentity identity,
             AccountHookRequest request) {
@@ -51,13 +48,16 @@ public Response accountHooks(@Context SecurityIdentity identity,
 
         // Run each action's function and determine whether successful
         Map<String, Boolean> hookResults = hooks.stream()
-                .collect(Collectors.toMap(s -> s.toString(), s -> {
+                .collect(Collectors.toMap(s -> s.getLabel(), s -> {
                     Predicate<String> fn = hooksMap.get(s);
                     return fn.test(userId);
                 }));
 
-        AccountHookResponse responseBody = new AccountHookResponse(true,
-                hookResults);
+        Boolean allHooksSuccess = hookResults.values().stream()
+                .allMatch(Boolean::booleanValue);
+
+        AccountHookResponse responseBody = new AccountHookResponse(
+                allHooksSuccess, hookResults);
 
         return Response.ok(responseBody).build();
     }

builder-api/src/main/java/org/acme/enums/AccountHookAction.java

@@ -27,4 +27,4 @@ public static AccountHookAction fromValue(String value) {
         }
         return UNABLE_TO_DETERMINE;
     }
-}
+}

builder-api/src/main/java/org/acme/model/dto/Auth/AccountHookRequest.java

@@ -5,4 +5,4 @@
 import org.acme.enums.AccountHookAction;
 
 public record AccountHookRequest(Set<AccountHookAction> hooks) {
-}
+}

builder-api/src/main/java/org/acme/service/ExampleScreenerImportService.java

@@ -207,6 +207,7 @@ private String upsertPublishedCustomCheck(
             try {
                 eligibilityCheckRepository.saveNewPublishedCustomCheck(importedCheck);
             } catch (Exception e) {
+                Log.info(e);
                 eligibilityCheckRepository.updatePublishedCustomCheck(importedCheck);
             }
         }

builder-frontend/src/api/account.ts

@@ -4,7 +4,7 @@ import { authPost } from "@/api/auth";
 
 const apiUrl = env.apiUrl;
 
-export const getAccountHooks = async () => {
+export const runAccountHooks = async () => {
   const accountHookUrl = new URL(`${apiUrl}/account-hooks`);
 
   const hooksToCall = ["add example screener"];

builder-frontend/src/context/AuthContext.tsx

@@ -12,10 +12,11 @@ import {
   createUserWithEmailAndPassword,
   signInWithPopup,
   GoogleAuthProvider,
+  getAdditionalUserInfo,
 } from "firebase/auth";
 
 import { auth } from "../firebase/firebase";
-import { getAccountHooks } from "@/api/account";
+import { runAccountHooks } from "@/api/account";
 
 const AuthContext = createContext();
 const googleProvider = new GoogleAuthProvider();
@@ -46,7 +47,7 @@ export function AuthProvider(props) {
     setIsProvisioningAccount(true);
     return createUserWithEmailAndPassword(auth, email, password).then(
       (userCredential) => {
-        getAccountHooks()
+        return runAccountHooks()
           .then(
             () => {
               console.log("Successfully hooked the account.");
@@ -65,10 +66,11 @@ export function AuthProvider(props) {
   const loginWithGoogle = async () => {
     try {
       return signInWithPopup(auth, googleProvider).then((userCredential) => {
-        const { operationType } = userCredential;
-        if (operationType === "link" || operationType === "reauthenticate") {
+        const isSignUp =
+          getAdditionalUserInfo(userCredential)?.isNewUser || false;
+        if (isSignUp) {
           setIsProvisioningAccount(true);
-          getAccountHooks()
+          runAccountHooks()
             .then(
               () => {
                 console.log("Successfully hooked the account.");