Skip to content

Commit dd5f780

Browse files
fix: Code Review Changes
- Removed disabling of Application Link - Changed font size of h1 elements back to text-xl via TailwindCSS.
1 parent ebe2753 commit dd5f780

File tree

5 files changed

+5
-10
lines changed

5 files changed

+5
-10
lines changed

screener-frontend/src/EligibilityResults.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ export default function EligibilityResults(
2222
}
2323

2424
function BenefitResult({ benefit }: { benefit: ResultDetail }) {
25-
const isApplicationLinkEnabled: boolean = benefit.result;
26-
const applicationLinkCls: string = (
27-
isApplicationLinkEnabled ? "" : "pointer-events-none opacity-50"
28-
);
29-
3025
return (
3126
<div class="border-gray-500 border p-5 my-4 rounded-lg shadow-md">
3227
<Switch>
@@ -79,7 +74,7 @@ function BenefitResult({ benefit }: { benefit: ResultDetail }) {
7974
)}
8075
{benefit.appLink && (
8176
<div class="[&:has(+div)]:mb-4">
82-
<a href={benefit.appLink} target="_blank" class={applicationLinkCls}>
77+
<a href={benefit.appLink} target="_blank">
8378
<p
8479
class="
8580
px-5 py-2 rounded-lg select-none

screener-frontend/src/Error.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ export default function ErrorPage({ error }: { error: any }) {
22
console.log(error);
33
return (
44
<div class="py-24 flex-col justify-center h-screen items-center">
5-
<h1 class="text-center text-[2em]">
5+
<h1 class="text-center text-xl">
66
Sorry, there was an error loading the requested screener.
77
</h1>
88
</div>

screener-frontend/src/Home.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export default function Home() {
22
return (
33
<div class="py-24 flex-col justify-center h-screen items-center">
4-
<h1 class="text-center text-[2em]">Benefit Decision Toolkit</h1>
4+
<h1 class="text-center text-xl">Benefit Decision Toolkit</h1>
55
</div>
66
);
77
}

screener-frontend/src/Loading.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export default function Loading() {
22
return (
33
<div class="py-24 flex-col justify-center h-screen items-center">
4-
<h1 class="text-center text-[2em]">Loading Screener</h1>
4+
<h1 class="text-center text-xl">Loading Screener</h1>
55
<div class="mt-8 flex items-center justify-center h-20">
66
<div class="w-10 h-10 border-4 border-blue-500 border-t-transparent rounded-full animate-spin"></div>
77
</div>

screener-frontend/src/NotFound.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
export default function NotFound() {
22
return (
33
<div class="py-24 flex-col justify-center h-screen items-center">
4-
<h1 class="text-center text-[2em]">404 Screener Not Found</h1>
4+
<h1 class="text-center text-xl">404 Screener Not Found</h1>
55
</div>
66
);
77
}

0 commit comments

Comments
 (0)