Skip to content

feat: Updated Form-JS key input to be a dropdown of path options#278

Merged
Justin-MacIntosh merged 1 commit intomainfrom
form-js-dropdown
Feb 15, 2026
Merged

feat: Updated Form-JS key input to be a dropdown of path options#278
Justin-MacIntosh merged 1 commit intomainfrom
form-js-dropdown

Conversation

@Justin-MacIntosh
Copy link
Copy Markdown
Collaborator

@Justin-MacIntosh Justin-MacIntosh commented Feb 15, 2026

  • feat: Added transformation layer to transform the JSONSchema of Webapp EligibilityChecks to a JSONSchema for Screener Form building.
    • This new Form-JS JSONSchema is used to determine which flat paths are available to be selected as keys on the Form Editor.
  • feat: Updated the Form Editor to allow form paths to be selected from a Dropdown of potential options.
  • feat: Removed the ability to select keys for Groups within the Form Editor.
  • feat: Added transformation layer to transform the data created by filling out Screener Forms into data accepted by the Library API.
  • fix: Updated Frontend auth to redirect you to login properly when the user is not found.
  • fix: Fixed issue where the Library Check "Person Max Age" was not setting its datatype properly, resulting in strange Web App behavior.
  • fix: Updated the ready_log_line of builder-api and library-api within process-compose.yml to be "Listening on: http://". This is to prevent issues when the host is logged unpredictably as either 0.0.0.0 or localhost.

#271

@@ -0,0 +1,295 @@
/**
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very important comment. None of this code is written by BDT.

* @return A new Map with the "people" object converted to an array, or the original data if no transformation needed
*/
@SuppressWarnings("unchecked")
public static Map<String, Object> transformFormData(Map<String, Object> formData) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be over-engineering to do this now. But if we add additional transformations, I think it would be great if this function iterated through a list of transformations. Or somehow setup up so that we could easily add new transformations while changing as little code as possible.

Copy link
Copy Markdown
Collaborator

@Michael-Dratch Michael-Dratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment about how we might want to try to make the schema transformation more dynamic in the future but I think all of this is great. And the comments are very clear. This is is great work!!

@Justin-MacIntosh Justin-MacIntosh merged commit 2c6e074 into main Feb 15, 2026
1 check passed
@prestoncabe prestoncabe deleted the form-js-dropdown branch March 1, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants