Add Library Checks for Philly Homestead Exemption benefit#295
Merged
prestoncabe merged 3 commits intomainfrom Feb 26, 2026
Merged
Conversation
Justin-MacIntosh
approved these changes
Feb 26, 2026
Collaborator
Justin-MacIntosh
left a comment
Justin-MacIntosh
left a comment
There was a problem hiding this comment.
I pulled this down locally and ran some tests!! It looks fantastic.
prestoncabe
force-pushed
the
290-complete-library-checks-for-phl-homestead-exemption
branch
from
c3691ea to
5afe889
Compare
Adds four reusable library checks for screening Homestead Exemption eligibility: - OwnerOccupant, LivesInPhiladelphiaPa, TenYearTaxAbatement, NoTenYearTaxAbatement Each follows the parameterless pattern with Pass/Fail/Null Bruno tests. Also wires all the checks into PhlHomesteadExemption.
Adds .claude/commands/new-dmn-check.md: a step-by-step guide for generating new DMN eligibility checks following library conventions, including inverse check pattern, null tests, and running the Bruno test suite to verify.
Checks with no caller-supplied parameters now omit the tParameters type, parameters inputData element, and parameters key from the OpenAPI spec. Also makes checkResult default to null (not false) when situation fields are absent.
prestoncabe
force-pushed
the
290-complete-library-checks-for-phl-homestead-exemption
branch
from
5afe889 to
7c4d8c3
Compare
prestoncabe
deleted the
290-complete-library-checks-for-phl-homestead-exemption
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Post-merge to do: