EligibilityCheck API Validation#298
Merged
Justin-MacIntosh merged 2 commits intomainfrom Feb 28, 2026
Merged
Conversation
Collaborator
Justin-MacIntosh
commented
Feb 26, 2026
Justin-MacIntosh
commented
- feat: Added API validation to EligibilityCheck API endpoints
- feat: Added error logging to JSON Validation Errors
feat: Added error logging to JSON Validation Errors
prestoncabe
approved these changes
Feb 26, 2026
Collaborator
prestoncabe
left a comment
prestoncabe
left a comment
There was a problem hiding this comment.
Looks good! see my two small comments
|
|
||
| @ServerExceptionMapper | ||
| public Response map(MismatchedInputException e) { | ||
| Log.error(e); |
Collaborator
There was a problem hiding this comment.
should these really be errors? (ValidationExceptionManager logs as a warning, for example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.