feat: move Eligibility Checks into overflow menu in home nav#354
feat: move Eligibility Checks into overflow menu in home nav#354morissette wants to merge 1 commit into
Conversation
Eligibility Checks was presented as a peer tab alongside Screeners, giving it equal visual weight. Per CodeForPhilly#289, move it into a '...' overflow menu on the right side of the navbar so Screeners is clearly the primary navigation item. - BdtNavbar: add optional menuDef prop that renders a three-dot menu button with a dropdown on the right side of the navbar - HomeScreen: move 'Eligibility checks' tab into menuDef items Closes CodeForPhilly#289
2d9ba27 to
246b174
Compare
There was a problem hiding this comment.
Thanks @morissette - The menu appears to look and function well, but now I think there is an unintended consequence where we lose a visual indicator of which area of the app we're in.
Before this acted as a tab, with an underline:
curious if @Justin-MacIntosh or @Michael-Dratch or @earth-walker have any thoughts on this - My naive thought is that when you navigate to Eligibility Checks, the nav bar would clear except for a bold "Eligibility Checks" title and a "Back to Home" link would be added to the top right. (This would be consistent to the behavior when navigating into a particular screener):
|
Thinking about these requested changes, should find time to work on them today. |
|
Looks like this got addressed in #416 |
Closes #289
Summary
Eligibility Checks was presented as a peer tab alongside Screeners in the home screen navbar, giving it equal visual prominence. This moves it into a
...overflow menu on the right side of the navbar so Screeners is clearly the primary navigation item.Before: Two equal tabs —
Screeners|Eligibility checksAfter: One primary tab —
Screeners— with a...menu button on the right that revealsEligibility Checksin a dropdown.Changes
BdtNavbar.tsxmenuDefprop ({ items: { key, label, onClick }[] })...button (using the existingMenuIcon) right-aligned in the navbartabDefs.map()to<For>(Solid.js idiomatic)HomeScreen.tsxchecksfromtabDefsmenuDefwithEligibility Checksas the single menu itemTest plan
...button appears on the right side of the navbar...opens a dropdown with "Eligibility Checks"🤖 Generated with Claude Code