Skip to content

Use today's date as default for Library Checks with an asOfDate param…#457

Merged
joshwanf merged 1 commit into
mainfrom
feature/lib-check-default-asofdate
Jul 2, 2026
Merged

Use today's date as default for Library Checks with an asOfDate param…#457
joshwanf merged 1 commit into
mainfrom
feature/lib-check-default-asofdate

Conversation

@joshwanf

Copy link
Copy Markdown
Collaborator

…eter

Closes #394

  • Library Checks configured with blank asOfDate do not pass, since the Check is evaluating with an empty date.
  • Today's date is injected in builder-api before calling library-api if the date is blank.
  • Text is supplied in the UI that tells the user a default date will be supplied if left blank on the following screens:
    • Check Config screen when configuring parameters
    • Preview screen when displaying Results
image image

@joshwanf joshwanf requested a review from prestoncabe as a code owner June 24, 2026 21:33
@prestoncabe

Copy link
Copy Markdown
Collaborator

@joshwanf I plan to look at this tomorrow!

@prestoncabe prestoncabe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gave it a quick look (at the code). I'm not sure my limited assessment means much, but LGTM :)

@joshwanf joshwanf merged commit fd1b761 into main Jul 2, 2026
2 of 3 checks passed
@joshwanf joshwanf deleted the feature/lib-check-default-asofdate branch July 2, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 'today' option for asOfDate for age

2 participants