Skip to content

Commit d59f4c4

Browse files
committed
Renamed AbstractDataSharingController -> DataSharingController, created better Instructions.
1 parent 7161510 commit d59f4c4

11 files changed

Lines changed: 72 additions & 26 deletions

src/controller/Controller.java

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -162,12 +162,12 @@ public final class Controller implements Initializable {
162162
* @param title the title of the new window.
163163
* @param data the parameters passed to the Controller.
164164
* @param <C> a Controller that can pass data to and recieve data from this method (extending
165-
* AbstractDataSharingController).
165+
* DataSharingController).
166166
* @param <T> the type of data passed to and from the Controller.
167167
* @return the data after it has been modified by the Controller.
168168
*/
169169
@FXML @SuppressWarnings("unchecked")
170-
private <C extends AbstractDataSharingController<T>, T> ArrayList<T> showWindow(String fxml, String title, ArrayList<T> data){
170+
private <C extends DataSharingController<T>, T> ArrayList<T> showWindow(String fxml, String title, ArrayList<T> data){
171171
try {
172172
FXMLLoader loader = new FXMLLoader(getClass().getResource(fxml));
173173
Parent parent = loader.load();
@@ -739,20 +739,7 @@ private File showLoadFileDialog(String title, ExtensionFilter extFilter){
739739
* Creates an instructional alert.
740740
*/
741741
private void showInstructionsAlert() {
742-
Alert instrAlert = new Alert(Alert.AlertType.INFORMATION);
743-
instrAlert.setTitle("Instructions on using Drawing Turtles");
744-
instrAlert.setHeaderText(null);
745-
instrAlert.setContentText(
746-
"How to use Drawing Turtles:\nClick once on the button corresponding to the graph element you want to" +
747-
" add to the canvas, then click somewhere on the canvas. Add a name (even in .ttl syntax!) an" +
748-
"d the item will be created in that position. \nIn regards to the Property button, you must c" +
749-
"lick on a valid (already existing) element in the graph as the subject, and then another as " +
750-
"the object. If you click on something that is not a Class or Literal, you will need toclick " +
751-
"the subject-object pair again.\nFeel free to add elements near the edge of the graph, it aut" +
752-
"omatically resizes! "
753-
);
754-
755-
instrAlert.showAndWait();
742+
showWindow("/view/instructions.fxml", "Instructions for Drawing Turtles", null);
756743
}
757744

758745
/**

src/controller/CorrelateDialogController.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
/**
2323
* The controller for view.correlateDialog.fxml.
2424
*/
25-
public class CorrelateDialogController extends AbstractDataSharingController<DataIntegrator> implements Initializable {
25+
public class CorrelateDialogController extends DataSharingController<DataIntegrator> implements Initializable {
2626
@FXML Button addManualCorrBtn, addHeaderBtn, commitBtn, cancelBtn;
2727
@FXML ListView<String> csvHeaderList;
2828
@FXML ListView<String> csvTtlCorrelationList;
@@ -114,7 +114,7 @@ public class CorrelateDialogController extends AbstractDataSharingController<Dat
114114
/**
115115
* Close the Window and mark the modified DataIntegrator for commital.
116116
*/
117-
@FXML void commitCorrelationBtn() {
117+
@FXML void commitCorrelationAction() {
118118
dataIntegrator.setCorrelations(correlations);
119119
dataIntegrator.setUncorrelated(new Pair<>(uncorrelatedCsvHeaders, uncorrelatedTtlClasses));
120120
Stage stage = (Stage) commitBtn.getScene().getWindow();
@@ -124,7 +124,7 @@ public class CorrelateDialogController extends AbstractDataSharingController<Dat
124124
/**
125125
* Close the Window.
126126
*/
127-
@FXML void cancelCorrelationBtn() {
127+
@FXML void cancelCorrelationAction() {
128128
Stage stage = (Stage) cancelBtn.getScene().getWindow();
129129
stage.close();
130130
}

src/controller/AbstractDataSharingController.java renamed to src/controller/DataSharingController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* An abstract Controller that faciliitates the passing of data to and from the Controller class.
77
* @param <T> the type of data passed between the two controllers.
88
*/
9-
abstract class AbstractDataSharingController<T> {
9+
abstract class DataSharingController<T> {
1010

1111
/**
1212
* The method that passes data from the Caller to the Callee.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
package controller;
2+
3+
import javafx.fxml.FXML;
4+
import javafx.scene.control.Button;
5+
import javafx.stage.Stage;
6+
7+
import java.util.ArrayList;
8+
9+
public class InstructionsController extends DataSharingController<String> {
10+
@FXML Button closeBtn;
11+
12+
13+
14+
@FXML void closeAction() { ((Stage) closeBtn.getScene().getWindow()).close(); }
15+
16+
@Override public void setData(ArrayList<String> data) {}
17+
@Override public ArrayList<String> getData() { return null; }
18+
}

src/controller/NewClassDialogController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
/**
1919
* The controller for view.newClassDialog.fxml.
2020
*/
21-
public class NewClassDialogController extends AbstractDataSharingController<String> implements Initializable {
21+
public class NewClassDialogController extends DataSharingController<String> implements Initializable {
2222
private final BooleanProperty isClasslike = new SimpleBooleanProperty(false);
2323
private final BooleanProperty isLiterallike = new SimpleBooleanProperty(false);
2424

src/controller/OntologyClassDialogController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
/**
1818
* The controller for ontologyClassDialog.fxml.
1919
*/
20-
public class OntologyClassDialogController extends AbstractDataSharingController<String> implements Initializable {
20+
public class OntologyClassDialogController extends DataSharingController<String> implements Initializable {
2121
@FXML Button cmtBtn, cancelBtn;
2222
@FXML TextField typeTfd, nameTfd, labelTfd;
2323
@FXML TextArea commentTxa;

src/controller/OptionsMenuController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
/**
1111
* Controller for view.optionsmenu.fxml.
1212
*/
13-
public class OptionsMenuController extends AbstractDataSharingController<Boolean> {
13+
public class OptionsMenuController extends DataSharingController<Boolean> {
1414
@FXML Button cancelBtn, commitBtn;
1515
@FXML CheckBox collectionsCbx, blankCbx, ontologyCbx;
1616

src/controller/PrefixMenuController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
/**
3232
* Controller for view.prefixmenu.fxml.
3333
*/
34-
public class PrefixMenuController extends AbstractDataSharingController<Map<String, String>> implements Initializable {
34+
public class PrefixMenuController extends DataSharingController<Map<String, String>> implements Initializable {
3535

3636
private static final Logger LOGGER = Logger.getLogger(PrefixMenuController.class.getName());
3737

src/view/correlateDialog.fxml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
<Button fx:id="addManualCorrBtn" maxWidth="Infinity" disable="true" onMouseClicked="#addManualCorrelationAction" text="Add Correlation"/>
2020
<Button fx:id="addHeaderBtn" maxWidth="Infinity" disable="true" onMouseClicked="#addHeaderAction" text="Add .csv Attribute"/>
2121
<Separator/>
22-
<Button fx:id="commitBtn" maxWidth="Infinity" disable="true" onMouseClicked="#commitCorrelationBtn" text="Commit Correlations"/>
23-
<Button fx:id="cancelBtn" maxWidth="Infinity" onMouseClicked="#cancelCorrelationBtn" text="Cancel Correlations"/>
22+
<Button fx:id="commitBtn" maxWidth="Infinity" disable="true" onMouseClicked="#commitCorrelationAction" text="Commit Correlations"/>
23+
<Button fx:id="cancelBtn" maxWidth="Infinity" onMouseClicked="#cancelCorrelationAction" text="Cancel Correlations"/>
2424
<Separator/>
2525
</ToolBar>
2626
<Text GridPane.rowIndex="2" GridPane.columnIndex="0" GridPane.columnSpan="2" text="Manually Correlated Attributes and Classes"/>

src/view/images/example_graph.png

16.1 KB
Loading

0 commit comments

Comments
 (0)