fix: fix sam local for httpapi (#371)

* fix: identify API_GATEWAY_V2 event from sam local

* test: add a couple tests for getEventSourceNameBasedOnEvent

Author: jrr

package-lock.json

@@ -74,6 +74,7 @@
     "@semantic-release/npm": "^7.0.10",
     "@semantic-release/release-notes-generator": "^9.0.1",
     "@types/aws-lambda": "^8.10.72",
+    "@types/jest": "^26.0.20",
     "acorn": "^8.0.5",
     "commitizen": "^4.2.3",
     "commitlint": "^11.0.0",

package.json

@@ -71,10 +71,10 @@ function getEventSourceNameBasedOnEvent ({
   event
 }) {
   if (event.requestContext && event.requestContext.elb) return 'AWS_ALB'
-  if (event.requestContext && event.requestContext.stage) {
+  if (event.Records) return 'AWS_LAMBDA_EDGE'
+  if (event.requestContext) {
     return event.version === '2.0' ? 'AWS_API_GATEWAY_V2' : 'AWS_API_GATEWAY_V1'
   }
-  if (event.Records) return 'AWS_LAMBDA_EDGE'
 
   throw new Error('Unable to determine event source based on event.')
 }

src/event-sources/utils.js

@@ -0,0 +1,52 @@
+const { getEventSourceNameBasedOnEvent } = require("./utils");
+
+/**
+This is an event delivered by `sam local start-api`,
+using Type:HttpApi, with SAM CLI version 1.18.0.
+*/
+const sam_httpapi_event = {
+  version: "2.0",
+  routeKey: "GET /",
+  rawPath: "/",
+  rawQueryString: "",
+  cookies: [],
+  headers: {
+    Host: "localhost:9000",
+    "User-Agent": "curl/7.64.1",
+    Accept: "*/*",
+    "X-Forwarded-Proto": "http",
+    "X-Forwarded-Port": "9000",
+  },
+  queryStringParameters: {},
+  requestContext: {
+    accountId: "123456789012",
+    apiId: "1234567890",
+    http: {
+      method: "GET",
+      path: "/",
+      protocol: "HTTP/1.1",
+      sourceIp: "127.0.0.1",
+      userAgent: "Custom User Agent String",
+    },
+    requestId: "aacf57f7-2fce-4069-a1f2-7cb4726dc028",
+    routeKey: "GET /",
+    stage: null,
+  },
+  body: "",
+  pathParameters: {},
+  stageVariables: null,
+  isBase64Encoded: false,
+};
+
+describe("getEventSourceNameBasedOnEvent", () => {
+  test("throws error on empty event", () => {
+    expect(() => getEventSourceNameBasedOnEvent({ event: {} })).toThrow(
+      "Unable to determine event source based on event."
+    );
+  });
+
+  test("recognizes sam local HttpApi event", () => {
+    const result = getEventSourceNameBasedOnEvent({ event: sam_httpapi_event });
+    expect(result).toEqual("AWS_API_GATEWAY_V2");
+  });
+});