refactor(bug-detectors): share suppression state

Reuse a small IgnoreList helper so code injection and path traversal store suppression rules consistently without duplicating array management. This keeps the detector APIs unchanged while making future suppression changes easier to apply safely.

Author: oetr

packages/bug-detectors/internal/code-injection.ts

@@ -29,8 +29,8 @@ import {
 	buildGenericSuppressionSnippet,
 	captureStack,
 	getRelevantStackLines,
+	IgnoreList,
 	type IgnoreRule,
-	matchesIgnoreRules,
 	type OriginFrame,
 	parseOriginFrame,
 } from "../shared/finding-suppression";
@@ -70,8 +70,8 @@ export interface CodeInjectionConfig {
 class CodeInjectionConfigImpl implements CodeInjectionConfig {
 	private _reportAccess = true;
 	private _reportInvocation = true;
-	private readonly _ignoredAccessRules: IgnoreRule[] = [];
-	private readonly _ignoredInvocationRules: IgnoreRule[] = [];
+	private readonly _ignoredAccessRules = new IgnoreList();
+	private readonly _ignoredInvocationRules = new IgnoreList();
 
 	disableAccessReporting(): this {
 		this._reportAccess = false;
@@ -84,12 +84,12 @@ class CodeInjectionConfigImpl implements CodeInjectionConfig {
 	}
 
 	ignoreAccess(rule: IgnoreRule): this {
-		this._ignoredAccessRules.push(rule);
+		this._ignoredAccessRules.add(rule);
 		return this;
 	}
 
 	ignoreInvocation(rule: IgnoreRule): this {
-		this._ignoredInvocationRules.push(rule);
+		this._ignoredInvocationRules.add(rule);
 		return this;
 	}
 
@@ -99,7 +99,7 @@ class CodeInjectionConfigImpl implements CodeInjectionConfig {
 	): boolean {
 		return (
 			this._reportAccess &&
-			!matchesIgnoreRules(this._ignoredAccessRules, originFrame, stack)
+			!this._ignoredAccessRules.matches(originFrame, stack)
 		);
 	}
 
@@ -109,7 +109,7 @@ class CodeInjectionConfigImpl implements CodeInjectionConfig {
 	): boolean {
 		return (
 			this._reportInvocation &&
-			!matchesIgnoreRules(this._ignoredInvocationRules, originFrame, stack)
+			!this._ignoredInvocationRules.matches(originFrame, stack)
 		);
 	}
 }

packages/bug-detectors/internal/path-traversal.ts

@@ -26,8 +26,8 @@ import {
 	buildGenericSuppressionSnippet,
 	captureStack,
 	getRelevantStackLines,
+	IgnoreList,
 	type IgnoreRule,
-	matchesIgnoreRules,
 	type OriginFrame,
 	parseOriginFrame,
 } from "../shared/finding-suppression";
@@ -55,15 +55,15 @@ export interface PathTraversalConfig {
 }
 
 class PathTraversalConfigImpl implements PathTraversalConfig {
-	private readonly _ignoredRules: IgnoreRule[] = [];
+	private readonly _ignoredRules = new IgnoreList();
 
 	ignore(rule: IgnoreRule): this {
-		this._ignoredRules.push(rule);
+		this._ignoredRules.add(rule);
 		return this;
 	}
 
 	shouldReport(originFrame: OriginFrame | undefined, stack: string): boolean {
-		return !matchesIgnoreRules(this._ignoredRules, originFrame, stack);
+		return !this._ignoredRules.matches(originFrame, stack);
 	}
 }
 

packages/bug-detectors/shared/finding-suppression.test.ts

@@ -17,6 +17,7 @@
 import {
 	buildGenericSuppressionSnippet,
 	getNormalizedRelevantStack,
+	IgnoreList,
 	matchesIgnoreRules,
 	parseOriginFrame,
 } from "./finding-suppression";
@@ -69,6 +70,15 @@ describe("finding suppression", () => {
 		).toBe(true);
 	});
 
+	test("IgnoreList stores and matches suppression rules", () => {
+		const originFrame = parseOriginFrame(stack);
+		const ignoreList = new IgnoreList();
+
+		ignoreList.add({ stackPattern: "sample.test.js:10" });
+
+		expect(ignoreList.matches(originFrame, stack)).toBe(true);
+	});
+
 	test("prints generic example snippets with optional chaining", () => {
 		expect(
 			buildGenericSuppressionSnippet("code-injection", "ignoreInvocation"),

packages/bug-detectors/shared/finding-suppression.ts

@@ -54,6 +54,18 @@ export type OriginFrame = {
 	filePath?: string;
 };
 
+export class IgnoreList {
+	private readonly _rules: IgnoreRule[] = [];
+
+	add(rule: IgnoreRule): void {
+		this._rules.push(rule);
+	}
+
+	matches(originFrame: OriginFrame | undefined, stack: string): boolean {
+		return matchesIgnoreRules(this._rules, originFrame, stack);
+	}
+}
+
 export function matchesIgnoreRules(
 	rules: IgnoreRule[],
 	originFrame: OriginFrame | undefined,