Commit 97c153f
authored
Setuptools symlinks (pytorch#20092)
### Summary
build_py: filter directory symlinks from manifest_files in non-editable
mode
Recent setuptools includes bare directory symlinks (e.g.
src/executorch/backends -> ../../backends) from version control in
manifest_files. These exist for editable mode but break regular
installs: build_package_data passes them to copy_file, which calls
os.path.isfile() and gets False for a symlink-to-directory.
Override analyze_manifest() to filter out non-regular-file entries
after the parent populates manifest_files, guarded by editable_mode.
Fixes pytorch#20091
### Test plan
Run the command in the bug report with the problematic Python version as
reported.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils
@Sebastian-Larsson @robell @rascani1 parent 92e6a4c commit 97c153f
1 file changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
684 | 684 | | |
685 | 685 | | |
686 | 686 | | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
687 | 703 | | |
688 | 704 | | |
689 | 705 | | |
| |||
0 commit comments