Skip to content

Commit bde7360

Browse files
authored
Move Cortex-M backend tests from trunk.yml to pull.yml (pytorch#18308)
The test-mcu-cortex-m-backend CI job runs all Cortex-M pytests but was only in trunk.yml, meaning zero tests ran at diff time. Move it to pull.yml so regressions are caught on-diff before merge. Authored with Claude.
1 parent b2f0a5a commit bde7360

2 files changed

Lines changed: 30 additions & 30 deletions

File tree

.github/workflows/pull.yml

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -607,6 +607,36 @@ jobs:
607607
exit 1
608608
fi
609609
610+
test-mcu-cortex-m-backend:
611+
name: test-mcu-cortex-m-backend
612+
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
613+
permissions:
614+
id-token: write
615+
contents: read
616+
with:
617+
runner: linux.2xlarge.memory
618+
docker-image: ci-image:executorch-ubuntu-22.04-arm-sdk
619+
submodules: 'recursive'
620+
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
621+
timeout: 120
622+
script: |
623+
# The generic Linux job chooses to use base env, not the one setup by the image
624+
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
625+
conda activate "${CONDA_ENV}"
626+
627+
source .ci/scripts/utils.sh
628+
install_executorch "--use-pt-pinned-commit"
629+
630+
# Install arm dependencies
631+
.ci/scripts/setup-arm-baremetal-tools.sh
632+
source examples/arm/arm-scratch/setup_path.sh
633+
634+
# To build cortex-m test runner
635+
backends/cortex_m/test/build_test_runner.sh
636+
637+
# To run cortex_m tests
638+
pytest --config-file=backends/arm/test/pytest.ini backends/cortex_m/test
639+
610640
android:
611641
uses: ./.github/workflows/_android.yml
612642
permissions:

.github/workflows/trunk.yml

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1054,33 +1054,3 @@ jobs:
10541054
10551055
.ci/scripts/test_model.ps1 -modelName ${{ matrix.model }} -backend ${{ matrix.backend }}
10561056
}"
1057-
1058-
test-mcu-cortex-m-backend:
1059-
name: test-mcu-cortex-m-backend
1060-
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
1061-
permissions:
1062-
id-token: write
1063-
contents: read
1064-
with:
1065-
runner: linux.2xlarge.memory
1066-
docker-image: ci-image:executorch-ubuntu-22.04-arm-sdk
1067-
submodules: 'recursive'
1068-
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
1069-
timeout: 120
1070-
script: |
1071-
# The generic Linux job chooses to use base env, not the one setup by the image
1072-
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")
1073-
conda activate "${CONDA_ENV}"
1074-
1075-
source .ci/scripts/utils.sh
1076-
install_executorch "--use-pt-pinned-commit"
1077-
1078-
# Install arm dependencies
1079-
.ci/scripts/setup-arm-baremetal-tools.sh
1080-
source examples/arm/arm-scratch/setup_path.sh
1081-
1082-
# To build cortex-m test runner
1083-
backends/cortex_m/test/build_test_runner.sh
1084-
1085-
# To run cortex_m tests
1086-
pytest --config-file=backends/arm/test/pytest.ini backends/cortex_m/test

0 commit comments

Comments
 (0)