fix: AI Comments

Author: The-Code-Monkey

src/main/java/com/tcm/MineTale/block/workbenches/FurnaceWorkbench.java

@@ -21,8 +21,7 @@ public class FurnaceWorkbench extends AbstractWorkbench<FurnaceWorkbenchEntity>
     private static final boolean IS_WIDE = true;
     private static final boolean IS_TALL = true;
 
-    public static final MapCodec<FurnaceWorkbench> CODEC = simpleCodec((properties) -> 
-        new FurnaceWorkbench(properties, () -> null));
+    public static final MapCodec<FurnaceWorkbench> CODEC = simpleCodec(FurnaceWorkbench::new);
 
     /**
      * Standard constructor for registration.

src/main/java/com/tcm/MineTale/block/workbenches/entity/AbstractWorkbenchEntity.java

@@ -32,6 +32,9 @@ public AbstractWorkbenchEntity(BlockEntityType<?> type, BlockPos pos, BlockState
     // --- CHEST SCANNING ---
     public List<Container> getNearbyInventories() {
         List<Container> inventories = new ArrayList<>();
+        if (level == null) {
+            return inventories;
+        } 
         BlockPos.betweenClosed(
             worldPosition.offset((int)-scanRadius, -2, (int)-scanRadius),
             worldPosition.offset((int)scanRadius, 2, (int)scanRadius)

src/main/java/com/tcm/MineTale/block/workbenches/entity/FurnaceWorkbenchEntity.java

@@ -27,6 +27,11 @@ public class FurnaceWorkbenchEntity extends AbstractWorkbenchEntity {
     // 0     -> Fuel Slots
     // 1, 2  -> Input Slot
     // 3-6   -> Output Slots
+    private static final int FUEL_SLOT = 0;
+    private static final int INPUT_1 = 1;
+    private static final int INPUT_2 = 2;
+    private static final int OUTPUT_START = 3;
+    private static final int OUTPUT_END = 6;
     private final SimpleContainer inventory = new SimpleContainer(7);
 
     private int cookTime;
@@ -68,8 +73,10 @@ public void tick(Level level, BlockPos pos, BlockState state) {
         if (level.isClientSide()) return;
 
         boolean changed = false;
-        ItemStack input = inventory.getItem(0);
-        ItemStack fuel = inventory.getItem(1);
+        ItemStack fuel = inventory.getItem(FUEL_SLOT);
+        ItemStack input = !inventory.getItem(INPUT_1).isEmpty()
+            ? inventory.getItem(INPUT_1)
+            : inventory.getItem(INPUT_2);
 
         // TRAIT: Streamline crafting by pulling from nearby chests if input is empty
         if (input.isEmpty() && level.getGameTime() % 20 == 0) {
@@ -130,7 +137,10 @@ private void smeltItem(ItemStack input) {
             result = new ItemStack(Items.COPPER_INGOT); 
         }
 
-        ItemStack output = inventory.getItem(2);
+        int outputSlot = findOutputSlot(result);
+        if (outputSlot == -1) return;
+        ItemStack output = inventory.getItem(outputSlot);
+
         if (output.isEmpty()) {
             inventory.setItem(2, result.copy());
         } else if (ItemStack.isSameItem(output, result)) {
@@ -145,14 +155,27 @@ private void pullFromNearbyChests() {
             for (int i = 0; i < chest.getContainerSize(); i++) {
                 ItemStack stack = chest.getItem(i);
                 if (isOre(stack) || isWood(stack)) {
-                    inventory.setItem(0, stack.split(1));
+                    int inputSlot = inventory.getItem(INPUT_1).isEmpty() ? INPUT_1 : (inventory.getItem(INPUT_2).isEmpty() ? INPUT_2 : -1);
+                    if (inputSlot == -1) return;
+                    inventory.setItem(inputSlot, stack.split(1));
                     chest.setChanged();
                     return;
                 }
             }
         }
     }
 
+    private int findOutputSlot(ItemStack result) {
+        for (int i = OUTPUT_START; i <= OUTPUT_END; i++) {
+            ItemStack out = inventory.getItem(i);
+            if (out.isEmpty() || (ItemStack.isSameItem(out, result)
+                && out.getCount() + result.getCount() <= out.getMaxStackSize())) {
+                return i;
+            }
+        }
+        return -1;
+    }
+
     // --- Helpers ---
     private boolean isOre(ItemStack stack) { return stack.is(Items.RAW_COPPER); /* Add more ores */ }
     private boolean isWood(ItemStack stack) { return stack.getItem().toString().contains("log"); }

src/main/java/com/tcm/MineTale/block/workbenches/menu/FurnaceWorkbenchMenu.java

@@ -2,6 +2,7 @@
 
 import com.tcm.MineTale.registry.ModMenuTypes;
 
+import net.minecraft.tags.ItemTags;
 import net.minecraft.world.Container;
 import net.minecraft.world.SimpleContainer;
 import net.minecraft.world.entity.player.Inventory;
@@ -36,6 +37,7 @@ public FurnaceWorkbenchMenu(int syncId, Inventory playerInventory) {
     public FurnaceWorkbenchMenu(int syncId, Inventory playerInventory, Container container, ContainerData data) {
         super(ModMenuTypes.FURNACE_WORKBENCH_MENU, syncId);
         checkContainerSize(container, containerSize);
+        checkContainerDataCount(data, 4);
         this.container = container;
         this.data = data;
 
@@ -47,8 +49,7 @@ public FurnaceWorkbenchMenu(int syncId, Inventory playerInventory, Container con
         this.addSlot(new Slot(container, FUEL_SLOT, 80, 53) {
             @Override
             public boolean mayPlace(ItemStack stack) {
-                // Trait: Sticks, Fibres (String), and Logs
-                return stack.is(Items.STICK) || stack.is(Items.STRING) || stack.getItem().toString().contains("log");
+                return isFuel(stack);
             }
         });
 
@@ -57,10 +58,10 @@ public boolean mayPlace(ItemStack stack) {
         this.addSlot(new Slot(container, INPUT_2, 44, 35));
 
         // 3. Four Output Slots (2x2 Grid on the right)
-        this.addSlot(new FurnaceResultSlot(playerInventory.player, container, 3, 116, 21));
-        this.addSlot(new FurnaceResultSlot(playerInventory.player, container, 4, 134, 21));
-        this.addSlot(new FurnaceResultSlot(playerInventory.player, container, 5, 116, 39));
-        this.addSlot(new FurnaceResultSlot(playerInventory.player, container, 6, 134, 39));
+        this.addSlot(new FurnaceResultSlot(playerInventory.player, container, OUTPUT_START, 116, 21));
+        this.addSlot(new FurnaceResultSlot(playerInventory.player, container, OUTPUT_START + 1, 134, 21));
+        this.addSlot(new FurnaceResultSlot(playerInventory.player, container, OUTPUT_END - 1, 116, 39));
+        this.addSlot(new FurnaceResultSlot(playerInventory.player, container, OUTPUT_END, 134, 39));
 
         // --- PLAYER INVENTORY ---
         addPlayerInventory(playerInventory);
@@ -106,7 +107,7 @@ else if (!this.moveItemStackTo(itemStack2, 1, 3, false)) {
     }
 
     private boolean isFuel(ItemStack stack) {
-        return stack.is(Items.STICK) || stack.is(Items.STRING) || stack.getItem().toString().contains("log");
+        return stack.is(Items.STICK) || stack.is(Items.STRING) || stack.is(ItemTags.LOGS_THAT_BURN);
     }
 
     @Override