Skip to content
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/client/java/com/tcm/MineTale/MineTaleClient.java
Original file line number Diff line number Diff line change
@@ -1,25 +1,26 @@
package com.tcm.MineTale;

import com.tcm.MineTale.block.workbenches.screen.FurnaceWorkbenchScreen;
import com.tcm.MineTale.block.workbenches.screen.WorkbenchWorkbenchScreen;
import com.tcm.MineTale.block.workbenches.screen.CampfireWorkbenchScreen;
import com.tcm.MineTale.registry.ModMenuTypes;

import net.fabricmc.api.ClientModInitializer;
import net.minecraft.client.gui.screens.MenuScreens;

public class MineTaleClient implements ClientModInitializer {



/**
* Registers client-side screen factories for custom workbench menu types.
* Register client-side screen factories for custom workbench menu types.
*
* Binds the furnace and campfire workbench menu types to their corresponding screen constructors
* so the client can create the appropriate GUI when those menus are opened.
* Binds ModMenuTypes.FURNACE_WORKBENCH_MENU to FurnaceWorkbenchScreen,
* ModMenuTypes.CAMPFIRE_WORKBENCH_MENU to CampfireWorkbenchScreen, and
* ModMenuTypes.WORKBENCH_WORKBENCH_MENU to WorkbenchWorkbenchScreen so the client
* can create the appropriate GUI when those menus open.
*/
@Override
public void onInitializeClient() {
MenuScreens.register(ModMenuTypes.FURNACE_WORKBENCH_MENU, FurnaceWorkbenchScreen::new);
MenuScreens.register(ModMenuTypes.CAMPFIRE_WORKBENCH_MENU, CampfireWorkbenchScreen::new);
MenuScreens.register(ModMenuTypes.WORKBENCH_WORKBENCH_MENU, WorkbenchWorkbenchScreen::new);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,262 @@
package com.tcm.MineTale.block.workbenches.screen;

import java.util.List;

import com.tcm.MineTale.MineTale;
import com.tcm.MineTale.block.workbenches.menu.WorkbenchWorkbenchMenu;
import com.tcm.MineTale.mixin.client.RecipeBookComponentAccessor;
import com.tcm.MineTale.network.CraftRequestPayload;
import com.tcm.MineTale.recipe.MineTaleRecipeBookComponent;
import com.tcm.MineTale.registry.ModBlocks;
import com.tcm.MineTale.registry.ModRecipeDisplay;
import com.tcm.MineTale.registry.ModRecipes;

import net.fabricmc.fabric.api.client.networking.v1.ClientPlayNetworking;
import net.minecraft.client.gui.GuiGraphics;
import net.minecraft.client.gui.components.Button;
import net.minecraft.client.gui.navigation.ScreenPosition;
import net.minecraft.client.gui.screens.inventory.AbstractRecipeBookScreen;
import net.minecraft.client.gui.screens.recipebook.RecipeBookComponent;
import net.minecraft.client.gui.screens.recipebook.RecipeCollection;
import net.minecraft.client.renderer.RenderPipelines;
import net.minecraft.resources.Identifier;
import net.minecraft.world.entity.player.Inventory;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.crafting.display.RecipeDisplayEntry;
import net.minecraft.world.item.crafting.display.RecipeDisplayId;
import net.minecraft.world.item.crafting.display.SlotDisplayContext;
import net.minecraft.network.chat.Component;

public class WorkbenchWorkbenchScreen extends AbstractRecipeBookScreen<WorkbenchWorkbenchMenu> {
private static final Identifier TEXTURE =
Identifier.fromNamespaceAndPath(MineTale.MOD_ID, "textures/gui/container/furnace_workbench.png");
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

private final MineTaleRecipeBookComponent mineTaleRecipeBook;

private Button craftOneBtn;
private Button craftThirtyBtn;
private Button craftAllBtn;

/**
* Initialize a workbench GUI screen using the provided container menu, player inventory, and title.
*
* @param menu the menu supplying slots and synchronized state for this screen
* @param inventory the player's inventory to display and interact with
* @param title the title component shown at the top of the screen
*/
public WorkbenchWorkbenchScreen(WorkbenchWorkbenchMenu menu, Inventory inventory, Component title) {
this(menu, inventory, title, createRecipeBookComponent(menu));
}

/**
* Creates a WorkbenchWorkbenchScreen bound to the given menu, player inventory, title, and recipe book component.
*
* @param menu the menu backing this screen
* @param inventory the player's inventory shown in the screen
* @param title the screen title component
* @param recipeBook the MineTaleRecipeBookComponent used to display and manage recipes in this screen
*/
private WorkbenchWorkbenchScreen(WorkbenchWorkbenchMenu menu, Inventory inventory, Component title, MineTaleRecipeBookComponent recipeBook) {
super(menu, recipeBook, inventory, title);
this.mineTaleRecipeBook = recipeBook;
}

/**
* Create a MineTaleRecipeBookComponent configured for the workbench screen.
*
* @param menu the workbench menu used to initialize the recipe book component
* @return a MineTaleRecipeBookComponent containing the workbench tab and associated recipe category
*/
private static MineTaleRecipeBookComponent createRecipeBookComponent(WorkbenchWorkbenchMenu menu) {
ItemStack tabIcon = new ItemStack(ModBlocks.WORKBENCH_WORKBENCH_BLOCK.asItem());

List<RecipeBookComponent.TabInfo> tabs = List.of(
new RecipeBookComponent.TabInfo(tabIcon.getItem(), ModRecipeDisplay.WORKBENCH_SEARCH)
);

return new MineTaleRecipeBookComponent(menu, tabs, ModRecipes.WORKBENCH_TYPE);
}

/**
* Configure the screen's GUI dimensions and initialize widgets.
*
* Sets the layout size (imageWidth = 176, imageHeight = 166), delegates remaining
* layout initialization to the superclass, and creates the three craft buttons
* ("1", "30", "All") wired to their respective handlers.
*/
@Override
protected void init() {
// Important: Set your GUI size before super.init()
this.imageWidth = 176;
this.imageHeight = 166;

super.init();

this.craftOneBtn = addRenderableWidget(Button.builder(Component.literal("1"), (button) -> {
handleCraftRequest(1);
}).bounds(this.leftPos + 80, this.topPos + 20, 30, 20).build());

this.craftThirtyBtn = addRenderableWidget(Button.builder(Component.literal("30"), (button) -> {
handleCraftRequest(30);
}).bounds(this.leftPos + 112, this.topPos + 20, 30, 20).build());

this.craftAllBtn = addRenderableWidget(Button.builder(Component.literal("All"), (button) -> {
handleCraftRequest(-1); // -1 represents "All" logic
}).bounds(this.leftPos + 144, this.topPos + 20, 30, 20).build());
}

// private void handleCraftRequest(int amount) {
// RecipeBookPage page = ((RecipeBookComponentAccessor)this.mineTaleRecipeBook).getRecipeBookPage();
// RecipeCollection collection = page.getLastClickedRecipeCollection();
// RecipeDisplayId displayId = page.getLastClickedRecipe();

// if (collection != null && displayId != null) {
// // 1. Find the specific entry that was clicked
// for (RecipeDisplayEntry entry : collection.getSelectedRecipes(RecipeCollection.CraftableStatus.ANY)) {
// if (entry.id().equals(displayId)) {
// // 2. Resolve the visual result into an actual ItemStack
// List<ItemStack> results = entry.resultItems(SlotDisplayContext.fromLevel(this.minecraft.level));

// if (!results.isEmpty()) {
// ItemStack resultStack = results.get(0);
// // 3. Send the item and amount to the server
// // Note: Update your CraftRequestPayload to accept ItemStack instead of Identifier
// ClientPlayNetworking.send(new CraftRequestPayload(resultStack, amount));
// }
// break;
// }
// }
// }
// }

// private void handleCraftRequest(int amount) {
// // 1. Get the current page from the recipe book
// // We use your mixin/accessor to get the internal page object
// RecipeBookPage page = ((RecipeBookComponentAccessor)this.mineTaleRecipeBook).getRecipeBookPage();

// // 2. Identify WHAT was clicked
// RecipeCollection collection = page.getLastClickedRecipeCollection();
// RecipeDisplayId displayId = page.getLastClickedRecipe();

// if (collection != null && displayId != null) {
// // 3. Find the display entry
// for (RecipeDisplayEntry entry : collection.getSelectedRecipes(RecipeCollection.CraftableStatus.ANY)) {
// if (entry.id().equals(displayId)) {
// // 4. Get the result item (the Chest)
// // 1.21.1 uses SlotDisplayContext to handle dynamic results
// List<ItemStack> results = entry.resultItems(SlotDisplayContext.fromLevel(this.minecraft.level));

// if (!results.isEmpty()) {
// ItemStack resultStack = results.get(0);

// // 5. Send the packet to the Server
// // IMPORTANT: Ensure your CraftRequestPayload is registered to handle
// // an ItemStack and an Int.
// ClientPlayNetworking.send(new CraftRequestPayload(resultStack, amount));

// // Optional: Play a click sound so the player knows it worked
// this.minecraft.getSoundManager().play(net.minecraft.client.resources.sounds.SimpleSoundInstance.forUI(
// net.minecraft.sounds.SoundEvents.UI_BUTTON_CLICK, 1.0F));
// }
// break;
// }
// }
// }
// }
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

/**
* Sends a crafting request for the currently selected recipe in the integrated recipe book.
*
* Locates the last recipe collection and last selected recipe ID from the recipe book component,
* resolves the recipe's result item, and sends a CraftRequestPayload to the server containing that
* item and the requested amount.
*
* @param amount the quantity to craft; use -1 to request crafting of the full available stack ("All")
*/

private void handleCraftRequest(int amount) {
// 1. Cast the book component to the Accessor to get the selected data
RecipeBookComponentAccessor accessor = (RecipeBookComponentAccessor) this.mineTaleRecipeBook;

RecipeCollection collection = accessor.getLastRecipeCollection();
RecipeDisplayId displayId = accessor.getLastRecipe();

if (collection != null && displayId != null) {
// 2. Find the visual entry
for (RecipeDisplayEntry entry : collection.getSelectedRecipes(RecipeCollection.CraftableStatus.ANY)) {
if (entry.id().equals(displayId)) {
// 3. Resolve result for the packet
List<ItemStack> results = entry.resultItems(SlotDisplayContext.fromLevel(this.minecraft.level));

if (!results.isEmpty()) {
ItemStack resultStack = results.get(0);

// 4. LOG FOR DEBUGGING: Does this print in your console?
System.out.println("Sending craft request for: " + resultStack + " amount: " + amount);
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

Replace System.out.println with a proper logger.

Debug prints via System.out.println should not ship to production. Use SLF4J (MineTale.LOGGER or a class-level logger) so log level can be controlled at runtime.

Proposed fix
-                        // 4. LOG FOR DEBUGGING: Does this print in your console?
-                        System.out.println("Sending craft request for: " + resultStack + " amount: " + amount);
+                        MineTale.LOGGER.debug("Sending craft request for: {} amount: {}", resultStack, amount);
-            System.out.println("Request failed: Collection or DisplayID is null!");
+            MineTale.LOGGER.debug("Craft request skipped: collection or displayId is null");

Also applies to: 186-188

🤖 Prompt for AI Agents
In
`@src/client/java/com/tcm/MineTale/block/workbenches/screen/WorkbenchWorkbenchScreen.java`
around lines 178 - 179, Replace the System.out.println debug prints in
WorkbenchWorkbenchScreen (the println that logs "Sending craft request for: "
and the similar prints later) with SLF4J logging: use the existing
MineTale.LOGGER or create a private static final Logger for
WorkbenchWorkbenchScreen and call the appropriate level (debug or info) with a
formatted message including resultStack and amount; remove the
System.out.println calls and ensure imports/reference to MineTale.LOGGER are
used so log level can be controlled at runtime.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to keep this for now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@The-Code-Monkey, understood! I'll leave the debug logging as-is for now.


🧠 Learnings used
Learnt from: The-Code-Monkey
Repo: CodeMonkeysMods/MineTale PR: 28
File: src/main/java/com/tcm/MineTale/block/workbenches/menu/FurnaceWorkbenchMenu.java:54-57
Timestamp: 2026-02-06T08:19:40.485Z
Learning: In FurnaceWorkbenchMenu.java, returning RecipeBookType.CRAFTING from getRecipeBookType() is acceptable because the custom MineTaleRecipeBookComponent filters recipes by both display type and the specific recipe type (FURNACE_T1_TYPE), preventing these custom recipes from appearing in vanilla recipe book tabs.


ClientPlayNetworking.send(new CraftRequestPayload(resultStack, amount));
}
break;
}
}
} else {
System.out.println("Request failed: Collection or DisplayID is null!");
}
}

/**
* Draws the workbench GUI background texture at the screen's top-left corner.
*
* @param guiGraphics the graphics context used to draw GUI elements
* @param f partial tick time for interpolation
* @param i current mouse x coordinate relative to the window
* @param j current mouse y coordinate relative to the window
*/
protected void renderBg(GuiGraphics guiGraphics, float f, int i, int j) {
int k = this.leftPos;
int l = this.topPos;
guiGraphics.blit(RenderPipelines.GUI_TEXTURED, TEXTURE, k, l, 0.0F, 0.0F, this.imageWidth, this.imageHeight, 256, 256);
}

/**
* Renders the workbench screen including the background tint, GUI elements, and tooltips.
*
* @param graphics the graphics context
* @param mouseX the current mouse x-coordinate
* @param mouseY the current mouse y-coordinate
* @param delta the partial tick delta for frame interpolation
*/
@Override
public void render(GuiGraphics graphics, int mouseX, int mouseY, float delta) {
// 1. Always render the dark background tint first
renderBackground(graphics, mouseX, mouseY, delta);

// 3. Call super (this draws your slots and items)
super.render(graphics, mouseX, mouseY, delta);

boolean hasSelection = this.mineTaleRecipeBook.getSelectedRecipeId() != null;
this.craftOneBtn.active = hasSelection;
this.craftThirtyBtn.active = hasSelection;
this.craftAllBtn.active = hasSelection;

renderTooltip(graphics, mouseX, mouseY);
}

/**
* Computes the on-screen position for the recipe book toggle button for this GUI.
*
* @return the screen position placed 5 pixels from the GUI's left edge and 49 pixels above the GUI's vertical center
*/
@Override
protected ScreenPosition getRecipeBookButtonPosition() {
// 1. Calculate the start (left) of your workbench GUI
int guiLeft = (this.width - this.imageWidth) / 2;

// 2. Calculate the top of your workbench GUI
int guiTop = (this.height - this.imageHeight) / 2;

// 3. Standard Vanilla positioning:
// Usually 5 pixels in from the left and 49 pixels up from the center
return new ScreenPosition(guiLeft + 5, guiTop + this.imageHeight / 2 - 49);
}
}
63 changes: 58 additions & 5 deletions src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java
Original file line number Diff line number Diff line change
@@ -1,18 +1,39 @@
package com.tcm.MineTale.datagen;

import com.tcm.MineTale.MineTale;
import com.tcm.MineTale.registry.ModBlocks;
import net.fabricmc.fabric.api.client.datagen.v1.provider.FabricModelProvider;
import net.fabricmc.fabric.api.datagen.v1.FabricDataOutput;
import net.minecraft.client.data.models.BlockModelGenerators;
import net.minecraft.client.data.models.ItemModelGenerators;
import net.minecraft.client.data.models.blockstates.MultiVariantGenerator;
import net.minecraft.client.data.models.blockstates.PropertyDispatch;
import net.minecraft.client.data.models.model.ModelLocationUtils;
import net.minecraft.client.data.models.model.ModelTemplates;
import net.minecraft.client.data.models.model.TextureMapping;
import net.minecraft.client.data.models.model.TextureSlot;
import net.minecraft.client.renderer.block.model.VariantMutator;
import net.minecraft.core.Direction;
import net.minecraft.resources.Identifier;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.state.properties.BlockStateProperties;
import net.minecraft.world.level.block.state.properties.ChestType;
import net.minecraft.world.level.block.state.properties.DoubleBlockHalf;

public class ModModelProvider extends FabricModelProvider {
/**
* Creates a ModModelProvider using the given Fabric data output.
*
* @param output the FabricDataOutput used to write generated model and blockstate data
*/
public ModModelProvider(FabricDataOutput output) { super(output); }
* Creates a ModModelProvider using the given Fabric data output.
*
* @param output the FabricDataOutput used to write generated model and blockstate data
*/
public ModModelProvider(FabricDataOutput output) { super(output); }

// Recreate the rotation logic locally since the base one is private
private static final PropertyDispatch<VariantMutator> WORKBENCH_ROTATION = PropertyDispatch.modify(BlockStateProperties.HORIZONTAL_FACING)
.select(Direction.NORTH, BlockModelGenerators.NOP)
.select(Direction.EAST, BlockModelGenerators.Y_ROT_90)
.select(Direction.SOUTH, BlockModelGenerators.Y_ROT_180)
.select(Direction.WEST, BlockModelGenerators.Y_ROT_270);

/**
* Registers block state and model definitions for the mod's log blocks.
Expand Down Expand Up @@ -54,6 +75,38 @@ public void generateBlockStateModels(BlockModelGenerators blockStateModelGenerat
blockStateModelGenerator.woodProvider(ModBlocks.STRIPPED_LOG).logWithHorizontal(ModBlocks.STRIPPED_LOG);
blockStateModelGenerator.woodProvider(ModBlocks.WINDWILLOW_LOG).logWithHorizontal(ModBlocks.WINDWILLOW_LOG);
blockStateModelGenerator.woodProvider(ModBlocks.WILD_WISTERIA_LOG).logWithHorizontal(ModBlocks.WILD_WISTERIA_LOG).wood(ModBlocks.WILD_WISTERIA_WOOD);

registerLargeWorkbench(blockStateModelGenerator, ModBlocks.FURNACE_WORKBENCH_BLOCK_T1);
}
Comment on lines +74 to +77
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if WORKBENCH_WORKBENCH_BLOCK exists and whether it has any model JSON or other datagen registration
echo "=== Searching for WORKBENCH_WORKBENCH_BLOCK definition ==="
rg -n "WORKBENCH_WORKBENCH_BLOCK" --type=java -C 3

echo ""
echo "=== Searching for hand-written workbench model JSONs ==="
find . -path "*/models/block/*workbench*" -type f | sort

echo ""
echo "=== Searching for hand-written blockstate JSONs ==="
find . -path "*/blockstates/*workbench*" -type f | sort

Repository: CodeMonkeysMods/MineTale

Length of output: 5360


🏁 Script executed:

#!/bin/bash
echo "=== Checking WorkbenchWorkbench class structure ==="
rg -n "class WorkbenchWorkbench" --type=java -A 20

echo ""
echo "=== Searching for all methods in ModModelProvider.java ==="
rg -n "def |void |public " src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java | head -30

echo ""
echo "=== Check if WORKBENCH_WORKBENCH_BLOCK is registered anywhere in ModModelProvider ==="
rg -n "WORKBENCH_WORKBENCH_BLOCK" src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java

Repository: CodeMonkeysMods/MineTale

Length of output: 11567


🏁 Script executed:

#!/bin/bash
echo "=== Full generateBlockStateModels method ==="
sed -n '43,77p' src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java

Repository: CodeMonkeysMods/MineTale

Length of output: 3657


Add model registration for WORKBENCH_WORKBENCH_BLOCK in generateBlockStateModels.

The new WORKBENCH_WORKBENCH_BLOCK is registered in ModBlocks.java and added to creative tabs but is missing model/blockstate generation in ModModelProvider.java. Since WorkbenchWorkbench is a 1×1 block (not a 2×2 multiblock like the furnace workbenches), it needs its own model registration—otherwise it will render as a missing-model purple-and-black cube in-game. Either generate models via datagen or provide hand-written blockstate/model JSON files.

🤖 Prompt for AI Agents
In `@src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java` around lines
74 - 76, generateBlockStateModels is missing model registration for the new 1x1
WORKBENCH_WORKBENCH_BLOCK, so it renders as a missing-model in-game; fix it by
adding a registration call in ModModelProvider.generateBlockStateModels (next to
registerLargeWorkbench(...)) to generate a standard model for
ModBlocks.WORKBENCH_WORKBENCH_BLOCK — e.g., call the same simple-block helper
used elsewhere (registerSimpleBlock or the project’s equivalent) with
blockStateModelGenerator and ModBlocks.WORKBENCH_WORKBENCH_BLOCK, or if you need
a custom model use the generator’s model creation helper to produce the correct
blockstate/model JSON.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workbenchworkbench is a 1x2 model so needs to be two wide one tall.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
echo "=== Check WorkbenchWorkbench class for properties ==="
cat src/main/java/com/tcm/MineTale/block/workbenches/WorkbenchWorkbench.java

echo ""
echo "=== Search for workbench_workbench model JSON files ==="
find . -path "*/models/block/*workbench_workbench*" -type f 2>/dev/null | sort

echo ""
echo "=== Check if workbench_workbench blockstate JSON exists ==="
find . -path "*/blockstates/*workbench_workbench*" -type f 2>/dev/null

echo ""
echo "=== Check AbstractWorkbench for default properties ==="
rg -n "class AbstractWorkbench" --type=java -A 30 | head -50

Length of output: 11513


🏁 Script executed:

#!/bin/bash
echo "=== Check AbstractWorkbench class and constructor ==="
rg -n "class AbstractWorkbench" --type=java -A 60 | head -80

echo ""
echo "=== Search how IS_WIDE and IS_TALL are used in AbstractWorkbench ==="
rg -n "isWide|isTall" src/main/java/com/tcm/MineTale/block/workbenches/ --type=java -C 2

Length of output: 17720


@The-Code-Monkey, thank you for the clarification! I see the issue now—there's a mismatch between your design intent and the current code.

Looking at WorkbenchWorkbench.java lines 26-27, the constants are currently set as:

public static final boolean IS_WIDE = false;
public static final boolean IS_TALL = false;

This configures it as a 1×1 block (single block). For a 1×2 block (two wide, one tall), you need:

public static final boolean IS_WIDE = true;  // ← Change to true
public static final boolean IS_TALL = false;

When IS_WIDE = true, AbstractWorkbench will:

  • Place two blocks side-by-side (LEFT and RIGHT via ChestType)
  • Set the initial block as ChestType.LEFT and place a companion ChestType.RIGHT block (see AbstractWorkbench.java lines 84-87)

Two fixes are needed:

  1. Fix the constants in WorkbenchWorkbench.java: Change IS_WIDE from false to true

  2. Add model registration in ModModelProvider.java: Since a 1×2 workbench uses only ChestType (LEFT/RIGHT) without DoubleBlockHalf, you'll need either:

    • A new registration method for 1×2 blocks, or
    • Adapt registerLargeWorkbench to handle 1×2 variants

    Plus, create the corresponding model JSON files:

    • workbench_workbench_left.json
    • workbench_workbench_right.json
    • workbench_workbench_inventory.json

Would you like me to help generate the model registration code for the 1×2 workbench?


🧬 Code Graph Analysis Results

src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java

  1. Snippet:WORKBENCH_ROTATION constant
  • File: src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java
  • Line range (approximate): 16-24
  • Content:
private static final PropertyDispatch<VariantMutator> WORKBENCH_ROTATION = PropertyDispatch.modify(BlockStateProperties.HORIZONTAL_FACING)
        .select(Direction.NORTH, BlockModelGenerators.NOP)
        .select(Direction.EAST, BlockModelGenerators.Y_ROT_90)
        .select(Direction.SOUTH, BlockModelGenerators.Y_ROT_180)
        .select(Direction.WEST, BlockModelGenerators.Y_ROT_270);
  1. Snippet: registerLargeWorkbench method
  • File: src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java
  • Line range (approximate): 38-74 (method plus header comments)
  • Content:
private void registerLargeWorkbench(BlockModelGenerators generator, Block block) {
    // 1. Get the base identifier (e.g., minetale:block/furnace_workbench_block_t1)
    Identifier blockId = ModelLocationUtils.getModelLocation(block);

    // 2. Build the references to your manual JSON files
    // .withSuffix() creates: minetale:block/furnace_workbench_block_t1_bottom_left, etc.
    Identifier bottomLeft  = blockId.withSuffix("_bottom_left");
    Identifier bottomRight = blockId.withSuffix("_bottom_right");
    Identifier topLeft     = blockId.withSuffix("_top_left");
    Identifier topRight    = blockId.withSuffix("_top_right");
    Identifier inventory   = blockId.withSuffix("_inventory");

    // 3. Dispatch to Blockstate (Tells the game which model to show for each state)
    generator.blockStateOutput.accept(MultiVariantGenerator.dispatch(block)
        .with(PropertyDispatch.initial(BlockStateProperties.DOUBLE_BLOCK_HALF, BlockStateProperties.CHEST_TYPE)
            .select(DoubleBlockHalf.LOWER, ChestType.LEFT,   BlockModelGenerators.plainVariant(bottomLeft))
            .select(DoubleBlockHalf.LOWER, ChestType.RIGHT,  BlockModelGenerators.plainVariant(bottomRight))
            .select(DoubleBlockHalf.UPPER, ChestType.LEFT,   BlockModelGenerators.plainVariant(topLeft))
            .select(DoubleBlockHalf.UPPER, ChestType.RIGHT,  BlockModelGenerators.plainVariant(topRight))
            // Support the 'SINGLE' state as a fallback
            .select(DoubleBlockHalf.LOWER, ChestType.SINGLE, BlockModelGenerators.plainVariant(bottomLeft))
            .select(DoubleBlockHalf.UPPER, ChestType.SINGLE, BlockModelGenerators.plainVariant(topLeft))
        )
        .with(WORKBENCH_ROTATION)
    );

    // 4. Map the Item in your hand to the inventory JSON
    generator.registerSimpleItemModel(block, inventory);
}

✏️ Learnings added
Learnt from: The-Code-Monkey
Repo: CodeMonkeysMods/MineTale PR: 30
File: src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java:74-76
Timestamp: 2026-02-13T08:23:39.499Z
Learning: The WORKBENCH_WORKBENCH_BLOCK in WorkbenchWorkbench.java should be configured as a 1x2 block (two wide, one tall) by setting IS_WIDE = true and IS_TALL = false, not as a 1x1 block.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

Comment on lines +74 to +77
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

FURNACE_WORKBENCH_BLOCK_T2 is also missing model registration.

WORKBENCH_WORKBENCH_BLOCK was already flagged, but FURNACE_WORKBENCH_BLOCK_T2 is also registered in ModBlocks yet has no corresponding registerLargeWorkbench call here. It will render as a purple-black missing-model cube in-game.

Proposed fix
         registerLargeWorkbench(blockStateModelGenerator, ModBlocks.FURNACE_WORKBENCH_BLOCK_T1);
+        registerLargeWorkbench(blockStateModelGenerator, ModBlocks.FURNACE_WORKBENCH_BLOCK_T2);
     }

This will also require the corresponding T2 model JSON files (furnace_workbench_block_t2_bottom_left.json, etc.) to exist in the resources.

🤖 Prompt for AI Agents
In `@src/client/java/com/tcm/MineTale/datagen/ModModelProvider.java` around lines
74 - 76, ModModelProvider is missing a call to register the T2 workbench model:
add a registerLargeWorkbench(blockStateModelGenerator,
ModBlocks.FURNACE_WORKBENCH_BLOCK_T2) invocation (in the same area where
registerLargeWorkbench is used for T1 and WORKBENCH_WORKBENCH_BLOCK) so the
block gets proper models, and ensure the corresponding T2 model JSONs
(furnace_workbench_block_t2_bottom_left.json, etc.) are added to resources;
locate the registerLargeWorkbench usage in ModModelProvider to insert the call.


private void registerLargeWorkbench(BlockModelGenerators generator, Block block) {
// 1. Get the base identifier (e.g., minetale:block/furnace_workbench_block_t1)
Identifier blockId = ModelLocationUtils.getModelLocation(block);

// 2. Build the references to your manual JSON files
// .withSuffix() creates: minetale:block/furnace_workbench_block_t1_bottom_left, etc.
Identifier bottomLeft = blockId.withSuffix("_bottom_left");
Identifier bottomRight = blockId.withSuffix("_bottom_right");
Identifier topLeft = blockId.withSuffix("_top_left");
Identifier topRight = blockId.withSuffix("_top_right");
Identifier inventory = blockId.withSuffix("_inventory");

// 3. Dispatch to Blockstate (Tells the game which model to show for each state)
generator.blockStateOutput.accept(MultiVariantGenerator.dispatch(block)
.with(PropertyDispatch.initial(BlockStateProperties.DOUBLE_BLOCK_HALF, BlockStateProperties.CHEST_TYPE)
.select(DoubleBlockHalf.LOWER, ChestType.LEFT, BlockModelGenerators.plainVariant(bottomLeft))
.select(DoubleBlockHalf.LOWER, ChestType.RIGHT, BlockModelGenerators.plainVariant(bottomRight))
.select(DoubleBlockHalf.UPPER, ChestType.LEFT, BlockModelGenerators.plainVariant(topLeft))
.select(DoubleBlockHalf.UPPER, ChestType.RIGHT, BlockModelGenerators.plainVariant(topRight))
// Support the 'SINGLE' state as a fallback
.select(DoubleBlockHalf.LOWER, ChestType.SINGLE, BlockModelGenerators.plainVariant(bottomLeft))
.select(DoubleBlockHalf.UPPER, ChestType.SINGLE, BlockModelGenerators.plainVariant(topLeft))
)
.with(WORKBENCH_ROTATION)
);

// 4. Map the Item in your hand to the inventory JSON
generator.registerSimpleItemModel(block, inventory);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

/**
Expand Down
Loading