- Fix lint issues

Author: NinjaRocks

src/FeatureOne.File/Extensions/FeatureOneFileExtensions.cs

@@ -26,10 +26,10 @@ public static IServiceCollection AddFeatureOneWithFileStorage(this IServiceColle
                 throw new ArgumentNullException("FileConfiguration is required.");
 
             return services
-                    .AddFeatureOne(provider=>
+                    .AddFeatureOne(provider =>
                     new FileStorageProvider(configuration,
                     new FileReader(configuration),
-                    deserializer?? new ToggleDeserializer(new ConditionDeserializer()),
+                    deserializer ?? new ToggleDeserializer(new ConditionDeserializer()),
                     cache ?? new FeatureCache()));
         }
     }

src/FeatureOne.File/StorageProvider/FileReader.cs

@@ -1,10 +1,10 @@
 using System;
 using System.Collections.Generic;
-using System.Text;
-using System.Threading;
 using System.Security.Cryptography;
+using System.Text;
 using System.Text.Json;
 using System.Text.Json.Nodes;
+using System.Threading;
 
 namespace FeatureOne.File.StorageProvider
 {

src/FeatureOne/Core/Toggles/Conditions/DateRangeCondition.cs

@@ -11,13 +11,13 @@ public class DateRangeCondition : ICondition
         public bool Evaluate(IDictionary<string, string> claims)
         {
             var now = DateTime.Now.Date;  // Use just the date part for comparison
-            
+
             if (StartDate.HasValue && now < StartDate.Value.Date)
                 return false;
-                
+
             if (EndDate.HasValue && now > EndDate.Value.Date)
                 return false;
-                
+
             return true;
         }
     }

src/FeatureOne/DefaultLogger.cs

@@ -11,6 +11,7 @@ public DefaultLogger(ILogger<IFeatureLogger> logger)
         {
             this.logger = logger;
         }
+
         public void Info(string message)
         {
             logger?.LogInformation(message);
@@ -19,7 +20,6 @@ public void Info(string message)
         public void Debug(string message)
         {
             logger?.LogDebug(message);
-
         }
 
         public void Warn(string message)

src/FeatureOne/Extensions/FeatureOneServiceExtensions.cs

@@ -1,6 +1,6 @@
+using System;
 using FeatureOne;
 using FeatureOne.Core.Stores;
-using System;
 using Microsoft.Extensions.Logging;
 
 namespace Microsoft.Extensions.DependencyInjection
@@ -20,13 +20,12 @@ public static IServiceCollection AddFeatureOne(this IServiceCollection services,
         {
             if (storageProviderFactory == null)
                 throw new ArgumentNullException(nameof(storageProviderFactory));
-                     
 
             return services
                 .AddSingleton<IStorageProvider>(provider => storageProviderFactory(provider))
-                .AddSingleton<IFeatureLogger, DefaultLogger>(provider=> new DefaultLogger(provider.GetService<ILogger<IFeatureLogger>>()))
+                .AddSingleton<IFeatureLogger, DefaultLogger>(provider => new DefaultLogger(provider.GetService<ILogger<IFeatureLogger>>()))
                 .AddSingleton<IFeatureStore>(provider => new FeatureStore(provider.GetRequiredService<IStorageProvider>(), provider.GetRequiredService<IFeatureLogger>()))
-                .AddSingleton<IFeatures, Features>(provider => new Features(provider.GetRequiredService<IFeatureStore>(), provider.GetRequiredService<IFeatureLogger>()));              
-        }       
+                .AddSingleton<IFeatures, Features>(provider => new Features(provider.GetRequiredService<IFeatureStore>(), provider.GetRequiredService<IFeatureLogger>()));
+        }
     }
 }

src/FeatureOne/IFeatures.cs

@@ -6,8 +6,11 @@ namespace FeatureOne
     public interface IFeatures
     {
         bool IsEnabled(string name);
+
         bool IsEnabled(string name, ClaimsPrincipal principal);
+
         bool IsEnabled(string name, IDictionary<string, string> claims);
+
         bool IsEnabled(string name, IEnumerable<Claim> claims);
     }
 }

src/FeatureOne/Json/ConditionDeserializer.cs

@@ -41,12 +41,12 @@ public ICondition CreateInstance(NamePostFix conditionName)
             // NamePostFix transforms both "Simple" and "SimpleCondition" to "SimpleCondition"
             // So we look up the processed name
             var processedName = conditionName.Name;
-            
+
             if (SafeConditionTypes.TryGetValue(processedName, out Type type))
             {
                 return (ICondition)Activator.CreateInstance(type, true);
             }
-            
+
             // This shouldn't normally happen with correct inputs since NamePostFix standardizes the format
             throw new Exception($"Could not find a toggle type for: '{processedName}'. Only supported types are: {string.Join(", ", SafeConditionTypes.Keys)}");
         }

src/FeatureOne/Validation/ConfigurationValidator.cs

@@ -33,7 +33,7 @@ public ValidationResult ValidateCondition(ICondition condition)
                 return ValidateRegexCondition(regexCondition);
             else if (condition is DateRangeCondition dateRangeCondition)
                 return ValidateDateRangeCondition(dateRangeCondition);
-            
+
             return new ValidationResult(true, null);
         }
 
@@ -55,7 +55,7 @@ private ValidationResult ValidateRegexCondition(RegexCondition condition)
 
         private ValidationResult ValidateDateRangeCondition(DateRangeCondition condition)
         {
-            if (condition.StartDate.HasValue && condition.EndDate.HasValue && 
+            if (condition.StartDate.HasValue && condition.EndDate.HasValue &&
                 condition.StartDate.Value > condition.EndDate.Value)
                 return new ValidationResult(false, "Start date cannot be after end date");
 
@@ -124,7 +124,7 @@ private bool HasPotentiallyDangerousAlternation(string pattern)
                 // If we can't parse it, be conservative
                 return true;
             }
-            
+
             return false;
         }
 
@@ -137,12 +137,12 @@ private bool HasComplexNestedStructure(string pattern)
 
             for (int i = 0; i < chars.Length; i++)
             {
-                if (chars[i] == '(' && (i == 0 || chars[i-1] != '\\')) // Not escaped
+                if (chars[i] == '(' && (i == 0 || chars[i - 1] != '\\')) // Not escaped
                 {
                     groupDepth++;
                     maxDepth = Math.Max(maxDepth, groupDepth);
                 }
-                else if (chars[i] == ')' && (i == 0 || chars[i-1] != '\\')) // Not escaped
+                else if (chars[i] == ')' && (i == 0 || chars[i - 1] != '\\')) // Not escaped
                 {
                     groupDepth--;
                 }
@@ -167,7 +167,7 @@ private bool HasComplexNestedStructure(string pattern)
         private bool HasSpecificDangerousPatterns(string pattern)
         {
             // Check for specific patterns known to cause ReDoS
-            
+
             // Look for nested quantifiers like ([^...]*.*)+ or (.*[^...]+)*
             if (Regex.IsMatch(pattern, @"\([^+*]*[\*\+][^+*]*\)[\*\+]", RegexOptions.IgnoreCase))
             {

test/FeatureOne.File.Tests/Extensions/FeatureOneFileExtensionsTest.cs

@@ -1,7 +1,7 @@
-using Microsoft.Extensions.DependencyInjection;
-using FeatureOne.File.Extensions;
 using FeatureOne.Cache;
+using FeatureOne.File.Extensions;
 using FeatureOne.Json;
+using Microsoft.Extensions.DependencyInjection;
 using Moq;
 
 namespace FeatureOne.File.Tests.Extensions;
@@ -34,7 +34,7 @@ public void AddFeatureOneWithFileStorage_WithNullConfiguration_ThrowsArgumentNul
         // Act & Assert
         var exception = Assert.Throws<ArgumentNullException>(
             () => services.AddFeatureOneWithFileStorage(configuration));
-        
+
         Assert.That(exception.Message, Does.Contain("FileConfiguration is required."));
     }
 

test/FeatureOne.File.Tests/UnitTests/FileStorageProviderTest.cs

@@ -1,8 +1,8 @@
 using System.Runtime.Caching;
 using FeatureOne.Cache;
 using FeatureOne.File;
-using FeatureOne.Json;
 using FeatureOne.File.StorageProvider;
+using FeatureOne.Json;
 using Moq;
 
 namespace FeatureOne.SQL.Tests.UnitTests