up

Author: rafiqul4

.github/workflows/k6-load-tests.yml

@@ -3,8 +3,26 @@ name: k6 Load Tests
 on:
   pull_request:
     branches: [main, develop, '**-harden-**']
+    paths:
+      - 'src/app/api/checkout/**'
+      - 'src/app/api/orders/**'
+      - 'src/services/checkout-service.ts'
+      - 'src/services/pricing-service.ts'
+      - 'src/services/export-service.ts'
+      - 'src/services/payment-service.ts'
+      - 'tests/performance/**'
+      - '.github/workflows/k6-load-tests.yml'
   push:
     branches: ['**-harden-**']
+    paths:
+      - 'src/app/api/checkout/**'
+      - 'src/app/api/orders/**'
+      - 'src/services/checkout-service.ts'
+      - 'src/services/pricing-service.ts'
+      - 'src/services/export-service.ts'
+      - 'src/services/payment-service.ts'
+      - 'tests/performance/**'
+      - '.github/workflows/k6-load-tests.yml'
   workflow_dispatch:
   schedule:
     # Run load tests daily at 2 AM UTC
@@ -65,6 +83,7 @@ jobs:
           sudo apt-get install k6
       
       - name: 🚀 Run k6 Load Test - Checkout
+        id: k6-checkout-run
         run: k6 run tests/performance/checkout-load-test.js
         env:
           K6_OUT: json=checkout-results.json
@@ -80,7 +99,9 @@ jobs:
       - name: ❌ Fail if thresholds breached
         if: failure()
         run: |
-          echo "::error::k6 load test thresholds breached for checkout flow"
+          echo "::error::❌ k6 load test FAILED - Thresholds breached for checkout flow"
+          echo "::error::Thresholds: API p95 < 500ms, Checkout p95 < 650ms, Error rate < 1%, Success rate > 99%"
+          echo "::error::See artifacts for detailed metrics"
           exit 1
 
   k6-export:
@@ -134,6 +155,7 @@ jobs:
           sudo apt-get install k6
       
       - name: 🚀 Run k6 Load Test - Export
+        id: k6-export-run
         run: k6 run tests/performance/orders-export-load-test.js
         env:
           K6_OUT: json=export-results.json
@@ -149,24 +171,28 @@ jobs:
       - name: ❌ Fail if thresholds breached
         if: failure()
         run: |
-          echo "::error::k6 load test thresholds breached for orders export"
+          echo "::error::❌ k6 load test FAILED - Thresholds breached for orders export"
+          echo "::error::Thresholds: Streaming p95 < 5s, Async enqueue p95 < 500ms, Error rate < 2%, Success rate > 98%"
+          echo "::error::See artifacts for detailed metrics"
           exit 1
 
   k6-comment:
     name: Comment PR with k6 Results
     runs-on: ubuntu-latest
     needs: [k6-checkout, k6-export]
-    if: github.event_name == 'pull_request'
+    if: always() && github.event_name == 'pull_request'
 
     steps:
       - name: 📥 Download checkout results
         uses: actions/download-artifact@v4
+        continue-on-error: true
         with:
           name: k6-checkout-results
           path: ./k6-checkout
 
       - name: 📥 Download export results
         uses: actions/download-artifact@v4
+        continue-on-error: true
         with:
           name: k6-export-results
           path: ./k6-export
@@ -177,42 +203,38 @@ jobs:
           script: |
             const fs = require('fs');
             
-            let checkoutResults = {};
-            let exportResults = {};
+            // Check job statuses
+            const checkoutPassed = '${{ needs.k6-checkout.result }}' === 'success';
+            const exportPassed = '${{ needs.k6-export.result }}' === 'success';
             
-            try {
-              const checkoutData = fs.readFileSync('./k6-checkout/checkout-results.json', 'utf8');
-              checkoutResults = JSON.parse(checkoutData.split('\n').filter(line => line.includes('"type":"Point"')).pop() || '{}');
-            } catch (e) {
-              console.log('Could not parse checkout results');
-            }
+            const overallStatus = checkoutPassed && exportPassed ? '✅ PASSED' : '❌ FAILED';
+            const emoji = checkoutPassed && exportPassed ? '✅' : '❌';
             
-            try {
-              const exportData = fs.readFileSync('./k6-export/export-results.json', 'utf8');
-              exportResults = JSON.parse(exportData.split('\n').filter(line => line.includes('"type":"Point"')).pop() || '{}');
-            } catch (e) {
-              console.log('Could not parse export results');
-            }
+            const comment = `## 🚀 k6 Load Test Results - ${overallStatus}
             
-            const comment = `## 🚀 k6 Load Test Results
+            ### Checkout Flow (50 VUs, 2 min) ${checkoutPassed ? '✅' : '❌'}
+            **Thresholds** (Constitution §118-120):
+            - ✓ API Response (p95): < 500ms
+            - ✓ Checkout Complete (p95): < 650ms  
+            - ✓ Error Rate: < 1%
+            - ✓ Success Rate: > 99%
             
-            ### Checkout Flow (50 VUs, 2 min)
-            - **Status**: ${checkoutResults.metric ? '✅ Passed' : '⚠️ See artifacts'}
-            - **Thresholds**:
-              - API Response (p95): < 500ms
-              - Checkout Complete (p95): < 650ms
-              - Error Rate: < 1%
-              - Success Rate: > 99%
+            ${checkoutPassed ? '✅ All thresholds passed' : '❌ **BLOCKING**: Thresholds breached - see artifacts for details'}
             
-            ### Orders Export (20 VUs, 1.5 min)
-            - **Status**: ${exportResults.metric ? '✅ Passed' : '⚠️ See artifacts'}
-            - **Thresholds**:
-              - Streaming Export (p95): < 5s
-              - Async Enqueue (p95): < 500ms
-              - Error Rate: < 2%
-              - Success Rate: > 98%
+            ### Orders Export (20 VUs, 1.5 min) ${exportPassed ? '✅' : '❌'}
+            **Thresholds**:
+            - ✓ Streaming Export (p95): < 5s
+            - ✓ Async Enqueue (p95): < 500ms
+            - ✓ Error Rate: < 2%
+            - ✓ Success Rate: > 98%
             
-            See artifacts for detailed metrics and timings.
+            ${exportPassed ? '✅ All thresholds passed' : '❌ **BLOCKING**: Thresholds breached - see artifacts for details'}
+            
+            ---
+            
+            ${emoji} **${overallStatus}** - ${checkoutPassed && exportPassed ? 'Merge allowed' : '**MERGE BLOCKED** - Fix performance issues before merging'}
+            
+            📊 Download artifacts for detailed metrics and timings.
             `;
             
             github.rest.issues.createComment({

.github/workflows/lighthouse.yml

@@ -3,8 +3,28 @@ name: Lighthouse CI
 on:
   pull_request:
     branches: [main, develop, '**-harden-**']
+    paths:
+      - 'src/app/(storefront)/**'
+      - 'src/app/(dashboard)/**'
+      - 'src/app/api/**'
+      - 'src/components/**'
+      - 'src/app/layout.tsx'
+      - 'src/app/page.tsx'
+      - 'public/**'
+      - 'lighthouserc*.js'
+      - '.github/workflows/lighthouse.yml'
   push:
     branches: ['**-harden-**']
+    paths:
+      - 'src/app/(storefront)/**'
+      - 'src/app/(dashboard)/**'
+      - 'src/app/api/**'
+      - 'src/components/**'
+      - 'src/app/layout.tsx'
+      - 'src/app/page.tsx'
+      - 'public/**'
+      - 'lighthouserc*.js'
+      - '.github/workflows/lighthouse.yml'
   workflow_dispatch:
 
 concurrency:
@@ -53,9 +73,10 @@ jobs:
         run: npx wait-on http://localhost:3000 -t 60000
 
       - name: 💡 Run Lighthouse CI (Desktop)
+        id: lhci-desktop
         run: |
           npm install -g @lhci/cli@0.13.x
-          lhci autorun --config=lighthouserc.js
+          lhci autorun --config=lighthouserc.js || exit 1
         env:
           LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}
 
@@ -66,6 +87,15 @@ jobs:
           name: lighthouse-desktop-results
           path: .lighthouseci
           retention-days: 30
+      
+      - name: ❌ Fail if budgets breached
+        if: failure()
+        run: |
+          echo "::error::❌ Lighthouse CI FAILED (Desktop) - Performance budgets breached"
+          echo "::error::Constitution budgets: LCP < 2.0s, CLS < 0.1, FID < 100ms, TTI < 3.0s"
+          echo "::error::Performance score ≥ 90, Accessibility ≥ 90, Bundle < 200KB"
+          echo "::error::See artifacts for detailed reports"
+          exit 1
 
   lighthouse-mobile:
     name: Lighthouse (Mobile)
@@ -108,9 +138,10 @@ jobs:
         run: npx wait-on http://localhost:3000 -t 60000
 
       - name: 💡 Run Lighthouse CI (Mobile)
+        id: lhci-mobile
         run: |
           npm install -g @lhci/cli@0.13.x
-          lhci autorun --config=lighthouserc.mobile.js
+          lhci autorun --config=lighthouserc.mobile.js || exit 1
         env:
           LHCI_GITHUB_APP_TOKEN: ${{ secrets.LHCI_GITHUB_APP_TOKEN }}
 
@@ -121,22 +152,33 @@ jobs:
           name: lighthouse-mobile-results
           path: .lighthouseci
           retention-days: 30
+      
+      - name: ❌ Fail if budgets breached
+        if: failure()
+        run: |
+          echo "::error::❌ Lighthouse CI FAILED (Mobile) - Performance budgets breached"
+          echo "::error::Constitution budgets: LCP < 2.5s, CLS < 0.1, FID < 100ms, TTI < 3.0s"
+          echo "::error::Performance score ≥ 90, Accessibility ≥ 90, Bundle < 200KB"
+          echo "::error::See artifacts for detailed reports"
+          exit 1
 
   lighthouse-comment:
     name: Comment PR with Lighthouse Results
     runs-on: ubuntu-latest
     needs: [lighthouse-desktop, lighthouse-mobile]
-    if: github.event_name == 'pull_request'
+    if: always() && github.event_name == 'pull_request'
 
     steps:
       - name: 📥 Download desktop results
         uses: actions/download-artifact@v4
+        continue-on-error: true
         with:
           name: lighthouse-desktop-results
           path: ./lighthouse-desktop
 
       - name: 📥 Download mobile results
         uses: actions/download-artifact@v4
+        continue-on-error: true
         with:
           name: lighthouse-mobile-results
           path: ./lighthouse-mobile
@@ -147,26 +189,48 @@ jobs:
           script: |
             const fs = require('fs');
             
-            // Read results (simplified - actual implementation would parse JSON)
-            const desktopPassed = fs.existsSync('./lighthouse-desktop');
-            const mobilePassed = fs.existsSync('./lighthouse-mobile');
+            // Check job statuses
+            const desktopPassed = '${{ needs.lighthouse-desktop.result }}' === 'success';
+            const mobilePassed = '${{ needs.lighthouse-mobile.result }}' === 'success';
+            
+            const overallStatus = desktopPassed && mobilePassed ? '✅ PASSED' : '❌ FAILED';
+            const emoji = desktopPassed && mobilePassed ? '✅' : '❌';
+            
+            const comment = `## 💡 Lighthouse CI Results - ${overallStatus}
+            
+            ### Desktop ${desktopPassed ? '✅' : '❌'}
+            **Performance Budgets** (Constitution §128-134):
+            - ✓ LCP (Largest Contentful Paint): < 2.0s
+            - ✓ FID (First Input Delay): < 100ms
+            - ✓ CLS (Cumulative Layout Shift): < 0.1
+            - ✓ TTI (Time to Interactive): < 3.0s
+            - ✓ TBT (Total Blocking Time): < 300ms
+            - ✓ JavaScript Bundle: < 200KB (gzipped)
+            - ✓ Performance Score: ≥ 90
+            - ✓ Accessibility Score: ≥ 90
+            
+            ${desktopPassed ? '✅ All budgets passed' : '❌ **BLOCKING**: Budgets breached - see artifacts for details'}
+            
+            ### Mobile ${mobilePassed ? '✅' : '❌'}
+            **Performance Budgets**:
+            - ✓ LCP (Largest Contentful Paint): < 2.5s
+            - ✓ FID (First Input Delay): < 100ms
+            - ✓ CLS (Cumulative Layout Shift): < 0.1
+            - ✓ TTI (Time to Interactive): < 3.0s
+            - ✓ TBT (Total Blocking Time): < 300ms
+            - ✓ JavaScript Bundle: < 200KB (gzipped)
+            - ✓ Performance Score: ≥ 90
+            - ✓ Accessibility Score: ≥ 90
             
-            const comment = `## 💡 Lighthouse CI Results
+            ${mobilePassed ? '✅ All budgets passed' : '❌ **BLOCKING**: Budgets breached - see artifacts for details'}
             
-            ### Desktop
-            ${desktopPassed ? '✅ Passed' : '❌ Failed'}
+            ---
             
-            ### Mobile
-            ${mobilePassed ? '✅ Passed' : '❌ Failed'}
+            ${emoji} **${overallStatus}** - ${desktopPassed && mobilePassed ? 'Merge allowed' : '**MERGE BLOCKED** - Fix performance/accessibility issues before merging'}
             
-            **Performance Budgets:**
-            - LCP < 2.0s (desktop), < 2.5s (mobile)
-            - FID < 100ms
-            - CLS < 0.1
-            - TTI < 3.0s
-            - JS Bundle < 200KB (gzipped)
+            📊 Download artifacts for detailed Lighthouse reports.
             
-            See artifacts for detailed reports.
+            **Constitution Reference**: Performance requirements in §118-134, §177-195
             `;
             
             github.rest.issues.createComment({