Improve type safety and test robustness

Refactored several tests and code to use more explicit type assertions and safer environment variable handling. Updated order creation in payment validator tests to use address IDs instead of connect objects. Improved audit log type safety and clarified export permissions for STAFF users in order export tests.

Author: rafiqul4

src/app/shop/orders/[id]/confirmation/page.tsx

@@ -124,9 +124,9 @@ export default async function OrderConfirmationPage({ params }: OrderConfirmatio
                 {order.items.map((item) => (
                   <Flex key={item.id} align="center" gap="4" style={{ paddingBottom: '16px', borderBottom: '1px solid var(--gray-6)' }}>
                     <div className="w-16 h-16 bg-gray-200 rounded-md flex-shrink-0 relative">
-                      {item.product?.images?.[0] ? (
+                      {(item.product?.images as string[] | null)?.[0] ? (
                         <Image
-                          src={(item.product.images as string[])[0]}
+                          src={(item.product!.images as string[])[0]}
                           alt={item.productName}
                           fill
                           className="object-cover rounded-md"

src/lib/audit.ts

@@ -348,7 +348,7 @@ export async function getResourceAuditLogs(
       id: log.id,
       userId: log.userId,
       action: log.action,
-      changes: log.changes,
+      changes: log.changes as string | null,
       ipAddress: log.ipAddress,
       createdAt: log.createdAt,
     })),

tests/e2e/auth/login-errors.spec.ts

@@ -87,7 +87,7 @@ test.describe('Login Errors', () => {
       expect(auditLog?.action).toBe('LOGIN_FAILED');
 
       // Parse changes JSON to verify it contains the expected data
-      const changes = auditLog?.changes ? JSON.parse(auditLog.changes) : null;
+      const changes = auditLog?.changes ? JSON.parse(auditLog.changes as string) : null;
       expect(changes).toMatchObject({
         email: user.email,
         reason: expect.stringMatching(/password|credentials/i),

tests/e2e/auth/login.spec.ts

@@ -76,7 +76,7 @@ test.describe('User Login', () => {
       expect(auditLog?.action).toBe('LOGIN');
 
       // Parse changes JSON to verify it contains the expected data
-      const changes = auditLog?.changes ? JSON.parse(auditLog.changes) : null;
+      const changes = auditLog?.changes ? JSON.parse(auditLog.changes as string) : null;
       expect(changes).toMatchObject({
         email: admin.email,
         role: 'SUPER_ADMIN',

tests/integration/auth/test/route.spec.ts

@@ -66,7 +66,7 @@ describe('GET /api/auth/test', () => {
 
       process.env.NEXTAUTH_SECRET = 'test-secret';
       process.env.NEXTAUTH_URL = 'http://localhost:3000';
-      process.env.NODE_ENV = 'test';
+      Object.defineProperty(process.env, 'NODE_ENV', { value: 'test', writable: true, configurable: true });
 
       const response = await GET();
 
@@ -81,7 +81,7 @@ describe('GET /api/auth/test', () => {
       // Restore original env vars
       process.env.NEXTAUTH_SECRET = originalSecret;
       process.env.NEXTAUTH_URL = originalUrl;
-      process.env.NODE_ENV = originalNodeEnv;
+      Object.defineProperty(process.env, 'NODE_ENV', { value: originalNodeEnv, writable: true, configurable: true });
     });
 
     it('should detect missing environment variables', async () => {

tests/integration/orders/export/route.spec.ts

@@ -64,7 +64,7 @@ describe('GET /api/orders/export', () => {
       const originalHandler = createApiHandler;
 
       vi.mocked(createApiHandler).mockImplementation((_middlewares, handler) => {
-        return async (request, context) => {
+        return async (request, context: any) => {
           context = context || {};
           context.session = {
             user: { id: 'user-1', email: 'user@example.com', role: 'CUSTOMER' },
@@ -90,7 +90,7 @@ describe('GET /api/orders/export', () => {
       const originalHandler = createApiHandler;
 
       vi.mocked(createApiHandler).mockImplementation((_middlewares, handler) => {
-        return async (request, context) => {
+        return async (request, context: any) => {
           context = context || {};
           context.session = {
             user: { id: 'admin-1', email: 'admin@example.com', role: 'SUPER_ADMIN' },
@@ -122,12 +122,12 @@ describe('GET /api/orders/export', () => {
       vi.mocked(createApiHandler).mockImplementation(originalHandler as any);
     });
 
-    it('should return 403 for non-super-admin without storeId', async () => {
+    it('should allow STAFF to export store orders', async () => {
       const { createApiHandler } = await import('@/lib/api-middleware');
       const originalHandler = createApiHandler;
 
       vi.mocked(createApiHandler).mockImplementation((_middlewares, handler) => {
-        return async (request, context) => {
+        return async (request, context: any) => {
           context = context || {};
           context.session = {
             user: { id: 'staff-1', email: 'staff@example.com', role: 'STAFF' },

tests/integration/payments/payment-validator-robustness.test.ts

@@ -130,8 +130,8 @@ describe('Payment Validator Provider Outage Resilience (T041)', () => {
           shippingAmount: 0,
           discountAmount: 0,
           totalAmount: 5000,
-          shippingAddress: { connect: { id: shippingAddr.id } },
-          billingAddress: { connect: { id: billingAddr.id } },
+          shippingAddressId: shippingAddr.id,
+          billingAddressId: billingAddr.id,
         },
       });
 
@@ -212,8 +212,8 @@ describe('Payment Validator Provider Outage Resilience (T041)', () => {
           shippingAmount: 0,
           discountAmount: 0,
           totalAmount: 15000,
-          shippingAddress: { connect: { id: otherShippingAddr.id } },
-          billingAddress: { connect: { id: otherBillingAddr.id } },
+          shippingAddressId: otherShippingAddr.id,
+          billingAddressId: otherBillingAddr.id,
         },
       });
 
@@ -360,15 +360,15 @@ describe('Payment Validator Provider Outage Resilience (T041)', () => {
         data: {
           storeId,
           userId,
-          orderNumber: 'ORD-FULL-FLOW',
+          orderNumber: 'ORD-CHECKOUT',
           status: 'PENDING',
           subtotal: 12000,
           taxAmount: 0,
           shippingAmount: 0,
           discountAmount: 0,
           totalAmount: 12000,
-          shippingAddress: { connect: { id: checkoutShippingAddr.id } },
-          billingAddress: { connect: { id: checkoutBillingAddr.id } },
+          shippingAddressId: checkoutShippingAddr.id,
+          billingAddressId: checkoutBillingAddr.id,
         },
       });
 

tests/unit/lib/job-queue-stub.test.ts

@@ -200,12 +200,12 @@ describe('JobQueueStub', () => {
 
     it('should auto-start in development mode', () => {
       const originalEnv = process.env.NODE_ENV;
-      process.env.NODE_ENV = 'development';
+      Object.defineProperty(process.env, 'NODE_ENV', { value: 'development', writable: true, configurable: true });
 
       const devQueue = new JobQueueStub();
       expect(devQueue).toBeDefined(); // Auto-started
 
-      process.env.NODE_ENV = originalEnv;
+      Object.defineProperty(process.env, 'NODE_ENV', { value: originalEnv, writable: true, configurable: true });
     });
   });
 

tests/visual/percy.spec.ts

@@ -40,7 +40,7 @@ import percySnapshot from '@percy/playwright';
  */
 
 const BASE_URL = process.env.BASE_URL || 'http://localhost:3000';
-  const _TEST_STORE_SUBDOMAIN = 'test-store';/**
+/**
  * Percy snapshot options
  * - widths: Defined in .percy.yml (375px, 768px, 1280px)
  * - minHeight: Defined in .percy.yml (1024px)