Fix TypeScript errors and update email/order logic

Resolved multiple TypeScript errors across API routes, services, and email templates. Fixed Prisma model mismatches in E2E tests, added explicit types to transaction callbacks, updated email service and templates to use simplified data structures, and improved audit logging. Also removed unused imports and variables, and updated analytics dashboard types.

Author: rafiqul4

TYPESCRIPT_ERRORS_FIX_SUMMARY.md

@@ -0,0 +1,339 @@
+# TypeScript Errors Fix Summary
+
+## Completed Fixes ✅
+
+### 1. Shop Layout Headers (FIXED)
+- **File**: `src/app/shop/layout.tsx`
+- **Issue**: `headers()` returns Promise in Next.js 16
+- **Fix**: Added `await` to `headers()` call
+- **Status**: ✅ COMPLETE
+
+### 2. Email Template Duplicate Attributes (FIXED)
+- **Files**: 
+  - `src/emails/account-verification.tsx`
+  - `src/emails/password-reset.tsx`
+- **Issue**: JSX elements had duplicate `style` attributes
+- **Fix**: Merged styles using spread operator
+- **Status**: ✅ COMPLETE
+
+### 3. Store Service PrismaClient Types (FIXED)
+- **File**: `src/services/store-service.ts`
+- **Issue**: Transaction callback parameter had implicit `any` type
+- **Fix**: Added explicit `Omit<PrismaClient, '$connect' | '$disconnect' | '$on' | '$transaction' | '$use' | '$extends'>` type to all 5 transaction callbacks
+- **Status**: ✅ COMPLETE
+
+### 4. Subscriptions API Route (FIXED)
+- **File**: `src/app/api/subscriptions/route.ts`
+- **Issue**: `plan` property not in `createSubscriptionCheckoutSession` parameters
+- **Fix**: 
+  - Imported `SUBSCRIPTION_PLANS` from subscription-service
+  - Converted `plan` enum to `stripePriceId`
+  - Removed `plan` from function call
+- **Status**: ✅ COMPLETE
+
+### 5. Analytics Components (FIXED)
+- **File**: `src/components/analytics/analytics-dashboard.tsx`
+- **Issues**:
+  - Wrong import name `CustomerMetricsData` (should be `CustomerMetrics`)
+  - Missing type definitions
+- **Fix**:
+  - Fixed imports to actual component names
+  - Added missing type definitions for `MetricsData`, `RevenueData`, `TopProduct`, `CustomerMetricsData`
+- **Status**: ✅ COMPLETE
+
+### 6. Top Products Percent Type (FIXED)
+- **File**: `src/components/analytics/top-products.tsx`
+- **Issue**: `percent` parameter had unknown type
+- **Fix**: Added explicit type `{ name: string; percent: number }`
+- **Status**: ✅ COMPLETE
+
+### 7. E2E Test Prisma Schema Mismatches (FIXED)
+- **File**: `tests/e2e/emails/order-confirmation.spec.ts`
+- **Issues**: 16 errors from incorrect Prisma model field names
+- **Fixes**:
+  - Removed non-existent `Store.domain` field
+  - Removed non-existent `Product.stock` and `Product.status` fields
+  - Added required Product fields: `sku`, `images`, `metaKeywords`
+  - Created Address records separately with `firstName/lastName/address1/address2`
+  - Connected addresses via `shippingAddressId/billingAddressId` foreign keys
+  - Fixed OrderItem to use `price/subtotal/totalAmount` (not `unitPrice/totalPrice`)
+  - Added required `sku` field to OrderItem
+  - Fixed all 5 test cases (T181-1 through T181-5)
+- **Status**: ✅ COMPLETE
+
+---
+
+## Remaining Issues ⚠️
+
+### Critical Errors (Block Compilation)
+
+#### 1. Missing Analytics API Routes
+**Count**: 25+ errors across multiple test files
+**Affected Files**:
+- `tests/unit/app/api/analytics-api.test.ts`
+- `tests/unit/app/api/analytics-routes.test.ts`
+
+**Issue**: Test files import non-existent API routes:
+- `@/app/api/analytics/sales/route`
+- `@/app/api/analytics/revenue/route`
+- `@/app/api/analytics/customers/route`
+- `@/app/api/analytics/products/route`
+
+**Fix Required**: Either:
+1. Create the missing API route files in `src/app/api/analytics/`
+2. OR update tests to skip/mock these routes
+
+**Priority**: HIGH
+
+---
+
+#### 2. E2E Test Prisma Schema Mismatches (FIXED ✅)
+**Count**: 16 errors in `tests/e2e/emails/order-confirmation.spec.ts`
+
+**Issues Fixed**:
+- ✅ `Store.domain` doesn't exist in schema (removed)
+- ✅ `Product.stock` doesn't exist (removed)
+- ✅ `Product.status` doesn't exist (removed)
+- ✅ `Product` missing required fields (added `sku`, `images`, `metaKeywords`)
+- ✅ Address uses `line1/line2` (changed to `address1/address2`)
+- ✅ Address missing required fields (added `firstName`, `lastName`)
+- ✅ OrderItem uses `unitPrice/totalPrice` (changed to `price/subtotal/totalAmount`)
+- ✅ OrderItem missing required `sku` field (added)
+
+**Fixes Applied**:
+1. Removed `domain` from Store creation
+2. Removed `stock` and `status` from Product creation
+3. Added required Product fields: `sku`, `images`, `metaKeywords`
+4. Created separate Address records with `firstName/lastName/address1/address2`
+5. Connected addresses via `shippingAddressId/billingAddressId` foreign keys
+6. Fixed OrderItem to use `price/subtotal/totalAmount` and added `sku`
+7. Fixed all 5 test cases in the file
+
+**Example Fix Applied**:
+```typescript
+// Create addresses first
+const shippingAddress = await prisma.address.create({
+  data: {
+    firstName: 'John',     // REQUIRED
+    lastName: 'Doe',       // REQUIRED
+    address1: '123 Main St', // NOT line1
+    city: 'New York',
+    state: 'NY',
+    postalCode: '10001',
+    country: 'US',
+  },
+});
+
+// Then create order with address IDs
+const order = await prisma.order.create({
+  data: {
+    shippingAddressId: shippingAddress.id, // Connect via ID
+    items: {
+      create: [{
+        price: 1299.99, // NOT unitPrice
+        totalAmount: 1299.99, // NOT totalPrice
+      }]
+    }
+  }
+});
+```
+
+**Priority**: HIGH
+
+---
+
+#### 3. Subscription Test Type Mismatches
+**Count**: 7 errors across subscription test files
+
+**Affected Files**:
+- `tests/unit/app/api/subscription/checkout/route.test.ts`
+- `tests/unit/app/api/subscription/portal/route.test.ts`
+- `tests/unit/app/api/subscription/webhook/route.test.ts`
+
+**Issues**:
+- Mock objects don't match full `Stripe.Checkout.Session` type
+- Mock objects don't match full `Stripe.BillingPortal.Session` type
+- Webhook response expects `{ received: boolean }` not `{ success: boolean }`
+
+**Fix Required**:
+1. Create proper Stripe session mocks with all required properties
+2. Update webhook tests to return `{ received: boolean }`
+
+**Priority**: MEDIUM
+
+---
+
+#### 4. Missing Service/Utility Modules
+**Count**: 20+ import errors
+
+**Missing Files**:
+- ❌ `@/hooks/use-toast` (theme-editor.tsx)
+- ❌ `@/hooks/use-plan-enforcement` (use-plan-enforcement.test.ts)
+- ❌ `@/hooks/use-analytics` (analytics-hooks.test.ts)
+- ❌ `@/lib/auth-helpers` (multiple test files)
+- ❌ `@/lib/format-utils` (analytics-hooks.test.ts)
+- ❌ `@/lib/analytics-utils` (analytics-hooks.test.ts)
+- ❌ `@/lib/chart-utils` (analytics-hooks.test.ts)
+- ❌ `@/lib/date-utils` (analytics-hooks.test.ts)
+- ❌ `@/lib/performance-utils` (analytics-hooks.test.ts)
+- ❌ `@/lib/error-utils` (analytics-hooks.test.ts)
+- ❌ `@/components/analytics/metrics-cards` (test file)
+- ❌ `@/components/analytics/revenue-chart` (test file)
+- ❌ `@/components/analytics/top-products-table` (test file)
+- ❌ `@/components/analytics/customer-metrics` (test file)
+
+**Fix Required**:
+1. Create missing utility modules with proper exports
+2. OR update imports to existing modules
+3. OR skip tests that depend on non-existent modules
+
+**Priority**: MEDIUM
+
+---
+
+#### 5. Plan Enforcement Export Issues
+**Count**: 4 errors in `tests/unit/lib/plan-enforcement.test.ts`
+
+**Issues**:
+- Test imports `withPlanLimits`, `enforcePlanLimits`, `checkProductCreationLimit`, `checkOrderCreationLimit`
+- But `@/lib/plan-enforcement` doesn't export these (or exports them differently)
+
+**Fix Required**:
+Check actual exports from `src/lib/plan-enforcement.ts` and update test imports
+
+**Priority**: LOW
+
+---
+
+#### 6. SessionData Type Mismatches
+**Count**: 3 errors in analytics-api.test.ts
+
+**Issue**: Mock SessionData objects missing required properties:
+- Missing: `email`, `createdAt`, `lastAccessedAt`
+
+**Fix**: Add missing properties to test mocks:
+```typescript
+const mockSession: SessionData = {
+  id: 'test-session',
+  userId: 'test-user',
+  storeId: 'test-store',
+  role: 'STORE_ADMIN',
+  email: 'test@example.com', // Add
+  createdAt: new Date(), // Add
+  lastAccessedAt: new Date(), // Add
+  expiresAt: new Date(Date.now() + 3600000),
+};
+```
+
+**Priority**: LOW
+
+---
+
+#### 7. Analytics Service Test Mock Issues
+**Count**: 30+ errors in `tests/unit/services/analytics-service.test.ts`
+
+**Issue**: Test uses `.mockResolvedValue()` and `.mockResolvedValueOnce()` on Prisma methods, but TypeScript doesn't recognize these (Prisma types don't have Jest mock methods)
+
+**Fix Required**:
+Update test mocking strategy - use `vi.mocked()` from Vitest or proper Prisma mocking library
+
+**Priority**: LOW
+
+---
+
+#### 8. Email Service Test Type Issues
+**Count**: 8 errors in `tests/unit/services/email-service.test.ts`
+
+**Issues**:
+- Cannot assign to `process.env.NODE_ENV` (read-only)
+- Mock User/Store objects missing required Prisma type properties
+
+**Fix**:
+1. Use test environment variables instead of reassigning NODE_ENV
+2. Create proper test fixtures with all required Prisma model properties
+
+**Priority**: LOW
+
+---
+
+### Warnings (Non-Blocking) ⚠️
+
+#### Unused Imports/Variables
+**Count**: 20+ warnings across multiple files
+
+**Examples**:
+- `React` imported but never used
+- `Link` imported but never used
+- `SessionService` imported but never used
+- `isLoading`, `storeEmail`, `receiver`, etc. declared but not used
+
+**Fix**: Remove all unused imports and variables
+
+**Priority**: LOW (cleanup)
+
+---
+
+## Recommended Fix Order
+
+1. **Phase 1: Critical Compilation Blockers**
+   - Fix E2E test Prisma schema mismatches (12 errors)
+   - Create missing analytics API routes OR update tests (25+ errors)
+
+2. **Phase 2: Service/Utility Modules**
+   - Create missing utility modules (20+ errors)
+   - Fix plan-enforcement exports (4 errors)
+
+3. **Phase 3: Test Mocking Issues**
+   - Fix Stripe session type mismatches (7 errors)
+   - Fix SessionData in tests (3 errors)
+   - Fix analytics-service.test.ts mocks (30+ errors)
+   - Fix email-service.test.ts types (8 errors)
+
+4. **Phase 4: Cleanup**
+   - Remove all unused imports/variables (20+ warnings)
+
+---
+
+## Statistics
+
+**Total Errors Found**: 146
+**Total Errors Fixed**: 24 errors across 8 files ✅
+**Total Errors Remaining**: 122
+
+**Fixed Breakdown**:
+- Shop layout headers: 1 error
+- Email template duplicates: 2 errors
+- Store service types: 5 errors
+- Subscriptions API: 1 error
+- Analytics components: 3 errors
+- Top-products type: 1 error
+- E2E test Prisma schema: 16 errors
+
+**Remaining Breakdown**:
+- **Critical (Severity 8)**: ~96 errors
+- **Warnings (Severity 4)**: ~26 unused declarations
+
+**Files Affected**: 25+ files
+- Production code: 8 files (6 FIXED ✅)
+- Test files: 17+ files (1 FIXED ✅)
+
+**Progress**: 16.4% complete (24 of 146 errors fixed)
+
+---
+
+## Next Steps
+
+To complete the fixes, run:
+```bash
+# Check specific file errors
+npx tsc --noEmit <file-path>
+
+# Fix E2E tests first (highest priority)
+npx tsc --noEmit tests/e2e/emails/order-confirmation.spec.ts
+
+# Then fix test infrastructure
+npm run test -- --run
+
+# Finally cleanup warnings
+npm run lint -- --fix
+```