defer Closure evaluation for append() and prepend()#213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
prepend()andappend()methods evaluate aClosurepassed to them as soon as it is given.This creates issues when we want to inject utilities such as
$livewirein theClosure- it will throw anExceptionalong the lines of "$container must not be accessed before initialization".With this PR, two new methods are added:
getAppendedItems(), which evaluates$this->appendand performs the checks on the value that were moved fromappend()getPrependedItems(), which evaluates$this->prependand performs the checks on the value that were moved fromprepend()Then, in
getTree(), we wrap$this->appendand$this->prependin afilled()call, so that thewhen()does not evaluate theClosureprematurely, and we use the two new methods to retrieve the appended/prepended values, with checks, only if they need to be added to the tree.I have another change lined up that depends on this deferral of the
Closureevaluation to handle multiple appended/prepended values, but I chose to separate the two since this is more of a bugfix while the other is an enhancement.