Skip to content

Commit feba2bc

Browse files
committed
UI: Use new NVENC encoder ids
1 parent 6e435db commit feba2bc

3 files changed

Lines changed: 13 additions & 10 deletions

File tree

UI/window-basic-main-outputs.cpp

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -609,15 +609,17 @@ const char *get_simple_output_encoder(const char *encoder)
609609
} else if (strcmp(encoder, SIMPLE_ENCODER_AMD_AV1) == 0) {
610610
return "av1_texture_amf";
611611
} else if (strcmp(encoder, SIMPLE_ENCODER_NVENC) == 0) {
612-
return EncoderAvailable("jim_nvenc") ? "jim_nvenc"
613-
: "ffmpeg_nvenc";
612+
return EncoderAvailable("obs_nvenc_h264_tex")
613+
? "obs_nvenc_h264_tex"
614+
: "ffmpeg_nvenc";
614615
#ifdef ENABLE_HEVC
615616
} else if (strcmp(encoder, SIMPLE_ENCODER_NVENC_HEVC) == 0) {
616-
return EncoderAvailable("jim_hevc_nvenc") ? "jim_hevc_nvenc"
617-
: "ffmpeg_hevc_nvenc";
617+
return EncoderAvailable("obs_nvenc_hevc_tex")
618+
? "obs_nvenc_hevc_tex"
619+
: "ffmpeg_hevc_nvenc";
618620
#endif
619621
} else if (strcmp(encoder, SIMPLE_ENCODER_NVENC_AV1) == 0) {
620-
return "jim_av1_nvenc";
622+
return "obs_nvenc_av1_tex";
621623
} else if (strcmp(encoder, SIMPLE_ENCODER_APPLE_H264) == 0) {
622624
return "com.apple.videotoolbox.videoencoder.ave.avc";
623625
#ifdef ENABLE_HEVC
@@ -1848,7 +1850,7 @@ void AdvancedOutput::UpdateStreamSettings()
18481850
blog(LOG_WARNING, "User is ignoring service settings.");
18491851
}
18501852

1851-
if (dynBitrate && astrcmpi(streamEncoder, "jim_nvenc") == 0)
1853+
if (dynBitrate && strstr(streamEncoder, "nvenc") != nullptr)
18521854
obs_data_set_bool(settings, "lookahead", false);
18531855

18541856
video_t *video = obs_get_video();

UI/window-basic-settings-stream.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1606,8 +1606,9 @@ bool OBSBasicSettings::ServiceAndACodecCompatible()
16061606
/* we really need a way to find fallbacks in a less hardcoded way. maybe. */
16071607
static QString get_adv_fallback(const QString &enc)
16081608
{
1609-
if (enc == "jim_hevc_nvenc" || enc == "jim_av1_nvenc")
1610-
return "jim_nvenc";
1609+
if (enc == "obs_nvenc_hevc_tex" || enc == "obs_nvenc_av1_tex" ||
1610+
enc == "jim_hevc_nvenc" || enc == "jim_av1_nvenc")
1611+
return "obs_nvenc_h264_tex";
16111612
if (enc == "h265_texture_amf" || enc == "av1_texture_amf")
16121613
return "h264_texture_amf";
16131614
if (enc == "com.apple.videotoolbox.videoencoder.ave.hevc")
@@ -1863,7 +1864,7 @@ void OBSBasicSettings::ResetEncoders(bool streamOnly)
18631864
ui->simpleOutStrEncoder->addItem(
18641865
ENCODER_STR("Hardware.NVENC.H264"),
18651866
QString(SIMPLE_ENCODER_NVENC));
1866-
if (service_supports_encoder(vcodecs, "jim_av1_nvenc"))
1867+
if (service_supports_encoder(vcodecs, "obs_nvenc_av1_tex"))
18671868
ui->simpleOutStrEncoder->addItem(
18681869
ENCODER_STR("Hardware.NVENC.AV1"),
18691870
QString(SIMPLE_ENCODER_NVENC_AV1));

UI/window-basic-settings.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5354,7 +5354,7 @@ void OBSBasicSettings::FillSimpleRecordingValues()
53545354
ui->simpleOutRecEncoder->addItem(
53555355
ENCODER_STR("Hardware.NVENC.H264"),
53565356
QString(SIMPLE_ENCODER_NVENC));
5357-
if (EncoderAvailable("jim_av1_nvenc"))
5357+
if (EncoderAvailable("obs_nvenc_av1_tex"))
53585358
ui->simpleOutRecEncoder->addItem(
53595359
ENCODER_STR("Hardware.NVENC.AV1"),
53605360
QString(SIMPLE_ENCODER_NVENC_AV1));

0 commit comments

Comments
 (0)