Fix median and improve implement tests

Author: MouawiaElkhalifa

Sprint-1/fix/median.js

@@ -6,18 +6,26 @@
 // or 'list' has mixed values (the function is expected to sort only numbers).
 
 function calculateMedian(list) {
-  if(!Array.isArray(list)){return null;}
-  const number  = list.filter(n => typeof n === "number");
-  if(number.length  === 0) {return null;}
-  number.sort((a,b) => a-b)
-  const middleIndex = Math.floor(number.length / 2);
+  if (!Array.isArray(list)) {
+    return null;
+  }
 
+  const numbers = list.filter(
+    (item) => typeof item === "number" && Number.isFinite(item)
+  );
 
-  if(number.length%2===0){return (number[middleIndex-1] + number[middleIndex])/2;
+  if (numbers.length === 0) {
+    return null;
   }
-  else return number[middleIndex];
-}
 
+  const sortedNumbers = [...numbers].sort((a, b) => a - b);
+  const middleIndex = Math.floor(sortedNumbers.length / 2);
 
+  if (sortedNumbers.length % 2 === 0) {
+    return (sortedNumbers[middleIndex - 1] + sortedNumbers[middleIndex]) / 2;
+  }
+
+  return sortedNumbers[middleIndex];
+}
 
-module.exports = calculateMedian
+module.exports = calculateMedian;

Sprint-1/implement/dedupe.test.js

@@ -31,6 +31,7 @@ test("given an array with no duplication, it copy of the original array ", () =>
   const currentOutput = dedupe(array);
   const targetOutput = [1, 2, 3];
   expect(currentOutput).toEqual(targetOutput);
+  expect(currentOutput).not.toBe(array);
 });
 // Given an array with strings or numbers
 // When passed to the dedupe function

Sprint-1/implement/max.test.js

@@ -69,6 +69,15 @@ test("given an array with one non-number return the max and ignore non-numeric v
   const targetOutput = 10;
   expect(currentOutput).toEqual(targetOutput);
 });
+// Given an array with numeric string values
+// When passed to the max function
+// Then it should ignore numeric strings and only consider real numbers
+test("ignores numeric strings like '300'", () => {
+  const maxElement = ["300", 10, 20];
+  const currentOutput = findMax(maxElement);
+  const targetOutput = 20;
+  expect(currentOutput).toEqual(targetOutput);
+});
 // Given an array with only non-number values
 // When passed to the max function
 // Then it should return the least surprising value given how it behaves for all other inputs

Sprint-1/implement/sum.test.js

@@ -47,7 +47,7 @@ test("given an array with decimal/float numbers [1.5, -2.4, 4.5], returns the co
   const list = [1.5, -2.4, 4.5];
   const currentOutput = sum(list);
   const targetOutput = 3.6;
-  expect(currentOutput).toEqual(targetOutput);
+  expect(currentOutput).toBeCloseTo(targetOutput);
 });
 
 // Given an array containing non-number values