Address mentor feedback for sprint 1 data groups

Author: Richiealx

Sprint-1/fix/median.js

@@ -11,27 +11,46 @@ function calculateMedian(list) {
     return null;
   }
 
+<<<<<<< HEAD
   // Keep only real numeric values
   const numbersOnly = list.filter(
     (item) => typeof item === "number" && !Number.isNaN(item)
   );
 
   // Return null if the array contains no numbers
+=======
+  // filter() returns a new array, so this does not modify the original input
+  const numbersOnly = list.filter((item) => Number.isFinite(item));
+
+  // Return null if there are no numeric values
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)
   if (numbersOnly.length === 0) {
     return null;
   }
 
+<<<<<<< HEAD
   // Create a sorted copy so the original input is not changed
   const sortedNumbers = [...numbersOnly].sort((a, b) => a - b);
 
   const middleIndex = Math.floor(sortedNumbers.length / 2);
 
   // For an even-length array, median is the average of the two middle values
+=======
+  // Safe to sort directly because numbersOnly is already a new array
+  const sortedNumbers = numbersOnly.sort((a, b) => a - b);
+  const middleIndex = Math.floor(sortedNumbers.length / 2);
+
+  // Even number of values: return the average of the two middle values
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)
   if (sortedNumbers.length % 2 === 0) {
     return (sortedNumbers[middleIndex - 1] + sortedNumbers[middleIndex]) / 2;
   }
 
+<<<<<<< HEAD
   // For an odd-length array, median is the middle value
+=======
+  // Odd number of values: return the middle value
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)
   return sortedNumbers[middleIndex];
 }
 

Sprint-1/implement/dedupe.test.js

@@ -2,7 +2,11 @@ const dedupe = require("./dedupe.js");
 /*
 Dedupe Array
 
+<<<<<<< HEAD
 📖 Dedupe means deduplicate
+=======
+ Dedupe means deduplicate
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)
 
 In this kata, you will need to deduplicate the elements of an array
 
@@ -23,8 +27,17 @@ test("given an empty array, it returns an empty array", () => {
 // Given an array with no duplicates
 // When passed to the dedupe function
 // Then it should return a copy of the original array
+<<<<<<< HEAD
 test("given an array with no duplicates, it returns the same values", () => {
   expect(dedupe([1, 2, 3])).toEqual([1, 2, 3]);
+=======
+test("given an array with no duplicates, it returns a copy of the original array", () => {
+  const input = [1, 2, 3];
+  const result = dedupe(input);
+
+  expect(result).toEqual(input);
+  expect(result).not.toBe(input);
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)
 });
 
 // Given an array with strings or numbers

Sprint-1/implement/max.js

@@ -5,11 +5,16 @@ function findMax(elements) {
   let maxValue = -Infinity;
 
   for (const element of elements) {
+<<<<<<< HEAD
     // Only compare values that are real numbers
     if (typeof element === "number" && !Number.isNaN(element)) {
       if (element > maxValue) {
         maxValue = element;
       }
+=======
+    if (Number.isFinite(element) && element > maxValue) {
+      maxValue = element;
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)
     }
   }
 

Sprint-1/implement/max.test.js

@@ -51,7 +51,11 @@ test("given an array with decimal numbers, returns the largest decimal", () => {
 // When passed to the max function
 // Then it should return the max and ignore non-numeric values
 test("given an array with non-number values, ignores them and returns the max", () => {
+<<<<<<< HEAD
   expect(findMax(["hey", 10, "hi", 60, 10])).toBe(60);
+=======
+  expect(findMax(["hey", 10, "300", "hi", 60, 10])).toBe(60);
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)
 });
 
 // Given an array with only non-number values

Sprint-1/implement/sum.js

@@ -5,8 +5,12 @@ function sum(elements) {
   let total = 0;
 
   for (const element of elements) {
+<<<<<<< HEAD
     // Only add values that are real numbers
     if (typeof element === "number" && !Number.isNaN(element)) {
+=======
+    if (Number.isFinite(element)) {
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)
       total += element;
     }
   }

Sprint-1/implement/sum.test.js

@@ -35,7 +35,11 @@ test("given an array with negative numbers, returns the correct sum", () => {
 // When passed to the sum function
 // Then it should return the correct total sum
 test("given an array with decimal numbers, returns the correct sum", () => {
+<<<<<<< HEAD
   expect(sum([1.5, 2.5, 3])).toBe(7);
+=======
+  expect(sum([1.2, 0.6, 0.005])).toBeCloseTo(1.805, 10);
+>>>>>>> a22ed15 (Address mentor feedback for sprint 1 data groups)
 });
 
 // Given an array containing non-number values