complted sprint-2 coursework

Author: djebsoft

Sprint-2/implement/lookup.js

@@ -1,5 +1,24 @@
-function createLookup(countryCurrencyPairs) {
-  return Object.fromEntries(countryCurrencyPairs);
+// the first element is the country code
+// the second array is the currency code of the country
+// the function should return an object
+// the keys of the object should be the first element of each inner array (country code)
+// the values of the object should be the second element of each inner array (currency code)
+
+function Lookup(coCuPairs) {
+  // check if the argument is an array of arrays
+  if (
+    Array.isArray(coCuPairs) &&
+    // check if each inner array is an array.
+    coCuPairs.every((pair) => Array.isArray(pair)) &&
+    // check if each inner array has two elements.
+    coCuPairs.every((pair) => pair.length === 2)
+    // we can also use index to check the pair is an array as follows:
+    // for (let i = 0; i < coCuPairs.length; i++)
+    //  return Array.isArray(coCuPairs[i])
+  ) {
+    return Object.fromEntries(coCuPairs);
+  }
+  return "Invalid input: expected an array of arrays";
 }
 
-module.exports = createLookup;
+module.exports = Lookup;

Sprint-2/implement/lookup.test.js

@@ -1,6 +1,18 @@
-const createLookup = require("./lookup.js");
+const Lookup = require("./lookup.js");
 
-test.todo("creates a country currency code lookup for multiple codes");
+test("creates a country currency code lookup for multiple codes", () => {
+  const input = [
+    ["DZ", "DZD"],
+    ["CA", "CAD"],
+    ["GB", "GBP"],
+  ];
+  const result = {
+    DZ: "DZD",
+    CA: "CAD",
+    GB: "GBP",
+  };
+  expect(Lookup(input)).toEqual(result);
+});
 
 /*
 
@@ -24,7 +36,7 @@ Example
 Given: [['US', 'USD'], ['CA', 'CAD']]
 
 When
-createLookup(countryCurrencyPairs) is called
+Lookup(coCuPairs) is called
 
 Then
 It should return:
@@ -33,3 +45,29 @@ It should return:
    'CA': 'CAD'
  }
 */
+// Given an invalid input (not an array of arrays),
+test('return "Invalid input: expected an array of arrays" for string input', () => {
+  const input = "invalid input: expected an array of arrays";
+  expect(Lookup(input)).toEqual("Invalid input: expected an array of arrays");
+});
+
+// Given an array where its elements are not arrays,
+test('return "Invalid input: expected an array of arrays" for non-array elements', () => {
+  const input = [["US", "USD"], "CA"];
+  expect(Lookup(input)).toEqual("Invalid input: expected an array of arrays");
+});
+
+// Given an array where its elements are arrays with more than two elements,
+test('return "Invalid input: expected an array of arrays" for arrays with too many elements', () => {
+  const input = [
+    ["US", "USD", "flag"],
+    ["CA", "CAD"],
+  ];
+  expect(Lookup(input)).toEqual("Invalid input: expected an array of arrays");
+});
+
+// Given an array where its elements are arrays with less than two elements,
+test('return "Invalid input: expected an array of arrays" for arrays with too few elements', () => {
+  const input = [["US", "USD"], ["CA"]];
+  expect(Lookup(input)).toEqual("Invalid input: expected an array of arrays");
+});

Sprint-2/implement/querystring.js

@@ -1,13 +1,20 @@
+// the bug in the code is that it does not handle cases where the query string has two = signs or more between two parameters.
+// in this case we make sure to split the string only at the first = sign.
+// so we use the spread operator.
 function parseQueryString(queryString) {
   const queryParams = {};
+  if (queryString === null || queryString === undefined) {
+    return "invalid query string";
+  }
   if (queryString.length === 0) {
     return queryParams;
   }
   const keyValuePairs = queryString.split("&");
 
   for (const pair of keyValuePairs) {
-    const [key, value] = pair.split("=");
-    queryParams[key] = value;
+    const [key, ...value] = pair.split("=");
+    // we convert the value array back to a string and we get back the = signs by using it as separator.
+    queryParams[key] = value.join("=");
   }
 
   return queryParams;

Sprint-2/implement/querystring.test.js

@@ -3,10 +3,85 @@
 // Below is one test case for an edge case the implementation doesn't handle well.
 // Fix the implementation for this test, and try to think of as many other edge cases as possible - write tests and fix those too.
 
-const parseQueryString = require("./querystring.js")
+const parseQueryString = require("./querystring.js");
 
+// testing when the query string with a value contains = signs
 test("parses querystring values containing =", () => {
   expect(parseQueryString("equation=x=y+1")).toEqual({
-    "equation": "x=y+1",
+    equation: "x=y+1",
+  });
+});
+
+// testing when the query string has multiple ampersands
+test("parses query string with multiple parameters", () => {
+  expect(parseQueryString("name=Ben&age=45&city=new%20city")).toEqual({
+    name: "Ben",
+    age: "45",
+    city: "new%20city",
+  });
+});
+
+// testing when the query string has two ampersands in a row
+test("parses query string with two ampersands in a row", () => {
+  expect(parseQueryString("name=Ben&&age=45")).toEqual({
+    name: "Ben",
+    "": "",
+    age: "45",
+  });
+});
+
+// testing when the query string has no ampersands
+test("parses query string with no ampersands", () => {
+  expect(parseQueryString("name=Ben")).toEqual({
+    name: "Ben",
+  });
+});
+
+// testing when the query string has no ampersands and no equal signs
+test("parses query string with no ampersands and no equal signs", () => {
+  expect(parseQueryString("name")).toEqual({
+    name: "",
+  });
+});
+
+// testing when the query string is empty
+test("parses query string with empty value", () => {
+  expect(parseQueryString("")).toEqual({});
+});
+
+// testing when the query string is null
+test("parses query string with null value", () => {
+  expect(parseQueryString(null)).toEqual("invalid query string");
+});
+
+// testing when the query string is undefined
+test("parses query string with undefined value", () => {
+  expect(parseQueryString(undefined)).toEqual("invalid query string");
+});
+
+// testing when a pair ends with equal sign (no value)
+test("parses query string with no equal sign", () => {
+  expect(parseQueryString("name=Ben&age=&city=")).toEqual({
+    name: "Ben",
+    age: "",
+    city: "",
+  });
+});
+
+// testing when a pair starts with equal sign (no key)
+test("parses query string starting with equal sign", () => {
+  expect(parseQueryString("name=Ben&=45")).toEqual({
+    name: "Ben",
+    "": "45",
+  });
+});
+
+// testing when a pair has no equal sign (no value and no key)
+// the pair will be the key and the value will be an empty string
+test("parses query string with no equal sign", () => {
+  expect(parseQueryString("name&age=45&city")).toEqual({
+    name: "",
+    age: "45",
+    city: "",
   });
 });

Sprint-2/implement/tally.js

@@ -1,3 +1,12 @@
-function tally() {}
-
+function tally(arr) {
+  if (!Array.isArray(arr)) {
+    throw new Error("invalid input");
+  }
+  let result = {};
+  for (let i = 0; i <= arr.length - 1; i++) {
+    let item = arr[i];
+    result[item] = (result[item] || 0) + 1;
+  }
+  return result;
+}
 module.exports = tally;

Sprint-2/implement/tally.test.js

@@ -23,12 +23,63 @@ const tally = require("./tally.js");
 // Given an empty array
 // When passed to tally
 // Then it should return an empty object
-test.todo("tally on an empty array returns an empty object");
+test("tally on an empty array returns an empty object", () => {
+  expect(tally([])).toEqual({});
+});
 
 // Given an array with duplicate items
 // When passed to tally
 // Then it should return counts for each unique item
+test("tally on an empty array returns an empty object", () => {
+  expect(tally([])).toEqual({});
+});
+
+// Given an array with duplicate items
+// When passed to tally
+// Then it should return counts for each unique item
+test("tally on an array with duplicates returns correct counts for each unique item", () => {
+  expect(
+    tally([
+      "CYF",
+      "CYF",
+      "AWS",
+      "Capgemini",
+      "Deloitte",
+      "Google",
+      "Slack",
+      "Capgemini",
+    ])
+  ).toEqual({ CYF: 2, AWS: 1, Capgemini: 2, Deloitte: 1, Google: 1, Slack: 1 });
+});
 
 // Given an invalid input like a string
 // When passed to tally
 // Then it should throw an error
+test("given invalid input throws an error", () => {
+  expect(() => tally("invalid")).toThrow("invalid input");
+});
+
+// Given an invalid input like a number
+test("given invalid input throws an error", () => {
+  expect(() => tally("invalid")).toThrow("invalid input");
+});
+
+// Given an invalid input like a number
+test("given invalid input throws an error", () => {
+  expect(() => tally(123)).toThrow("invalid input");
+});
+
+// Given an invalid input like an object
+test("given invalid input throws an error", () => {
+  expect(() => tally({})).toThrow("invalid input");
+});
+
+// Given an invalid input like null
+test("given invalid input throws an error", () => {
+  expect(() => tally(null)).toThrow("invalid input");
+});
+
+// Given an invalid input like undefined
+test("given invalid input throws an error", () => {
+  expect(() => tally(undefined)).toThrow("invalid input");
+});

Sprint-2/interpret/invert.js

@@ -8,22 +8,32 @@
 
 function invert(obj) {
   const invertedObj = {};
-
+  if (typeof obj !== "object" || obj === null || Array.isArray(obj))
+    return invertedObj;
   for (const [key, value] of Object.entries(obj)) {
-    invertedObj.key = value;
+    invertedObj[value] = key;
   }
 
   return invertedObj;
 }
 
 // a) What is the current return value when invert is called with { a : 1 }
+// {key: 1}
 
 // b) What is the current return value when invert is called with { a: 1, b: 2 }
+// {key: 2}
 
 // c) What is the target return value when invert is called with {a : 1, b: 2}
+// {"1": "a", "2": "b"}
 
 // c) What does Object.entries return? Why is it needed in this program?
+// it returns an array of the pairs properties [key, value] of the object.
+// it is needed in this program to iterate over the key value pairs of the object to swap them in new object.
 
 // d) Explain why the current return value is different from the target output
+// because first it doesn't swap.
+// second, we're using the dot notation to assign the value where we should user the brackets notation as the key is variable and not a string literal.
 
 // e) Fix the implementation of invert (and write tests to prove it's fixed!)
+
+module.exports = invert;

Sprint-2/interpret/invert.test.js

@@ -0,0 +1,36 @@
+const invert = require("./invert.js");
+// writing some tests.
+// Given an simple ordinary object.
+test("invert on a simple object returns the correct inverted object", () => {
+  expect(invert({ a: 1 })).toEqual({ 1: "a" });
+});
+// Given an object with multiple key value pairs.
+test("invert on an object with multiple key value pairs returns the correct inverted object", () => {
+  expect(invert({ a: 1, b: 2 })).toEqual({ 1: "a", 2: "b" });
+});
+// Given an object with duplicate values.
+test("invert on an object with duplicate values returns the correct inverted object", () => {
+  expect(invert({ a: 1, b: 1 })).toEqual({ 1: "a", 1: "b" });
+});
+// Given an empty object.
+test("invert on an empty object returns an empty object", () => {
+  expect(invert({})).toEqual({});
+});
+// Given an invalid input like a string.
+test("invert on an invalid input like a string returns an empty object", () => {
+  expect(invert("invalid")).toEqual({});
+});
+
+// Given an invalid input like a number.
+test("invert on an invalid input like a number returns an empty object", () => {
+  expect(invert(123)).toEqual({});
+});
+// Given an invalid input like an array.
+test("invert on an invalid input like an array returns an empty object", () => {
+  expect(invert([1, 2, 3])).toEqual({});
+});
+// Given an invalid input like null or undefined.
+test("invert on an invalid input like null or undefined returns an empty object", () => {
+  expect(invert(null)).toEqual({});
+  expect(invert(undefined)).toEqual({});
+});