fixed issues after the feedback 2

Author: MehrozMunir

Sprint-1/fix/median.js

@@ -23,7 +23,6 @@ function calculateMedian(list) {
     median = (sortedArray[middleIndex - 1] + sortedArray[middleIndex]) / 2;
   else median = sortedArray[middleIndex];
 
-  if (median === null) throw new Error("Median can't be null");
   return median;
 }
 

Sprint-1/implement/dedupe.test.js

@@ -16,7 +16,7 @@ describe("dedupe", () => {
   // Then it should return an empty array
   it("given an empty array it should return an empty array", () => {
     const array = [];
-    dedupeArray = dedupe(array);
+    const dedupeArray = dedupe(array);
     expect(dedupeArray).toEqual([]);
   });
 
@@ -51,8 +51,25 @@ describe("dedupe", () => {
   // Given an input value that is not array could be null or undefined or just a number or string
   // When passed to the dedupe function
   // Then it should thrown an error
-  [null, 930, "just a string", undefined, {}].forEach((val) =>
-    it("throw an error if the input is not an array", () =>
-      expect(() => dedupe(val)).toThrow(val + " is not an array"))
-  );
+  test("should thrown an error  if the input is null", () => {
+    expect(() => dedupe(null)).toThrow(null + " is not an array");
+  });
+
+  test("should thrown an error  if the input is a number", () => {
+    const number = 123;
+    expect(() => dedupe(number)).toThrow(number + " is not an array");
+  });
+  test("should thrown an error  if the input is a string", () => {
+    const string = "this is a string";
+    expect(() => dedupe(string)).toThrow(string + " is not an array");
+  });
+
+  test("should thrown an error  if the input is undefined", () => {
+    expect(() => dedupe(undefined)).toThrow(undefined + " is not an array");
+  });
+
+  test("should thrown an error  if the input is an object", () => {
+    const emptyObject = {};
+    expect(() => dedupe(emptyObject)).toThrow(emptyObject + " is not an array");
+  });
 });

Sprint-1/implement/max.js

@@ -1,6 +1,6 @@
 function findMax(array) {
   if (!Array.isArray(array)) throw new Error(array + " is not an array");
-  let numbersArray = array.filter((value) => typeof value === "number");
+  const numbersArray = array.filter((value) => typeof value === "number");
   return Math.max(...numbersArray);
 }
 

Sprint-1/implement/max.test.js

@@ -108,8 +108,28 @@ describe("findMax", () => {
   // Given an input that is not array could be null or undefined or just a number or string
   // When passed to the findMax function
   // Then it should thrown an error
-  [null, 930, "just a string", undefined, {}].forEach((val) =>
-    it("throw an error if the input is not an array", () =>
-      expect(() => findMax(val)).toThrow(val + " is not an array"))
-  );
+
+  test("should thrown an error  if the input is null", () => {
+    expect(() => findMax(null)).toThrow(null + " is not an array");
+  });
+
+  test("should thrown an error  if the input is a number", () => {
+    const number = 980;
+    expect(() => findMax(number)).toThrow(number + " is not an array");
+  });
+  test("should thrown an error  if the input is a string", () => {
+    const string = "just a string";
+    expect(() => findMax(string)).toThrow(string + " is not an array");
+  });
+
+  test("should thrown an error  if the input is undefined", () => {
+    expect(() => findMax(undefined)).toThrow(undefined + " is not an array");
+  });
+
+  test("should thrown an error  if the input is an object", () => {
+    const emptyObject = {};
+    expect(() => findMax(emptyObject)).toThrow(
+      emptyObject + " is not an array"
+    );
+  });
 });

Sprint-1/implement/sum.js

@@ -1,10 +1,9 @@
 function sum(array) {
   if (!Array.isArray(array)) throw new Error(array + " is not an array");
   let numbersArray = array.filter((value) => typeof value === "number");
-  let initialValue = 0;
-  let sum = numbersArray.reduce(
+  const sum = numbersArray.reduce(
     (accumulator, currentValue) => accumulator + currentValue,
-    initialValue
+    0
   );
   return sum;
 }

Sprint-1/implement/sum.test.js

@@ -79,8 +79,25 @@ describe("sum", () => {
   // Given an input value that is not array could be null or undefined or just a number or string
   // When passed to the sum function
   // Then it should thrown an error
-  [null, 930, "just a string", undefined, {}].forEach((val) =>
-    it("throw an error if the input is not an array", () =>
-      expect(() => sum(val)).toThrow(val + " is not an array"))
-  );
+  test("should thrown an error  if the input is null", () => {
+    expect(() => sum(null)).toThrow(null + " is not an array");
+  });
+
+  test("should thrown an error  if the input is a number", () => {
+    const number = 123;
+    expect(() => sum(number)).toThrow(number + " is not an array");
+  });
+  test("should thrown an error  if the input is a string", () => {
+    const string = "this is a string";
+    expect(() => sum(string)).toThrow(string + " is not an array");
+  });
+
+  test("should thrown an error  if the input is undefined", () => {
+    expect(() => sum(undefined)).toThrow(undefined + " is not an array");
+  });
+
+  test("should thrown an error  if the input is an object", () => {
+    const emptyObject = {};
+    expect(() => sum(emptyObject)).toThrow(emptyObject + " is not an array");
+  });
 });