updated the code base on the general feedbacks

Author: HadiVahidi20

Sprint-1/implement/dedupe.test.js

@@ -28,11 +28,20 @@ test("given an empty array, it returns an empty array", () => {
 // Then it should return a copy of the original array
 
 test("Given an array with no duplicates, it returns an the same array", () => {
-    const currentOutput = dedupe([1,4,6,"d","a","x","e",0,7,8]);
+    const input = [1,4,6,"d","a","x","e",0,7,8];
+    const currentOutput = dedupe(input);
     const targetOutput = [1,4,6,"d","a","x","e",0,7,8];
 
     expect(currentOutput).toEqual(targetOutput);
 });
+
+test("The copy must not be the very same array in memory", () => {
+    const input = [3, 1, 2];
+    const currentOutput = dedupe(input);
+
+    expect(currentOutput).toEqual([3, 1, 2]);
+    expect(currentOutput).not.toBe(input); // make sure the function returns a copy
+});
 // Given an array with strings or numbers
 // When passed to the dedupe function
 // Then it should remove the duplicate values, preserving the first occurrence of each element
@@ -42,4 +51,4 @@ test("Given an array with strings or numbers, it returns an the array whit no du
     const targetOutput = ['a','b','c'];
 
     expect(currentOutput).toEqual(targetOutput);
-});
+});

Sprint-1/implement/max.js

@@ -8,7 +8,8 @@ function findMax(elements) {
     for (let i = 0; i < elements.length; i++) {
         let current = elements[i];
 
-        if (typeof current === "number") {
+        // using Number.isFinite keeps NaN or Infinity out of the comparison
+        if (typeof current === "number" && Number.isFinite(current)) {
             if (current > max) {
                 max = current;
             }

Sprint-1/implement/sum.js

@@ -7,7 +7,8 @@ function sum(elements) {
         let current = elements[i]; // get the current element
 
         // Only add it if it's a number
-        if (typeof current === "number" && !Number.isNaN(current)) {
+        // Number.isFinite skips NaN and Infinity, so only real numbers add to total
+        if (typeof current === "number" && Number.isFinite(current)) {
             total = total + current; // add to total
         }
     }

Sprint-1/implement/sum.test.js

@@ -51,7 +51,7 @@ test("given an  array whit a decimal/float number, returns correct total (decima
     const currentOutput = sum([1,2,3,4,3.5,]);
     const targetPitPut= 13.5;
 
-    expect(currentOutput).toEqual(targetPitPut);
+    expect(currentOutput).toBeCloseTo(targetPitPut); // allow tiny floating point differences
 })