updated the task based on reviewes feedback

Author: Dan2Clouted

Sprint-1/implement/dedupe.js

@@ -1,12 +1,11 @@
 function dedupe(array) {
   const result = [];
 
-  for (let i = 0; i < array.length; i++)
-    if (!result.includes(array[i])) {
-      result.push(array[i]);
+  for (const item of array) {
+    if (!result.includes(item)) {
+      result.push(item);
     }
-
-  return result;
+  }
 }
 
 module.exports = dedupe;

Sprint-1/implement/dedupe.test.js

@@ -28,7 +28,10 @@ test("given an empty array, it returns an empty array", () => {
 test("given an array with no duplicates, it returns a copy of the original array", () => {
   const input = [1, 2, 3];
   const expectedOutput = [1, 2, 3];
-  expect(dedupe(input)).toEqual(expectedOutput);
+  const result = dedupe(input);
+
+  expect(result).toEqual(expectedOutput);
+  expect(result).not.toBe(input);
 });
 
 // Given an array with strings or numbers

Sprint-1/implement/max.js

@@ -2,7 +2,11 @@ function findMax(elements) {
   let max = -Infinity;
 
   for (let i = 0; i < elements.length; i++) {
-    if (typeof elements[i] === "number" && elements[i] > max) {
+    if (
+      typeof elements[i] === "number" &&
+      !Number.isNaN(elements[i]) &&
+      elements[i] > max
+    ) {
       max = elements[i];
     }
   }

Sprint-1/implement/max.test.js

@@ -62,7 +62,7 @@ test("given an array with decimal numbers, it returns the largest decimal number
 // When passed to the max function
 // Then it should return the max and ignore non-numeric values
 test("given an array with non-number values, it returns the max and ignore non-numeric values", () => {
-  const input = [10, "hello", 20, null, 5];
+  const input = [10, "300", "hello", 20, null, 5];
   const expectedOutput = 20;
   expect(findMax(input)).toBe(expectedOutput);
 });

Sprint-1/implement/sum.js

@@ -2,7 +2,7 @@ function sum(elements) {
   let total = 0;
 
   for (let i = 0; i < elements.length; i++) {
-    if (typeof elements[i] === "number") {
+    if (Number.isFinite(elements[i])) {
       total += elements[i];
     }
   }

Sprint-1/implement/sum.test.js

@@ -43,16 +43,7 @@ test("given an array containing negative numbers, it returns the correct total s
 test("given an array with decimal numbers, it returns the correct total sum", () => {
   const input = [1.5, 2.3, 0.7];
   const expectedOutput = 4.5;
-  expect(sum(input)).toBe(expectedOutput);
-});
-
-// Given an array with decimal/float numbers
-// When passed to the sum function
-// Then it should return the correct total sum
-test("given an array with decimal numbers, it returns the correct total sum", () => {
-  const input = [1.5, 2.3, 0.7];
-  const expectedOutput = 4.5;
-  expect(sum(input)).toBe(expectedOutput);
+  expect(sum(input)).toBeCloseTo(expectedOutput);
 });
 
 // Given an array containing non-number values
@@ -64,15 +55,6 @@ test("given an array containing non-number values, it ignores them and returns t
   expect(sum(input)).toBe(expectedOutput);
 });
 
-// Given an array containing non-number values
-// When passed to the sum function
-// Then it should ignore the non-numerical values and return the sum of the numerical elements
-test("given an array containing non-number values, it ignores them and returns the sum of the numerical elements", () => {
-  const input = ["hello", "world"];
-  const expectedOutput = 0;
-  expect(sum(input)).toBe(expectedOutput);
-});
-
 // Given an array with only non-number values
 // When passed to the sum function
 // Then it should return the least surprising value given how it behaves for all other inputs