tally function fixed

Author: alizada-dev

Sprint-2/implement/tally.js

@@ -1,21 +1,20 @@
 function tally(arr) {
-    if (Array.isArray(arr)) {
+    if (!Array.isArray(arr)) {
+        throw new Error("The input should be an array!");
+    }
+        
+    const countObj = Object.create(null);
 
-        let countObj = {};
-    
-        for (const item of arr) {
-    
-            if (countObj[item]) {
-                countObj[item] = countObj[item] + 1;
-            } else {
-                countObj[item] = 1;
-            }
+    for (const item of arr) {
+
+        if (countObj[item]) {
+            countObj[item] = countObj[item] + 1;
+        } else {
+            countObj[item] = 1;
         }
-        
-        return countObj;
     }
-
-    else throw new Error("");
+    
+    return countObj;
 }
 
 module.exports = tally;

Sprint-2/implement/tally.test.js

@@ -47,6 +47,14 @@ test("tally on an array with duplicate items returns the counts for each uniqe i
     expect(givenInput).toEqual(targetOutput);
 })
 
+test("tally on ", () => {
+    const input = ["toString", "toString"];
+    const givenInput = tally(input);
+    const targetOutput = {toString: 2};
+
+    expect(givenInput).toEqual(targetOutput);
+})
+
 // Given an invalid input like a string
 // When passed to tally
 // Then it should throw an error