Skip to content

Commit f8bcc92

Browse files
committed
i have fixed little issues
1 parent 1cb5870 commit f8bcc92

2 files changed

Lines changed: 21 additions & 11 deletions

File tree

Sprint-1/fix/median.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ function calculateMedian(list) {
99
if (!Array.isArray(list)) {
1010
return null;
1111
}
12-
const numbersOnly = list.filter(item => typeof item === 'number');
12+
const numbersOnly = list.filter((item) => Number.isFinite(item));
1313
const sorted = numbersOnly.sort((a, b) => a - b);
1414

1515
if (sorted.length === 0) {

Sprint-1/implement/max.js

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,22 @@
1-
function findMax(elements){
2-
let max = -Infinity;
3-
for (let i = 0; i < elements.length; i++) {
4-
if (typeof elements[i] === "number")
5-
if (elements[i] > max) {
6-
max = elements[i];
7-
}
8-
}
9-
return max;
1+
function findMax(elements) {
2+
let max = -Infinity;
3+
let foundNumber = false;
4+
5+
for (let i = 0; i < elements.length; i++) {
6+
if (Number.isFinite(elements[i])) {
7+
foundNumber = true;
8+
9+
if (elements[i] > max) {
10+
max = elements[i];
11+
}
12+
}
13+
}
14+
15+
if (!foundNumber) {
16+
return null;
17+
}
18+
19+
return max;
1020
}
1121

12-
module.exports = findMax;
22+
module.exports = findMax;

0 commit comments

Comments
 (0)